Skip to content

Conversation

@jukkar
Copy link
Member

@jukkar jukkar commented Mar 5, 2018

The websocket support was originally introduced by PR #1271 but that PR was closed because it was too convoluted. Introducing the websocket support again. This PR contains relevant websocket related changes from PR #5035

nashif
nashif previously requested changes Mar 5, 2018
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are you removing the native_posix console?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some error while rebasing, @rveerama1 will send a fixed version shortly

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have been maintaining websocket patches in RPL BR sample. It was my mistake in rebasing things. I will fix it. Thanks @nashif

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed and pushed updated version.

@codecov-io
Copy link

codecov-io commented Mar 5, 2018

Codecov Report

Merging #6456 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #6456   +/-   ##
======================================
  Coverage    53.2%   53.2%           
======================================
  Files         436     436           
  Lines       41353   41353           
  Branches     7937    7937           
======================================
  Hits        22001   22001           
  Misses      16128   16128           
  Partials     3224    3224
Impacted Files Coverage Δ
subsys/shell/shell.c 47.16% <ø> (ø) ⬆️
subsys/net/lib/http/http.c 0% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d86b219...573d8af. Read the comment docs.

@rveerama1
Copy link
Contributor

Fixed CI errors.

This commit creates a websocket library that can be used by
applications. The websocket library implements currently only
server role and it uses services provided by net-app API.
The library supports TLS if enabled in configuration file.

This also adds websocket calls to HTTP app server if websocket
connection is established.

Signed-off-by: Jukka Rissanen <[email protected]>
@rveerama1 rveerama1 force-pushed the websocket branch 2 times, most recently from b9f8899 to 16197be Compare March 5, 2018 14:39
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

at the end of the sentence, add:

(as configured in the project's ``prj.conf`` file).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add what it does in response to the incoming requests.
It also appears you need to use a web browser to interact with this sample, but you don't talk about that here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears you interact with this sample app with a web browser, but you don't include that in these instructions.

@nashif nashif dismissed their stale review March 6, 2018 13:19

addressed

This is a http(s) server that supports also websocket.
It sends back any data sent to it over a websocket.

Signed-off-by: Jukka Rissanen <[email protected]>
jukkar added 3 commits March 6, 2018 16:05
This tests websocket by creating a websocket support http server
and sending data to it and verifying the returned data is the same.

Signed-off-by: Jukka Rissanen <[email protected]>
Add console driver that allows console session to be transferred
over a websocket connection.

Signed-off-by: Jukka Rissanen <[email protected]>
This sample application implements a web service that provides
zephyr console over websocket.

Signed-off-by: Jukka Rissanen <[email protected]>
@rveerama1
Copy link
Contributor

@dbkinder addressed your comments.

Copy link
Contributor

@dbkinder dbkinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jukkar jukkar merged commit 2f4fa71 into zephyrproject-rtos:master Mar 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants