-
Notifications
You must be signed in to change notification settings - Fork 8.2k
Websocket support #6456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Websocket support #6456
Conversation
drivers/console/CMakeLists.txt
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why are you removing the native_posix console?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some error while rebasing, @rveerama1 will send a fixed version shortly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have been maintaining websocket patches in RPL BR sample. It was my mistake in rebasing things. I will fix it. Thanks @nashif
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed and pushed updated version.
Codecov Report
@@ Coverage Diff @@
## master #6456 +/- ##
======================================
Coverage 53.2% 53.2%
======================================
Files 436 436
Lines 41353 41353
Branches 7937 7937
======================================
Hits 22001 22001
Misses 16128 16128
Partials 3224 3224
Continue to review full report at Codecov.
|
|
Fixed CI errors. |
This commit creates a websocket library that can be used by applications. The websocket library implements currently only server role and it uses services provided by net-app API. The library supports TLS if enabled in configuration file. This also adds websocket calls to HTTP app server if websocket connection is established. Signed-off-by: Jukka Rissanen <[email protected]>
b9f8899 to
16197be
Compare
samples/net/ws_console/README.rst
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
at the end of the sentence, add:
(as configured in the project's ``prj.conf`` file).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add what it does in response to the incoming requests.
It also appears you need to use a web browser to interact with this sample, but you don't talk about that here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It appears you interact with this sample app with a web browser, but you don't include that in these instructions.
This is a http(s) server that supports also websocket. It sends back any data sent to it over a websocket. Signed-off-by: Jukka Rissanen <[email protected]>
This tests websocket by creating a websocket support http server and sending data to it and verifying the returned data is the same. Signed-off-by: Jukka Rissanen <[email protected]>
Add console driver that allows console session to be transferred over a websocket connection. Signed-off-by: Jukka Rissanen <[email protected]>
This sample application implements a web service that provides zephyr console over websocket. Signed-off-by: Jukka Rissanen <[email protected]>
|
@dbkinder addressed your comments. |
dbkinder
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
The websocket support was originally introduced by PR #1271 but that PR was closed because it was too convoluted. Introducing the websocket support again. This PR contains relevant websocket related changes from PR #5035