Skip to content

Conversation

@Thalley
Copy link
Contributor

@Thalley Thalley commented Jun 28, 2022

Add API to do the BAP Broadcast Source Metadata update procedure,
which updates the metadata of a broadcast source while
it is streaming.

Signed-off-by: Emil Gydesen [email protected]

depends on #49946

@Thalley Thalley force-pushed the broadcast_source_metadata branch 3 times, most recently from 456e16a to 536fdc2 Compare June 29, 2022 12:10
@Thalley
Copy link
Contributor Author

Thalley commented Jun 29, 2022

Depends on #46204

@Thalley Thalley force-pushed the broadcast_source_metadata branch from 536fdc2 to 0cc291f Compare July 6, 2022 10:24
@Thalley
Copy link
Contributor Author

Thalley commented Jul 6, 2022

Rebased to solve merge conflicts

@Thalley Thalley force-pushed the broadcast_source_metadata branch 2 times, most recently from 94a1cdb to 2054a98 Compare July 12, 2022 11:52
@Thalley Thalley marked this pull request as ready for review July 12, 2022 11:52
@Thalley Thalley requested a review from cvinayak July 12, 2022 11:57
@Thalley Thalley force-pushed the broadcast_source_metadata branch from 2054a98 to aa2c77b Compare July 12, 2022 12:23
@Thalley Thalley force-pushed the broadcast_source_metadata branch from aa2c77b to db75771 Compare July 14, 2022 13:58
@Thalley Thalley requested a review from asbjornsabo July 14, 2022 13:58
asbjornsabo
asbjornsabo previously approved these changes Jul 15, 2022
@Thalley Thalley force-pushed the broadcast_source_metadata branch 3 times, most recently from 1d832ef to 595cb57 Compare July 19, 2022 09:30
@Thalley Thalley requested a review from asbjornsabo July 19, 2022 11:37
@Thalley
Copy link
Contributor Author

Thalley commented Jul 19, 2022

Rebased to handle API change from #44828

@Thalley Thalley assigned Thalley and unassigned asbjornsabo Jul 21, 2022
@Thalley Thalley force-pushed the broadcast_source_metadata branch 3 times, most recently from e6b902f to e468b45 Compare September 8, 2022 18:26
@Thalley Thalley marked this pull request as draft September 8, 2022 18:26
@Thalley
Copy link
Contributor Author

Thalley commented Sep 8, 2022

This PR now depends on #49946, and thus converted to a draft

@Thalley Thalley force-pushed the broadcast_source_metadata branch from e468b45 to 3e1d5d0 Compare September 9, 2022 12:12
@Thalley Thalley force-pushed the broadcast_source_metadata branch from 3e1d5d0 to 6520cc2 Compare October 24, 2022 09:50
@Thalley Thalley force-pushed the broadcast_source_metadata branch from 6520cc2 to bc989af Compare November 24, 2022 09:59
@Thalley Thalley marked this pull request as ready for review November 24, 2022 09:59
The codec is assigned to the stream. However since the metadata,
which is stored in the codec, may be modified by other means,
the stored pointer cannot be const, and thus the
codec argument to bt_audio_stream_reconfig cannot be const
either.

Signed-off-by: Emil Gydesen <[email protected]>
Add API to do the BAP Broadcast Source Metadata update procedure,
which updates the metadata of a broadcast source while
it is streaming.

This is also makes all checks for the "head stream" the same.

Signed-off-by: Emil Gydesen <[email protected]>
Move the functionality that is common between the two
broadcast sink test to a common function.

Signed-off-by: Emil Gydesen <[email protected]>
@Thalley Thalley force-pushed the broadcast_source_metadata branch from bc989af to aaa7e54 Compare November 25, 2022 21:28
@Thalley
Copy link
Contributor Author

Thalley commented Nov 25, 2022

Rebased on #51897

@kruithofa kruithofa self-requested a review December 13, 2022 07:23
Copy link
Contributor

@asbjornsabo asbjornsabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

/* Ensure that we also see the metadata update */
printk("Waiting for metadata update\n");
WAIT_FOR_FLAG(flag_base_metadata_updated)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

redundant new line

@carlescufi carlescufi merged commit 281a846 into zephyrproject-rtos:main Dec 20, 2022
@Thalley Thalley deleted the broadcast_source_metadata branch December 20, 2022 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants