LE Audio: Broadcast audio test update #46204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: Bluetooth
area: Bluetooth Host
Thalley
force-pushed
the
broadcast_audio_test_update
branch
3 times, most recently
from
4545f02 to
cc7b76c
Compare
Thalley
requested review from
Vudentz,
alwa-nordic,
asbjornsabo,
jhedberg and
wopu-ot
as code owners
Thalley
requested review from
Casper-Bonde-Bose,
MariuszSkamra,
cvinayak and
sjanc
Thalley
force-pushed
the
broadcast_audio_test_update
branch
from
cc7b76c to
b16b008
Compare
Contributor
Author
|
Updated to resolve merge conflicts |
Thalley
force-pushed
the
broadcast_audio_test_update
branch
from
b16b008 to
141df65
Compare
Contributor
Author
|
Rebased to solve merge conflicts |
Thalley
force-pushed
the
broadcast_audio_test_update
branch
from
141df65 to
7c77566
Compare
MariuszSkamra
previously approved these changes
Jul 6, 2022
Contributor
There was a problem hiding this comment.
nitpick, redundant newline
Thalley
force-pushed
the
broadcast_audio_test_update
branch
from
7c77566 to
b4cb568
Compare
Contributor
Author
|
Rebased to solve merge conflicts and fix #46204 (comment) |
Fix bad state check in biginfo_recv in bass.c which would cause null-pointer access. Signed-off-by: Emil Gydesen <[email protected]>
There is a brief period between the bt_iso_big_create and when the ISO channels are established. In this state it should be possible to call bt_audio_broadcast_source_stop to stop the BIG from being created. Signed-off-by: Emil Gydesen <[email protected]>
Add the state transition from connecting to disconnecting as a valid transition for ISO. This can occur if a ISO channel is disconnected before it is fully connected, of if a BIG or a BIG sync is terminated before established. Signed-off-by: Emil Gydesen <[email protected]>
Update the broadcast_source_test to actually create the BIG and send data over ISO. Signed-off-by: Emil Gydesen <[email protected]>
Update the broadcast_sink_test to use ISO to sync to the broadcast source BIG, testing both the syncing functionality as well as the sync stop and delete functions. Signed-off-by: Emil Gydesen <[email protected]>
Thalley
force-pushed
the
broadcast_audio_test_update
branch
from
b4cb568 to
17b8992
Compare
MariuszSkamra
approved these changes
Jul 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the broadcast audio babblesim tests to use ISO, as well as fixing a few bugs found along the way.
Fixes #44944