Skip to content

LE Audio: Broadcast audio list instead of array #44828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 18, 2022
Merged

LE Audio: Broadcast audio list instead of array #44828

merged 3 commits into from
Jul 18, 2022

Conversation

@Thalley
Copy link
Contributor

@Thalley Thalley commented Apr 13, 2022 •
edited
Loading

Modifies the broadcast source and sink APIs and implementations to use a slist instead of an array of pointers to hold the streams.

fixes #43767

@github-actions github-actions bot added area: API Changes to public APIs area: Bluetooth area: Bluetooth Audio area: Samples Samples area: Tests Issues related to a particular existing or missing test labels Apr 13, 2022
@Thalley
Copy link
Contributor Author

Thalley commented Apr 14, 2022

Depends on #43709

@Thalley Thalley force-pushed the audio_group_list branch from 7549601 to c422583 Compare May 12, 2022 11:04
@Thalley
Copy link
Contributor Author

Thalley commented May 12, 2022

Rebased to fix merge conflicts

@Thalley Thalley marked this pull request as ready for review May 12, 2022 11:04
@Thalley Thalley force-pushed the audio_group_list branch from c422583 to a7eff56 Compare May 13, 2022 09:26
@Thalley
Copy link
Contributor Author

Thalley commented May 13, 2022

Rebased to fix test failure

MariuszSkamra
MariuszSkamra requested changes May 24, 2022
View reviewed changes
@Thalley Thalley force-pushed the audio_group_list branch from a7eff56 to 7f432d1 Compare May 24, 2022 10:18
@Thalley Thalley requested a review from MariuszSkamra May 24, 2022 10:18
MariuszSkamra
MariuszSkamra previously approved these changes May 24, 2022
View reviewed changes
Casper-Bonde-Bose
Casper-Bonde-Bose previously approved these changes May 24, 2022
View reviewed changes
Copy link
Contributor

@Casper-Bonde-Bose Casper-Bonde-Bose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carlescufi
Copy link
Member

carlescufi commented Jun 5, 2022

@Thalley please rebase

@Thalley Thalley dismissed stale reviews from Casper-Bonde-Bose and MariuszSkamra via c2eeb6f June 6, 2022 08:34
@Thalley Thalley force-pushed the audio_group_list branch from 7f432d1 to c2eeb6f Compare June 6, 2022 08:34
@Thalley Thalley requested a review from sjanc as a code owner June 6, 2022 08:34
@zephyrbot zephyrbot requested a review from jori-nordic July 5, 2022 10:24
@Thalley Thalley force-pushed the audio_group_list branch from 074ba1c to fffd7c8 Compare July 6, 2022 10:18
@Thalley
Copy link
Contributor Author

Thalley commented Jul 6, 2022

Rebased to solve merge conflicts

@Thalley Thalley force-pushed the audio_group_list branch from fffd7c8 to a68ee8f Compare July 6, 2022 12:02
@Thalley
Copy link
Contributor Author

Thalley commented Jul 6, 2022

Rebased to solve merge conflicts

@carlescufi
Copy link
Member

carlescufi commented Jul 11, 2022

@MariuszSkamra please take a look

asbjornsabo
asbjornsabo reviewed Jul 11, 2022
View reviewed changes
Copy link
Contributor

@asbjornsabo asbjornsabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am wondering about the first commit - it does not really do much, and it does not seem to fit neither the title nor the description it has.
Otherwise, this looks sane to me.

(Posting this as a comment, not a "request changes", as I may not be able to follow up and do not want to block the PR.)

MariuszSkamra
MariuszSkamra previously approved these changes Jul 11, 2022
View reviewed changes
@Thalley Thalley requested a review from asbjornsabo July 11, 2022 13:42
@Thalley Thalley force-pushed the audio_group_list branch from a68ee8f to 720b98d Compare July 11, 2022 14:21
@Thalley
Copy link
Contributor Author

Thalley commented Jul 11, 2022

I am wondering about the first commit - it does not really do much, and it does not seem to fit neither the title nor the description it has. Otherwise, this looks sane to me.

(Posting this as a comment, not a "request changes", as I may not be able to follow up and do not want to block the PR.)

Squashed the first commit. Not sure how it ended up like that :D

@Thalley Thalley requested a review from MariuszSkamra July 11, 2022 14:22
@Thalley Thalley force-pushed the audio_group_list branch from 720b98d to 51ed3fa Compare July 12, 2022 07:44
@Thalley
Copy link
Contributor Author

Thalley commented Jul 12, 2022

Fixed build error after another commit was merged

asbjornsabo
asbjornsabo previously approved these changes Jul 12, 2022
View reviewed changes
@Thalley Thalley force-pushed the audio_group_list branch from 51ed3fa to e19a3cd Compare July 12, 2022 12:14
@Thalley
Copy link
Contributor Author

Thalley commented Jul 12, 2022

Rebased to solve merge conflicts

Thalley added 3 commits July 12, 2022 14:24
@Thalley
Bluetooth: Audio: Modify broadcast source to use a list of streams
39c4649 
Modify from array to list. The list approach is easily
implemented as it is used for the unicast groups, and
using the list approach instead of an array does not
require the array to be static.

Signed-off-by: Emil Gydesen <[email protected]>
@Thalley
Bluetooth: Audio: Modify broadcast sink to use list of streams
eed8bbb 
Modify the broadcast sink to use a list of streams instead
of an array. This removes the requirement that the array
of stream pointers shall be static, and makes the
broadcast sink API and implementation more similar
to the unicast group and broadcast source.

Signed-off-by: Emil Gydesen <[email protected]>
@Thalley
Bluetooth: Audio: User _ prefix for sys_snode_t nodes
49c3bf1 
The sys_snode_t nodes are used internally, and we use the
convention of the "_" prefix to indicate that this is
an internally used value.

Signed-off-by: Emil Gydesen <[email protected]>
@Thalley Thalley force-pushed the audio_group_list branch from e19a3cd to 49c3bf1 Compare July 12, 2022 12:25
@Thalley
Copy link
Contributor Author

Thalley commented Jul 12, 2022

Rebased to solve merge conflicts

@Thalley Thalley requested a review from asbjornsabo July 13, 2022 12:49
@carlescufi carlescufi merged commit 577caf7 into zephyrproject-rtos:main Jul 18, 2022
@Thalley Thalley mentioned this pull request Jul 19, 2022
Merged
@Thalley Thalley deleted the audio_group_list branch December 1, 2022 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carlescufi carlescufi carlescufi approved these changes

@asbjornsabo asbjornsabo asbjornsabo approved these changes

@alwa-nordic alwa-nordic Awaiting requested review from alwa-nordic

@jhedberg jhedberg Awaiting requested review from jhedberg

@Vudentz Vudentz Awaiting requested review from Vudentz

@wopu-ot wopu-ot Awaiting requested review from wopu-ot

@cvinayak cvinayak Awaiting requested review from cvinayak

@sjanc sjanc Awaiting requested review from sjanc

@Casper-Bonde-Bose Casper-Bonde-Bose Awaiting requested review from Casper-Bonde-Bose

@hermabe hermabe Awaiting requested review from hermabe

@jori-nordic jori-nordic Awaiting requested review from jori-nordic

@MariuszSkamra MariuszSkamra Awaiting requested review from MariuszSkamra

Assignees

@Thalley Thalley

Labels

area: API Changes to public APIs area: Bluetooth Audio area: Bluetooth area: Samples Samples area: Tests Issues related to a particular existing or missing test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

LE Audio: Broadcast sink/source use list of streams instead of array

5 participants

@Thalley @carlescufi @MariuszSkamra @asbjornsabo @Casper-Bonde-Bose