sensor:lis2mdl: remove '-magn' extension from lis2mdl name #19068
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
area: Boards
area: Samples
|
All checks are passing now. Review history of this comment for details about previous failed status. |
avisconti
force-pushed
the
change-lis2mdl-compatible-name
branch
2 times, most recently
from
529240f to
4beae3b
Compare
avisconti
force-pushed
the
change-lis2mdl-compatible-name
branch
from
4beae3b to
c24a7c6
Compare
galak
approved these changes
Sep 11, 2019
erwango
approved these changes
Sep 11, 2019
Contributor
|
Once we merge #19071 that should fix the CI issues in this PR. |
Contributor
Author
yes, sure. |
The LIS2MDL is not a combo device, but pure magnotemeter. Hence, '-magn' extension is not adding information and can be removed from dts compatible name as well as binding filename. Instead specify '-i2c' or '-spi' to distinguish between the names. Signed-off-by: Armando Visconti <[email protected]>
avisconti
force-pushed
the
change-lis2mdl-compatible-name
branch
from
c24a7c6 to
e3668b6
Compare
MaureenHelm
approved these changes
Sep 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The LIS2MDL is not a combo device, but pure magnotemeter.
Hence, '-magn' extension is not adding information and can
be removed from dts compatible name as well as binding filename.
Signed-off-by: Armando Visconti [email protected]
EDIT:
Built and tested on x_nucleo_iks01a2 and x_nucleo_iks01a3