Fix shield sample build issue for x_nucleo_iks01a2 #19071
Conversation
galak
requested review from
MaureenHelm,
avisconti,
carlescufi,
erwango,
ioannisg,
lemrey and
rsalveti
as code owners
avisconti
left a comment
avisconti
left a comment
There was a problem hiding this comment.
what about arm/stm32mp157c_dk2?
It includes arduino_r3_connector.dtsi where arduino_header is defined, but it does not
specify it as supported in the yaml file. Isn't it?
erwango
left a comment
erwango
left a comment
There was a problem hiding this comment.
As mentionned in comments, arduino_gpio would be a better fit
Change arduino_header depend to arduino_gpio as that is more meaningful. Its easy to mistake arduino_header to mean the board has an arduino header in general. What we want to depend on is that we have the gpio connector in the dts that has 'arduino_header' as the node label. Signed-off-by: Kumar Gala <[email protected]>
There are build issues with this sample now that it requires that the board dts have an arduino_header node. Add depends_on: arduino_gpio to sample.yaml so we only build this if the board has that header. Also remove a duplicate line for excluding the disco_l475_iot1 platform. Signed-off-by: Kumar Gala <[email protected]>
Missed it, now fixed. |
galak
added
the
Hotfix
Update a number of boards that have arduino_gpio and arduino_i2c support in their dts files to show that they support that in the board.yaml file. This allows coverage on several shield tests that utilize the tags 'arduino_gpio' and 'arduino_i2c'. Exlucde stm32mp157c_dk2 from some of the samples right now since the connector on the board doesn't support A2/A3. Also remove the duplicate of exluding disco_l475_iot1. Signed-off-by: Kumar Gala <[email protected]>
erwango
left a comment
erwango
left a comment
There was a problem hiding this comment.
Proposing an alternative to stm32mp157c_dk2 exclusion from shield sanitycheck
| depends_on: arduino_i2c arduino_header | ||
| platform_exclude: disco_l475_iot1 | ||
| depends_on: arduino_i2c arduino_gpio | ||
| platform_exclude: disco_l475_iot1 stm32mp157c_dk2 |
There was a problem hiding this comment.
Thinking again about it, I think we could also add a stm32mp157c_dk2 dedicated overlay in the shield removing the pins that don't match, rather than excl
This would allow to keep using the board wit the shield (which totally works).
What do you think?
There was a problem hiding this comment.
Agreed, but more work needs to be done for that, let's address that after we get this merged to fix the build issues.
See but #19078
There was a problem hiding this comment.
I tested successfully the following:
boards/shields/x_nucleo_iks01a2/boards/stm32mp157c_dk2.overlay
&arduino_i2c {
lsm303agr-magn@1e {
/delete-property/ irq-gpios; /* A3 */
};
lsm303agr-accel@19 {
/delete-property/ irq-gpios; /* A3 */
};
};
There was a problem hiding this comment.
Thanks, the x_nucleo_iks01a3 is the harder one to solve right now.
|
@erwango Going to merge this and handle fixing up |
6 participants
samples/shields/x_nucleo_iks01a2/sample.shields.x_nucleo_iks01a2 fails to build on a number of boards because they lack
arduino_headerin their dts. Make the sample depend onarduino_headerand update various boards to say they support this.