Add SensorTile.box board support and sample to test it #18182

avisconti · 2019-08-12T10:19:20Z

Add the BSP for SensorTile.box board with documentation.
And a sample code to test it out.

zephyrbot · 2019-08-12T10:23:13Z

All checks are passing now.

Tip: The bot edits this comment instead of posting a new one, so you can check the comment's history to see earlier messages.

boards/arm/sensortile_box/doc/index.rst

samples/boards/sensortile_box/README.rst

avisconti · 2019-08-13T09:54:03Z

@dbkinder
Thx! Applied all ur suggestions, re-based to latest master and re-pushed!

boards/arm/sensortile_box/sensortile_box.dts

dbkinder

one typo, otherwise LGTM

boards/arm/sensortile_box/doc/index.rst

avisconti · 2019-09-02T13:32:24Z

@dbkinder
Fixed and rebased

avisconti · 2019-09-11T09:28:59Z

I rebased this PR on top of #19068.

@dbkinder is now the doc fine?

@erwango @MaureenHelm
Any thoughts on this PR?

erwango

Few comments otherwise is good and clean

erwango · 2019-09-11T11:24:20Z

boards/arm/sensortile_box/doc/index.rst

erwango · 2019-09-11T11:27:57Z

boards/arm/sensortile_box/doc/index.rst

Since you provided the dfu-runner info, I guess that usual west flash command will work.
It would be good adding and example of west flash/debug commands for zephyr beginners.

erwango · 2019-09-11T11:37:07Z

boards/arm/sensortile_box/pinmux.c

_NSS pins should be defined under

#ifdef CONFIG_SPI_STM32_USE_HW_SS

Introduced in #17806

erwango · 2019-09-11T11:38:39Z

boards/arm/sensortile_box/pinmux.c

erwango · 2019-09-11T11:38:45Z

boards/arm/sensortile_box/pinmux.c

erwango · 2019-09-11T11:41:31Z

boards/arm/sensortile_box/sensortile_box_defconfig

Comment not in line with configuration, or misleading.

dbkinder

LGTM, thanks for the doc updates!

avisconti · 2019-09-12T08:44:09Z

@erwango
Thanks for the review. I will implement step by step as soon as possible.
I have a request for you and I may probably open an official request. The SensorTile.box
is using the STM32L4R9 SoC, but currently only STM32L4R5 is handled in zephyr, so I stick
on this one for the moment. Do you have plan to address it?

erwango · 2019-09-12T11:31:59Z

@avisconti, no issue with adding STM32L4R9. It could actually be done in the current PR, which will be used as validation. From what I see STM32L4R9 is a direct superset of STM32L4R5, so addition should be minor:

update soc/arm/st_stm32/stm32l4/Kconfig.soc with new reference
add soc/arm/st_stm32/stm32l4/Kconfig.defconfig.stm32l4r9xx file
add dts/arm/st/l4/stm32l4r9.dtsi as a superset of dts/arm/st/l4/stm32l4r5.dtsi
add dts/arm/st/l4/stm32l4r9X?.dtsi defining the soc memory attributes.

drivers/pinmux/stm32/pinmux_stm32l4x.h

boards/shields/x_nucleo_iks01a2/x_nucleo_iks01a2.overlay

avisconti · 2019-09-13T14:46:10Z

@avisconti, no issue with adding STM32L4R9. It could actually be done in the current PR, which will be used as validation. From what I see STM32L4R9 is a direct superset of STM32L4R5, so addition should be minor:

update soc/arm/st_stm32/stm32l4/Kconfig.soc with new reference

add soc/arm/st_stm32/stm32l4/Kconfig.defconfig.stm32l4r9xx file

add dts/arm/st/l4/stm32l4r9.dtsi as a superset of dts/arm/st/l4/stm32l4r5.dtsi

add dts/arm/st/l4/stm32l4r9X?.dtsi defining the soc memory attributes.

@erwango
OK, next week I'll take a look at it. I may need your help though.

avisconti · 2019-09-16T09:42:34Z

@avisconti, no issue with adding STM32L4R9. It could actually be done in the current PR, which will be used as validation. From what I see STM32L4R9 is a direct superset of STM32L4R5, so addition should be minor:

update soc/arm/st_stm32/stm32l4/Kconfig.soc with new reference

add soc/arm/st_stm32/stm32l4/Kconfig.defconfig.stm32l4r9xx file

add dts/arm/st/l4/stm32l4r9.dtsi as a superset of dts/arm/st/l4/stm32l4r5.dtsi

add dts/arm/st/l4/stm32l4r9X?.dtsi defining the soc memory attributes.

@erwango
OK, next week I'll take a look at it. I may need your help though.

@erwango,

I re-pushed it.
Now I added support for STM32L4R9 SoC. It is just an easy modification, so it would require some attention/suggestions from your side.

dts/arm/st/l4/stm32l4r9.dtsi

dts/arm/st/l4/stm32l4r9Xi.dtsi

soc/arm/st_stm32/stm32l4/Kconfig.defconfig.stm32l4r9xx

avisconti · 2019-09-18T12:30:58Z

@erwango
stm32l4r9.dtsi now only includes stm32l4r5.dtsi, that's all.
I think this was your intention.

Concerning flash size, is it same as stm32l4r5? I didn't check it to be honest...

erwango · 2019-09-18T12:39:30Z

@avisconti, You're using "zi" ("Xi") variant so, it should be the same.

The correct suffix name for selecting the GPIO for SPI Chip Select is _CS_GPIOS_CONTROLLER and not _CS_GPIO_CONTROLLER. Signed-off-by: Armando Visconti <[email protected]>

Add support for ST stm32l4r9xx System-on-Chip. See http://www.st.com/en/microcontrollers/stm32l4r9-s9.html for more details. Signed-off-by: Armando Visconti <[email protected]>

This commit adds: 1. pin definitions for SPI1 on PE12-15 on STM32L4 devices 2. SPI3 on PA15_SPI3_NSS Signed-off-by: Armando Visconti <[email protected]>

The SensorTile.box is a board designed for IoT applications embedding a wide range of intelligent low power MEMS sensors, a STM32L4 microcontroller to manage sensor configuration and process sensor output data, a micro-USB battery charging interface and an ST Bluetooth Low Energy module for wireless communication with a BLE-enabled smartphone. Signed-off-by: Armando Visconti <[email protected]>

Add sample to test SensorTile.box board. Signed-off-by: Armando Visconti <[email protected]>

avisconti · 2019-09-18T13:47:50Z

@dbkinder

Since IIS3DHHC driver has been recently merged (#19042) I decided to add to sample code also the test for it. And I have changed the sample documentation.

@erwango @galak

While testing IIS3DHHC for this board (is on SPI bus) I realize that there was some typos on CS_GPIO DT name. So I fixed it and put the fix in this PR (ebbdc8a)

avisconti requested review from MaureenHelm, erwango and galak August 12, 2019 10:19

avisconti requested review from dbkinder, nashif and rsalveti as code owners August 12, 2019 10:19

avisconti self-assigned this Aug 12, 2019

zephyrbot added area: Devicetree area: Boards area: Samples Samples labels Aug 12, 2019

avisconti force-pushed the add-stile-box branch from db08e9c to 7830d1e Compare August 12, 2019 11:58

erwango added the platform: STM32 ST Micro STM32 label Aug 12, 2019

dbkinder suggested changes Aug 12, 2019

View reviewed changes

avisconti force-pushed the add-stile-box branch from 7830d1e to ee949d6 Compare August 13, 2019 09:43

avisconti force-pushed the add-stile-box branch from ee949d6 to 1d5d77e Compare August 13, 2019 11:15

ydamigos reviewed Aug 13, 2019

View reviewed changes

boards/arm/sensortile_box/sensortile_box.dts Outdated Show resolved Hide resolved

avisconti force-pushed the add-stile-box branch from 1d5d77e to 433b307 Compare August 13, 2019 12:49

avisconti requested a review from dbkinder August 13, 2019 12:53

dbkinder suggested changes Aug 13, 2019

View reviewed changes

boards/arm/sensortile_box/doc/index.rst Outdated Show resolved Hide resolved

avisconti force-pushed the add-stile-box branch from 433b307 to cdda1b4 Compare September 2, 2019 13:30

avisconti requested a review from dbkinder September 2, 2019 13:31

avisconti added this to the v2.1.0 milestone Sep 3, 2019

avisconti force-pushed the add-stile-box branch from cdda1b4 to 261f2bf Compare September 11, 2019 09:24

avisconti force-pushed the add-stile-box branch from 261f2bf to 7810a7e Compare September 11, 2019 09:38

zephyrbot added area: Sensors Sensors area: Tests Issues related to a particular existing or missing test labels Sep 11, 2019

avisconti force-pushed the add-stile-box branch from 7810a7e to b0596c9 Compare September 11, 2019 09:49

erwango requested changes Sep 11, 2019

View reviewed changes

dbkinder approved these changes Sep 12, 2019

View reviewed changes

MaureenHelm requested changes Sep 12, 2019

View reviewed changes

drivers/pinmux/stm32/pinmux_stm32l4x.h Outdated Show resolved Hide resolved

boards/shields/x_nucleo_iks01a2/x_nucleo_iks01a2.overlay Outdated Show resolved Hide resolved

avisconti force-pushed the add-stile-box branch from b0596c9 to 5ad66ff Compare September 13, 2019 11:07

MaureenHelm approved these changes Sep 13, 2019

View reviewed changes

avisconti force-pushed the add-stile-box branch from 5ad66ff to 4110d97 Compare September 13, 2019 14:45

avisconti mentioned this pull request Sep 16, 2019

re-valuate commit 0951ce2 #19177

Closed

avisconti force-pushed the add-stile-box branch 2 times, most recently from 3c34e36 to 21dcf98 Compare September 16, 2019 09:39

avisconti requested a review from erwango September 16, 2019 16:06

erwango requested changes Sep 18, 2019

View reviewed changes

dts/arm/st/l4/stm32l4r9.dtsi Outdated Show resolved Hide resolved

dts/arm/st/l4/stm32l4r9.dtsi Outdated Show resolved Hide resolved

dts/arm/st/l4/stm32l4r9Xi.dtsi Outdated Show resolved Hide resolved

soc/arm/st_stm32/stm32l4/Kconfig.defconfig.stm32l4r9xx Outdated Show resolved Hide resolved

avisconti force-pushed the add-stile-box branch from 21dcf98 to 7dd04f1 Compare September 18, 2019 12:26

avisconti requested a review from erwango September 18, 2019 12:27

erwango approved these changes Sep 18, 2019

View reviewed changes

avisconti added 5 commits September 18, 2019 15:43

driver/sensor: IIS3DHHC: Fix DT_ macro typo for CS GPIO

ebbdc8a

The correct suffix name for selecting the GPIO for SPI Chip Select is _CS_GPIOS_CONTROLLER and not _CS_GPIO_CONTROLLER. Signed-off-by: Armando Visconti <[email protected]>

soc: arm: st: add stm32l4r9xx support

0ce6b2e

Add support for ST stm32l4r9xx System-on-Chip. See http://www.st.com/en/microcontrollers/stm32l4r9-s9.html for more details. Signed-off-by: Armando Visconti <[email protected]>

drivers: pinmux: stm32l4x: Add missing SPI macros

f471fba

This commit adds: 1. pin definitions for SPI1 on PE12-15 on STM32L4 devices 2. SPI3 on PA15_SPI3_NSS Signed-off-by: Armando Visconti <[email protected]>

sample/board: add SensorTile.box sample for testing

d407693

Add sample to test SensorTile.box board. Signed-off-by: Armando Visconti <[email protected]>

avisconti force-pushed the add-stile-box branch from 7dd04f1 to d407693 Compare September 18, 2019 13:44

avisconti requested a review from dbkinder September 18, 2019 13:48

galak merged commit af0e2c5 into zephyrproject-rtos:master Sep 19, 2019

Add SensorTile.box board support and sample to test it #18182

Add SensorTile.box board support and sample to test it #18182

Uh oh!

Conversation

avisconti commented Aug 12, 2019

Uh oh!

zephyrbot commented Aug 12, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

avisconti commented Aug 13, 2019

Uh oh!

Uh oh!

dbkinder left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

avisconti commented Sep 2, 2019

Uh oh!

avisconti commented Sep 11, 2019

Uh oh!

erwango left a comment

Choose a reason for hiding this comment

Uh oh!

erwango Sep 11, 2019

Choose a reason for hiding this comment

Uh oh!

erwango Sep 11, 2019

Choose a reason for hiding this comment

Uh oh!

erwango Sep 11, 2019

Choose a reason for hiding this comment

Uh oh!

erwango Sep 11, 2019

Choose a reason for hiding this comment

Uh oh!

erwango Sep 11, 2019

Choose a reason for hiding this comment

Uh oh!

erwango Sep 11, 2019

Choose a reason for hiding this comment

Uh oh!

dbkinder left a comment

Choose a reason for hiding this comment

Uh oh!

avisconti commented Sep 12, 2019

Uh oh!

erwango commented Sep 12, 2019

Uh oh!

Uh oh!

Uh oh!

avisconti commented Sep 13, 2019

Uh oh!

avisconti commented Sep 16, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

avisconti commented Sep 18, 2019

Uh oh!

erwango commented Sep 18, 2019

Uh oh!

avisconti commented Sep 18, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

zephyrbot commented Aug 12, 2019 •

edited

Loading

avisconti commented Sep 18, 2019 •

edited

Loading