drivers: spi: spi_ll_stm32: manage slave select and long line cleanup #17806
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yboutreux
requested review from
Mani-Sadhasivam,
MaureenHelm,
avisconti,
erwango,
galak,
rsalveti,
superna9999,
tbursztyka and
ydamigos
as code owners
tbursztyka
approved these changes
Jul 26, 2019
ydamigos
approved these changes
Jul 26, 2019
yboutreux
force-pushed
the
upstream_spi_ll_stm32
branch
2 times, most recently
from
a8ab920 to
2ab5496
Compare
erwango
approved these changes
Jul 30, 2019
Member
erwango
left a comment
erwango
left a comment
There was a problem hiding this comment.
Approved.
Due to the number of impacted boards, CI will likely never pass.
yboutreux
force-pushed
the
upstream_spi_ll_stm32
branch
from
2ab5496 to
91f86c8
Compare
Member
|
@galak, this one won't pass get shippable pass. |
yboutreux
force-pushed
the
upstream_spi_ll_stm32
branch
from
91f86c8 to
9d015b3
Compare
Allow the user to use software slave select instead of the hardware pin, in order to free the related GPIO and avoid unwanted SS triggering on the hardware pin. The default SS is still the hardware pin. Signed-off-by: Yaël Boutreux <[email protected]> Signed-off-by: Arnaud Pouliquen <[email protected]> Signed-off-by: Alexandre Torgue <[email protected]>
Split a long line remaining in the driver. Signed-off-by: Yaël Boutreux <[email protected]> Signed-off-by: Arnaud Pouliquen <[email protected]> Signed-off-by: Alexandre Torgue <[email protected]>
yboutreux
force-pushed
the
upstream_spi_ll_stm32
branch
from
9d015b3 to
f1fff26
Compare
Contributor
|
Merging by hand since we don't feel like this will ever complete CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow the user to use software slave select instead of the hardware pin, in order to free the related GPIO and avoid unwanted SS triggering on the hardware pin. The default SS is still the hardware pin.