Skip to content

functions for getting sample/node lists out of table collections #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 17, 2021

Conversation

molpopgen
Copy link
Member

@molpopgen molpopgen commented Apr 17, 2021

See #67. But it may be the case that these should be part of node table, so that they can be accessed from a tree sequence.

@molpopgen molpopgen linked an issue Apr 17, 2021 that may be closed by this pull request
@molpopgen molpopgen marked this pull request as draft April 17, 2021 00:06
@molpopgen
Copy link
Member Author

molpopgen commented Apr 17, 2021

should be part of node table

yes, and they should an expect an argument that is dyn impl TableAccess!

Edit: regular environment binding makes this unnecessary.

@molpopgen
Copy link
Member Author

Should pause this until #76 is done, as it'll simplify things.

@molpopgen molpopgen force-pushed the table_collection_list_of_samples branch from 6bc5511 to 530687d Compare April 17, 2021 19:52
@molpopgen molpopgen force-pushed the table_collection_list_of_samples branch from 77ce060 to f3f4f1e Compare April 17, 2021 21:23
@molpopgen molpopgen marked this pull request as ready for review April 17, 2021 21:27
@molpopgen molpopgen merged commit 43e14bb into main Apr 17, 2021
@molpopgen molpopgen deleted the table_collection_list_of_samples branch April 17, 2021 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TableCollection should be able to return a list of samples.
1 participant