update tests

Author: molpopgen

src/node_table.rs

@@ -184,7 +184,7 @@ impl<'a> NodeTable<'a> {
     /// is `true`.
     pub fn samples_as_vector(&self) -> Vec<tsk_id_t> {
         let mut samples: Vec<tsk_id_t> = vec![];
-        for row self.iter(false) {
+        for row in self.iter(false) {
             if row.flags & crate::TSK_NODE_IS_SAMPLE > 0 {
                 samples.push(row.id);
             }
@@ -218,20 +218,19 @@ impl<'a> NodeTable<'a> {
     /// tables
     ///     .add_node(tskit::TSK_NODE_IS_SAMPLE, 1.0, TSK_NULL, TSK_NULL)
     ///     .unwrap();
-    /// let samples = tables.create_node_id_vector(
-    ///     |row: &tskit::NodeTableRow, _: tsk_id_t| row.time > 0.,
+    /// let samples = tables.nodes().create_node_id_vector(
+    ///     |row: &tskit::NodeTableRow| row.time > 0.,
     /// );
     /// assert_eq!(samples[0], 1);
     ///
     /// // Get all nodes that have a mutation:
     ///
     /// fn node_has_mutation(
-    ///     tables: &tskit::TableCollection,
+    ///     tabled_type: &dyn tskit::TableAccess,
     ///     row: &tskit::NodeTableRow,
-    ///     i: tsk_id_t,
     /// ) -> bool {
-    ///     for mrow in tables.mutations_iter(false) {
-    ///         if mrow.node == i {
+    ///     for mrow in tabled_type.mutations_iter(false) {
+    ///         if mrow.node == row.id {
     ///             return true;
     ///         }
     ///     }
@@ -241,8 +240,8 @@ impl<'a> NodeTable<'a> {
     /// // Get all nodes that have a mutation:
     ///
     /// tables.add_mutation(0, 0, TSK_NULL, 0.0, None).unwrap();
-    /// let samples_with_mut = tables.create_node_id_vector(
-    ///     |row: &tskit::NodeTableRow, i: tsk_id_t| node_has_mutation(&tables, row, i));
+    /// let samples_with_mut = tables.nodes().create_node_id_vector(
+    ///     |row: &tskit::NodeTableRow| node_has_mutation(&tables, row));
     /// assert_eq!(samples_with_mut[0], 0);
     /// ```
     pub fn create_node_id_vector(