Skip to content

Conversation

@Adamj1232
Copy link
Contributor

@Adamj1232 Adamj1232 commented Jan 25, 2023

Description

✨ Highlights

📦 Changes per package

  • @web3-onboard/core: 2.14.0
  • @web3-onboard/dcent: 2.2.3
  • @web3-onboard/gnosis: 2.1.6
  • @web3-onboard/hw-common: 2.1.0
  • @web3-onboard/injected-wallets: 2.6.1
  • @web3-onboard/keepkey: 2.3.3
  • @web3-onboard/keystone: 2.3.3
  • @web3-onboard/ledger: 2.4.2
  • @web3-onboard/react: 2.6.0
  • @web3-onboard/trezor: 2.3.3
  • @web3-onboard/vue: 2.5.0

Checklist

  • The version field in package.json of the package you have made changes in is incremented following semantic versioning and using alpha release tagging
  • The box that allows repo maintainers to update this PR is checked
  • I tested locally to make sure this feature/fix works
  • I have run yarn file-check, yarn type-check & yarn build to confirm there are not any associated errors
  • This PR passes the Circle CI checks

Adamj1232 and others added 8 commits January 20, 2023 12:54
* adjust table font size
* Adds overflow hidden
* adjust for small viewport heights
* add 0 width space
* Update packages/hw-common/src/elements/TableHeader.svelte
* Update formatting + add note
* Add max-height + fix max-width
* update icon-container
- adjust sizing on desktop
- add svg styling to control sizing of 3rd party svgs
- remove code to pre-fill icon metadata
- update icon imports in components
- remove old bn svg file
* comment out logo and icon options in demo to view default bn-icon display
* Add hw versions to the demo project
* Add hw-common changes to dcent
* bump version in demo for testing

Co-authored-by: Adam Carpenter <[email protected]>
Co-authored-by: Gustavo Esquinca <[email protected]>
* Added theming updates to cover not dark mode mode

* Refine theme types, add actions to set themes through API, add validation

* updated layout further

* Remove docs files not needed

* Merge in develop

* Cleanup and fixes

* Notify matching theme

* Light mode looking good on notify

* Further refined tooling and themes

* TP now works with themes, updated default behavior

* Update handling of theme types

* restore changes to indicator

* Update Icon usage

* update blocknative-icon svg

* re-org and rename icon imports

* remove hover states from mobile

* Update packages to reflect fillColor icon use of css variable theming

* updates

* Minor fixups and functionality tightening

* Refactor logic for handling theme updates

* poc theming work

- define top-level component variable.
- comment old variable uses out for now.
- add custom border-color class to WalletAppBadge component.

* update close button to use only current text color

- we could potentially remove the use `--onboard-close-button-color` based on these changes.

* Update Account Select to use theming

* update minimized ac component

- use new theme top level variables
- adjust layout
- remove some helper classes

* update micro ac component

- use new variables
- tweak layout, width
- try to match class names with other components

* add new theming variables to account center expanded component

- use theme background-color, text-color, and border-color
- comment out old styles for now
- adjust borders + padding spacing

* remove blue check from dapp info area

- removing because this is purely cosmetic at the moment.

* Add system option and check to theming

* account center expanded tweaks

- use --w3o-accent-text-color for  --action-color
- remove border radius from .wallets-section. We don't need it here since the parent has it.
- use white background for WalletAppBadge.

* update WalletRow component

- use new theming variables for text and bg hover color
- use ::before element trick for bg hovers

* add z-index to bg hover element

* Updating theme customizer in docs

* add fallback legacy variables for connect modal

* add legacy variable fallbacks to account center

- resolve commented out lines

* correct app name spacing

- remove h4 and p element. These elements have no semantic value in this context. No need to use.

* Update zindex of theming tool to avoid clash with docs themer

* add legacy variable override to closebutton

* update app-name styles

* remove comment for action color

* Fix ternary in handling mobile

* Cleanup defaults

* add font family override for AC button

* update WalletRow

- remove commented out code.
- add back overrides using more specific legacy variables.
- set default variable values to unset in theme mapping.

* Fix validation

* Fix validation for theming

* Update copiable theming code from customizer

* remove comments

* fix network select color issue

- remove extra space
- set --account-center-network-selector-color to --text-color

* add back border-bottom for mobile designs

* update theming variables names and values

- update --w3o variable names
- set old variables to unset for now

* fix WalletRow z-index issue

- options menu display above now

* update theme var names and set new default values

- matches new design
- supports light/dark themes
- supports older variables

* update connect modal

- use theme var names
- set new default values

* update notify border

- use new variable names

* update transaction preview components

- use new theme variables
- set default values to match design

* update notify and transaction-preview

- unset theme mapping variables
- add new theme variables

* Refactor functionality and cleanup logic

* Ready for testing

* Fix up themeing tool in docs

* Add custom theming option, enable account center

* remove --w3o-tp variables from transaction preview components

* Remove mock transaction code

* Add theming docs

* small tweaks to theme customizer

* add border-radius theme var to connect and account-center

* update indicators to use action-color theme var

- set fallback values

* update default box-shadow color

* Refine ts and README notes around theming

* Update docs/src/lib/components/ThemeCustomizer.svelte

* Update packages/transaction-preview/src/views/Maximized.svelte

* Clean up demo

* Update packages/core/src/views/account-center/WalletRow.svelte

* Update packages/transaction-preview/src/views/Maximized.svelte

* Update packages/core/src/views/account-center/WalletRow.svelte

* Fix handling of custom theme in theme customizer

* Add quickstart options to README and docs for all examples we have available

* Fix up docs layout

* Cleanup readme

* Add svelte example to options list

* Fix up core docs

* hook up hardware wallet components to theme vars

- some minor cleanup

* Update poweredBy svg var

* Update poweredBy svg var

* Fix sidebar theming

* Add rxjs handling to event listener

* update poweredby and default icon graphics

- import newer default icon svg
- use newer poweredby graphic in account center
- remove older "powered by" span with text
- plug in theme values for color to control svg
- update svg fill to use currentColor

* remove unused svg files

* Remove behavior subject

* ignore to keystone AirGapped type issue

* Handle issue for readme

Co-authored-by: Gustavo Esquinca <[email protected]>
* feat: rainbow injected provider support
* bumped @web3-onboard/injected-wallets version
* version bumpies

Co-authored-by: Taylor Dawson <[email protected]>
…d Disable Connect Modal close config (#1480)

* Working as expected still some tweaks required

* Add default comment to disableClose prop

* Update docs site for changes

* revert demo

* Bump versions mixed in merge

* Update injected wallets list

* Bump dcent version
* Fix: typo

Fix: typo

* Fix: typos

Fix: typos

* Fix: typo

Fix: typo

* Fix: typos

Fix: typos

* Fix: typos

Fix: typos
@Adamj1232 Adamj1232 requested review from gesquinca, lnbc1QWFyb24 and taylorjdawson and removed request for lnbc1QWFyb24 January 25, 2023 23:16
Copy link
Contributor

@lnbc1QWFyb24 lnbc1QWFyb24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Adamj1232 Adamj1232 merged commit a8ed0c9 into v2-web3-onboard Jan 26, 2023
@Adamj1232 Adamj1232 deleted the release/2.19.0 branch January 26, 2023 17:35
@Adamj1232 Adamj1232 restored the release/2.19.0 branch January 26, 2023 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants