Skip to content

Conversation

@DanielSinclair
Copy link
Contributor

@DanielSinclair DanielSinclair commented Jan 19, 2023

Description

Support for Rainbow Wallet injected provider

Checklist

  • The version field in package.json of the package you have made changes in is incremented following semantic versioning and using alpha release tagging
  • The box that allows repo maintainers to update this PR is checked
  • I tested locally to make sure this feature/fix works
  • I have run yarn file-check, yarn type-check & yarn build to confirm there are not any associated errors
  • This PR passes the Circle CI checks

If this PR includes changes to add an injected wallet or SDK wallet module:

Please complete the following using the internal demo package.
To run this demo use the command yarn && yarn dev to get the project running at http://localhost:8080/

Tests with demo app (injected)

  • send transaction
  • switch chains
  • sign message
  • sign typed message
  • disconnect

Without Rainbow Wallet

Screenshot 2023-01-18 at 7 57 32 PM

Rainbow Wallet detected

Screenshot 2023-01-18 at 7 33 49 PM

Rainbow Wallet Connecting

Screenshot 2023-01-18 at 7 58 23 PM

@vercel
Copy link

vercel bot commented Jan 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
web3-onboard-docs ❌ Failed (Inspect) Jan 25, 2023 at 9:31PM (UTC)

@lnbc1QWFyb24
Copy link
Contributor

Thanks for this @DanielSinclair we'll get this reviewed as soon as possible.

@taylorjdawson
Copy link
Contributor

@DanielSinclair pulling to test but code looks good! Could you resolve the merge conflicts as well? Thanks 🙏🏾

@DanielSinclair
Copy link
Contributor Author

@taylorjdawson done ✅

@taylorjdawson taylorjdawson merged commit 17dd23b into thirdweb-dev:v2-web3-onboard-develop Jan 25, 2023
This was referenced Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants