-
Notifications
You must be signed in to change notification settings - Fork 542
Enhancement/hw wallets mobile #1453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement/hw wallets mobile #1453
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@taylorjdawson small update commented - would be helpful to have some screenshots or videos of the changes in the PR description (so I dont have to pull it down and run to see the changes) along with a description of the changes and any points of focus 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks solid man!!
Few points
- removal of empty lines
- adding new icon and logo notes to docs
- no version bump for ledger since it doesnt use HW-common anymore
Co-authored-by: Adam Carpenter <[email protected]>
Adamj1232
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just the package versions updates for core and latest develop branch merged
- adjust sizing on desktop - add svg styling to control sizing of 3rd party svgs - remove code to pre-fill icon metadata - update icon imports in components - remove old bn svg file
Description
Checklist
package.jsonis incremented following semantic versioningyarn file-check,yarn type-check&yarn buildto confirm there are not any associated errors