Skip to content

Conversation

@taylorjdawson
Copy link
Contributor

Description

Checklist

  • The version field in package.json is incremented following semantic versioning
  • The box that allows repo maintainers to update this PR is checked
  • I tested locally to make sure this feature/fix works
  • I have run yarn file-check, yarn type-check & yarn build to confirm there are not any associated errors
  • This PR passes the Circle CI checks

@vercel
Copy link

vercel bot commented Jan 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
web3-onboard-docs ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 24, 2023 at 4:56PM (UTC)

@Adamj1232
Copy link
Contributor

Adamj1232 commented Jan 10, 2023

@taylorjdawson small update commented - would be helpful to have some screenshots or videos of the changes in the PR description (so I dont have to pull it down and run to see the changes) along with a description of the changes and any points of focus 😄

Copy link
Contributor

@Adamj1232 Adamj1232 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks solid man!!
Few points

  • removal of empty lines
  • adding new icon and logo notes to docs
  • no version bump for ledger since it doesnt use HW-common anymore

Copy link
Contributor

@Adamj1232 Adamj1232 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the package versions updates for core and latest develop branch merged

- adjust sizing on desktop
- add svg styling to control sizing of 3rd party svgs
- remove code to pre-fill icon metadata
- update icon imports in components
- remove old bn svg file
@taylorjdawson taylorjdawson merged commit 3bf7c48 into v2-web3-onboard-develop Jan 24, 2023
@taylorjdawson taylorjdawson deleted the enhancement/hw-wallets-mobile branch January 24, 2023 19:37
This was referenced Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants