Disable IfChange / ThenChange Lint clause from vended protos #5692
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesHollyer
approved these changes
May 2, 2022
nfelt
reviewed
May 2, 2022
Contributor
There was a problem hiding this comment.
Kind of a nit, but for cases like this, this leaves behind a somewhat confusing fragment with the latter half of the LINT directive. Would be a bit nicer if we either were to strip the entire thing, or leave some explanatory replacement like // Disabled ThenChange block: (
bileschi
force-pushed
the
if-this-than-no-thanks
branch
from
dcf7fa6 to
e1ae923
Compare
bileschi
changed the title
Contributor
|
I wrote the script to make these updates automatically. I think it makes sense to just merge these changes in the same PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These lint clauses make sense in the original repo these files are vended from. They are not useful here as the linked file does not exist in our repo, and we should not be manually changing these files anyway.
The change is innocuous in open source but the lint clauses trigger warning within Google's internal CI.
A subsequent change to
tensorboard/compat/proto/update.shwill disable these lints automatically to prevent their reintroduction.