Remove LINT check from copied proto files #5693
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfelt
approved these changes
May 4, 2022
tensorboard/compat/proto/update.sh
Outdated
| -e 's|tensorflow\.DataType|tensorboard.DataType|g;' \ | ||
| -e 's|tensorflow\.TensorProto|tensorboard.TensorProto|g;' \ | ||
| -e 's|tensorflow\.TensorShapeProto|tensorboard.TensorShapeProto|g;' \ | ||
| -e 's|LINT\.|DISABLED.|g;' \ |
Contributor
There was a problem hiding this comment.
Could we narrow this matching a little bit, for example like this?
s|^// LINT\.|// DISABLED.|g;
That way it will only match LINT. if it's at the start of the line and preceded by // .
yatbear
pushed a commit
to yatbear/tensorboard
that referenced
this pull request
Mar 27, 2023
* Update script and run it * fix tests * make LINT regex more specific
dna2github
pushed a commit
to dna2fork/tensorboard
that referenced
this pull request
May 1, 2023
* Update script and run it * fix tests * make LINT regex more specific
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for features / changes
These lint checks are needed to ensure the Tensorflow proto files stay in sync with each other. However, in Tensorboard we do not make changes to these files so they do not need to stay synced. Furthermore the checks are looking for files that we do not copy over to Tensorboard so they actually fail.
Technical description of changes
This change updates the script we use to copy the proto files so that we disable the lint checks automatically every time we copy them. I also ran the script as done in this PR which was our latest update to these proto files for the 2.9 release.