Skip to content

Disable IfChange / ThenChange Lint clause from vended protos #5692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Disable IfChange / ThenChange Lint clause from vended protos #5692

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tensorboard/compat/proto/attr_value.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ option go_package = "github.com/tensorflow/tensorflow/tensorflow/go/core/framewo
// Comment indicates the corresponding attr type. Only the field matching the
// attr type may be filled.
message AttrValue {
// LINT.IfChange
// DISABLED.IfChange
message ListValue {
repeated bytes s = 2; // "list(string)"
repeated int64 i = 3 [packed = true]; // "list(int)"
Expand All @@ -27,7 +27,7 @@ message AttrValue {
repeated TensorProto tensor = 8; // "list(tensor)"
repeated NameAttrList func = 9; // "list(attr)"
}
// LINT.ThenChange(//tensorflow/c/c_api.cc)
// DISABLED.ThenChange(//tensorflow/c/c_api.cc)

oneof value {
bytes s = 2; // "string"
Expand Down
4 changes: 2 additions & 2 deletions tensorboard/compat/proto/full_type.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ option java_multiple_files = true;
option java_package = "org.tensorflow.framework";
option go_package = "github.com/tensorflow/tensorflow/tensorflow/go/core/framework/full_type_go_proto";

// LINT.IfChange
// DISABLED.IfChange
// Experimental. Represents the complete type information of a TensorFlow value.
enum FullTypeId {
// The default represents an uninitialized values.
Expand Down Expand Up @@ -275,4 +275,4 @@ message FullTypeDef {
// TODO(mdan): list/tensor, map? Need to reconcile with TFT_RECORD, etc.
}
}
// LINT.ThenChange(../ir/types/attributes.td)
// DISABLED.ThenChange(../ir/types/attributes.td)
4 changes: 2 additions & 2 deletions tensorboard/compat/proto/op_def.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ option go_package = "github.com/tensorflow/tensorflow/tensorflow/go/core/framewo

// Defines an operation. A NodeDef in a GraphDef specifies an Op by
// using the "op" field which should match the name of a OpDef.
// LINT.IfChange
// DISABLED.IfChange
message OpDef {
// Op names starting with an underscore are reserved for internal use.
// Names should be CamelCase and match the regexp "[A-Z][a-zA-Z0-9>_]*".
Expand Down Expand Up @@ -175,7 +175,7 @@ message OpDef {
// trigger TF network failure handling logics.
bool is_distributed_communication = 21;
}
// LINT.ThenChange(
// DISABLED.ThenChange(
// https://www.tensorflow.org/code/tensorboard/compat/proto/op_def_util.cc)
Copy link
Contributor

@nfelt nfelt May 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kind of a nit, but for cases like this, this leaves behind a somewhat confusing fragment with the latter half of the LINT directive. Would be a bit nicer if we either were to strip the entire thing, or leave some explanatory replacement like // Disabled ThenChange block: (


// Information about version-dependent deprecation of an op
Expand Down
4 changes: 2 additions & 2 deletions tensorboard/compat/proto/types.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ option java_package = "org.tensorflow.framework";
option go_package = "github.com/tensorflow/tensorflow/tensorflow/go/core/framework/types_go_proto";

// (== suppress_warning documentation-presence ==)
// LINT.IfChange
// DISABLED.IfChange
enum DataType {
// Not a legal value for DataType. Used to indicate a DataType field
// has not been set.
Expand Down Expand Up @@ -67,7 +67,7 @@ enum DataType {
DT_UINT32_REF = 122;
DT_UINT64_REF = 123;
}
// LINT.ThenChange(
// DISABLED.ThenChange(
// https://www.tensorflow.org/code/tensorflow/c/tf_datatype.h,
// https://www.tensorflow.org/code/tensorflow/go/tensor.go,
// https://www.tensorflow.org/code/tensorboard/compat/proto/tensor.cc,
Expand Down