FIX: Better implementation of py36 testing #384
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
We can get this merged as soon as the test suite passes. |
Squadrick
approved these changes
Jul 31, 2019
facaiy
reviewed
Aug 1, 2019
| fi | ||
|
|
||
| DOCKER_CMD="ln -sf ${PYTHON_LIB} /usr/bin/python && ${COMMAND}" | ||
| DOCKER_CMD="tools/ci_testing/install_py36.sh && ln -sf ${PYTHON_LIB} /usr/bin/python && ${COMMAND}" |
Member
There was a problem hiding this comment.
How about moving the installation to 79 line ?
case ${PYTHON} in
py2) ENVIRONMENT_CMD = xxx
py3) ENVIRONMENT_CMD = install_py36.sh and set environment variable
DOCER_CMD="${ENVIRONMENT_CMD} && ${COMMAND}"
facaiy
reviewed
Aug 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Squadrick @tensorflow/sig-addons-maintainers this should work better. Apologies.
Installing py36 is only safe to do knowing the user is running in a docker container.