Skip to content

Commit 05f50b5

Browse files
seanpmorganSquadrick
authored andcommitted
Cleaner implementation of py36 testing (#384)
1 parent 8daad7b commit 05f50b5

File tree

4 files changed

+3
-4
lines changed

4 files changed

+3
-4
lines changed

tools/ci_testing/addons_cpu.sh

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@ if [[ ${PLATFORM} == "darwin" ]]; then
3131
N_JOBS=$(sysctl -n hw.ncpu)
3232
else
3333
N_JOBS=$(grep -c ^processor /proc/cpuinfo)
34-
tools/ci_testing/install_py36.sh # Patch to test on py36
3534
fi
3635

3736

@@ -40,7 +39,7 @@ echo "Bazel will use ${N_JOBS} concurrent job(s)."
4039
echo ""
4140

4241
export CC_OPT_FLAGS='-mavx'
43-
export TF_NEED_CUDA=0 # TODO: Verify this is used in GPU custom-op
42+
export TF_NEED_CUDA=0
4443

4544
export PYTHON_BIN_PATH=`which python`
4645
ls -alh $PYTHON_BIN_PATH

tools/ci_testing/addons_gpu.sh

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ fi
2525

2626
set -x
2727

28-
tools/ci_testing/install_py36.sh # Patch to test on py36
2928
N_JOBS=1 # Must limit GPU testing to single job to prevent OOM error.
3029

3130
echo ""

tools/ci_testing/install_py36.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ apt-get -y -qq update && apt-get -y -qq install python3.6
2525

2626
python3.6 get-pip.py -q
2727
python3.6 -m pip --version
28+
rm get-pip.py
2829

2930
ln -sfn /usr/bin/python3.6 /usr/bin/python3
3031
pip3 install scipy # Pre-installed in custom-op

tools/run_docker.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ if [[ -z "${COMMAND}" ]]; then
8888
exit 1
8989
fi
9090

91-
DOCKER_CMD="ln -sf ${PYTHON_LIB} /usr/bin/python && ${COMMAND}"
91+
DOCKER_CMD="tools/ci_testing/install_py36.sh && ln -sf ${PYTHON_LIB} /usr/bin/python && ${COMMAND}"
9292
echo "Docker image: ${DOCKER_IMAGE}"
9393
echo "Docker command: ${DOCKER_CMD}"
9494
docker run ${DOCKER_OPTS} \

0 commit comments

Comments
 (0)