TEST: Upgrade python3 env to py36 #382
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Hmmm so I just realized that we tell people to run these shell scripts from our makefile in the CONTRIBUTING doc. Those scripts shouldn't be installing anything if thats the case, but I don't think we should restrict what our ci_test scripts do. IMO we should have separate scripts for CI and Local. @facaiy Thoughts? |
Member
Author
|
Alternatively we could append running this install script in the docker script: ... Leaning toward this. |
Member
|
#384 looks better. Thank Sean |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #279.
Py34 pip packages for tf-nightly have not been produced in ~2 weeks. When the new build env arrives we'll be re-vamping our testing scripts anyway.