-
Couldn't load subscription status.
- Fork 605
Add props page-mode #80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Can you give a demo or case ? I don't think it's very useful. |
|
@amatakasap Thank you for this - this was exactly what I was looking for! @tangbc The feature makes the scroller for the Virtual Scroller List use the windows scroll-bar instead of the div scrollbar - so the virtual scrolling is hidden and the standard window scrollbar is used in place. Edit: Upon playing around with the pagemode changes some more - it looks like your Offset calculation needs adjusting for when the Virtual-scroll-list is not the first item in the Window. Just deducting the Virtual List elements top offset from the Window Y-axis offset seems to have corrected the calculation. 👍
|
|
Is it better to provide a prop |
|
I'm not sure I totally understand the question - but I think you're referring to the pageMode prop that is part of the changes? |
|
@ConfusedCitizen In this case |
|
@tangbc remain and size remain functionally the same - this change is merely an adjustment to utilise the Window scrollbar instead of a container scrollbar. |
|
@ConfusedCitizen It would be better if you could do that. I'm still confused about the scene. 😳 |
|
@tangbc spent an hour putting together a demo on Sunday only to have my PC crash and lose all the work. |
|
hey @tangbc, sorry for the long delay - it's been a hectic few months at work. I have also included the latest version of the plugins index.js with the pageMode changes along with the demo. Cheers, |
|
ok, I will check later. |
|
This PR helped me, my UI is using a combination of fixed headers / footers a large center data list (using this lib) and an affixed sidebar that scrolls with the content using https://github.com/eddiemf/vue-affix scroll. Therefore it was ideal to only use the window scrollbar instead of a nested scroll bar. |
|
Already pr by #103 |
Could not restore scroll position using scrollBehavior of vue-router.
Therefore, we added pageMode to change the scroll target to "window".