Skip to content

Conversation

@Stormtv
Copy link
Contributor

@Stormtv Stormtv commented May 7, 2019

I took #80 and merged it with current version of vue-virtual-scroll-list

@codecov-io
Copy link

codecov-io commented May 7, 2019

Codecov Report

Merging #103 into master will increase coverage by 3.49%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #103      +/-   ##
==========================================
+ Coverage   93.47%   96.96%   +3.49%     
==========================================
  Files           1        1              
  Lines         184      198      +14     
==========================================
+ Hits          172      192      +20     
+ Misses         12        6       -6
Impacted Files Coverage Δ
src/index.js 96.96% <100%> (+3.49%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb7450e...e63a071. Read the comment docs.

@Stormtv
Copy link
Contributor Author

Stormtv commented May 7, 2019

I tried to get the coverage higher but I'm not an expert with Jest unit testing. I couldn't figure out the proper way to emulate window events.

@tangbc
Copy link
Owner

tangbc commented May 8, 2019

I seem that demo of pagemode still has obvious bugs, such as:
image

This component calculates the rendering area by fixed container height, if using window, it also need
calculate with window height, it should be trouble.

@Stormtv
Copy link
Contributor Author

Stormtv commented May 8, 2019

Okay I must of missed that I'll take a look again and fix it.

@tangbc
Copy link
Owner

tangbc commented May 8, 2019

Run npm run demo:dev is the develop env of demos in your local.

@Stormtv
Copy link
Contributor Author

Stormtv commented May 9, 2019

I think I fixed the issue you were describing, if I missed something please let me know. I appreciate the feedback!

@tangbc
Copy link
Owner

tangbc commented May 12, 2019

Thanks, but busy these days, I will check when I'm free.

@tangbc tangbc merged commit e63a071 into tangbc:master May 14, 2019
@tangbc tangbc mentioned this pull request Jun 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants