Update Master #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
List height is determined by item height and visible items number (`remain` prop) and this works flawless as long as this number is {Integer}. But... when `remain` prop is set dynamically to {Float} (for ex.: list fills all available vertical space in UI), last item in scrollable list won't be rendered (for ex.: `delta.end' can equal `58.6` for `59` items, so only 58 slots are rendered).
This solution fixes the problem.
…ng the 'keeps' vnodes when it needs
Adding list role to virtual-scoll add list-item to for loop item give correct parent child relationship
Adding role of group so if role list-item is added on the children the parent controls are correct
role 'group' add to list wrap Add unit test to aria roles and states.
Add demo using aria Working demo for aria
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.