Add support for selecting which parent element to scroll with using scrollelement prop #114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ual-scroll-list is offset from the top
Codecov Report
@@ Coverage Diff @@
## master #114 +/- ##
==========================================
- Coverage 96.98% 94.33% -2.65%
==========================================
Files 1 1
Lines 199 212 +13
==========================================
+ Hits 193 200 +7
- Misses 6 12 +6
Continue to review full report at Codecov.
|
|
Merged and published in v1.4.0 |
|
Thanks! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a scrollelement prop to allow picking any parent element to scroll with instead of just body. As suggested in #80 (comment). In addition, pagemode's handling of offset has been changed to properly support situations where the virtual-scroll-list is not at the top of the body but offset from it.
Note that the scrollelement prop doesn't support window/body, for which pagemode should still be used. When pagemode is set to true, scrollelement is ignored.