[Sema] Treat package decls as exported
#70265
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elsh
requested review from
hborla,
slavapestov,
tshortli and
xedin
as code owners
Currently, a package symbol imported via @_implementationOnly is permitted in a package interface declaration, and can be accessed by its client, potentially leading to a ub. It should not be allowed as the package symbol in such scenario should be treated as internal details. This PR addresses the issue by treating a package decl as exported, as it is "public" within a package boundary. Ref rdar://117586046
Contributor
Author
|
@swift-ci test |
Contributor
|
I would expect this change to the exportability logic to covert more cases. Could you add tests for those as well? I'm thinking about references from inlinable code (you can probably reuse parts of the tests in #64033), references through conformances and typealias underlying (see the tests in #68776) and extensions to implementation-only imported types (see tests in #68954). |
Contributor
Author
|
Will revisit after other PRs are merged. |
Contributor
Author
|
Closing as addressed in a separate PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, a package symbol imported via @_implementationOnly is permitted in a package interface declaration, and can be accessed by its client, potentially leading to a ub. It should not be allowed as the package symbol in such scenario should be treated as internal details.
This PR addresses the issue by treating a package decl as exported, as it is "public" within a package boundary.
Ref rdar://117586046