Sema: report conformances and typealias underlying types behind non-public imports #68776
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e code Conformances imported as non-public cannot be used in API or inlinable code, report it as an error.
Exportability checking logic detects when decls are referenced from API or inlinable code. This duplicates the check applied for the access level. Skip the exportability reports about non-public imports and keep the more familiar access-level check.
Typealiases with an underlying type from a non-public import cannot be used in API or inlinable code. Report this as an error.
Contributor
Author
|
@swift-ci Please smoke test |
tshortli
approved these changes
Sep 26, 2023
| public import ConformanceBaseTypes | ||
| internal import ConformanceDefinition | ||
|
|
||
| public func useInAPI(a: any Proto = ConformingType()) { // expected-error {{cannot use conformance of 'ConformingType' to 'Proto' here; 'ConformanceDefinition' was not imported publicly}} |
Contributor
There was a problem hiding this comment.
Should there be a corresponding note: on the import decl?
Contributor
Author
There was a problem hiding this comment.
Very good point. I've added the note.
Contributor
Author
|
@swift-ci Please smoke test macOS |
Contributor
Author
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend exportability checking to support non-public imports in some cases. Error on conformances imported from a non-public import is used in API, and on typealiases that desugars to a type behind a non-public import is used in API. Do no use the exportability checking logic for other checks that are already handled by the checks on the access levels.