[Sema] Report use of decls imported as non-public in inlinable code #64033
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inlinable code can only refer to public types, so either local public types or public types imported publicly. Report any decl imported as non-public in inlinable code. rdar://105902141
Contributor
Author
|
@swift-ci Please smoke test |
xymus
commented
Mar 2, 2023
| package import PackageLib // expected-note 2 {{module 'PackageLib' imported as 'package' here}} | ||
| internal import InternalLib // expected-note 12 {{module 'InternalLib' imported as 'internal' here}} | ||
| fileprivate import FileprivateLib // expected-note 6 {{module 'FileprivateLib' imported as 'fileprivate' here}} | ||
| private import PrivateLib // expected-note 6 {{module 'PrivateLib' imported as 'private' here}} |
Contributor
Author
There was a problem hiding this comment.
I'm thinking about adding the name of the affected decl to this diagnostic. While the current version works well in the terminal it may be harder to follow in an IDE when a big file is open.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the exportability check to ensure that inlinable code can only refer to public types, so either local public types or public types imported publicly. As a result, we report any decl imported as non-public in inlinable code.
rdar://105902141