Skip to content

[Executors][Distributed] assumeOnLocalDistributedActorExecutor #64271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 16, 2023
Merged

[Executors][Distributed] assumeOnLocalDistributedActorExecutor #64271

merged 1 commit into from
Mar 16, 2023

Conversation

@ktoso
Copy link
Contributor

@ktoso ktoso commented Mar 10, 2023 •
edited
Loading

Adds the assumeOnLocalDistributedActorExecutor from SE-0392

Depends on #64171
Depends on #64237

@ktoso ktoso requested a review from slavapestov as a code owner March 10, 2023 05:32
@ktoso ktoso added concurrency Feature: umbrella label for concurrency language features distributed Feature → concurrency: distributed actor labels Mar 10, 2023
@ktoso ktoso changed the title [Executors][Distributed] custom executors for distributed actor [Executors][Distributed] assumeOnLocalDistributedActorExecutor Mar 10, 2023
@ktoso
Copy link
Contributor Author

ktoso commented Mar 15, 2023

This is unblocked now, just needs a rebase

@ktoso ktoso force-pushed the wip-assert-executor-distributed branch 2 times, most recently from 205ab18 to 7bff917 Compare March 16, 2023 04:15
@ktoso ktoso force-pushed the wip-assert-executor-distributed branch from 7bff917 to 5d2a311 Compare March 16, 2023 04:23
@ktoso
Copy link
Contributor Author

ktoso commented Mar 16, 2023

@swift-ci please smoke test and merge

@swift-ci swift-ci merged commit 8db7d71 into swiftlang:main Mar 16, 2023
@bnbarham
Copy link
Contributor

bnbarham commented Mar 16, 2023

@shahmishal apparently smoke test and merge doesn't check windows results? Distributed/Runtime/distributed_actor_assume_executor.swift failed.

@ktoso ktoso deleted the wip-assert-executor-distributed branch March 16, 2023 22:29
@ktoso
Copy link
Contributor Author

ktoso commented Mar 16, 2023

I thought we started to require windows passing 😕 seems not heh, thanks for the fix in #64439

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@slavapestov slavapestov Awaiting requested review from slavapestov slavapestov is a code owner

Assignees

No one assigned

Labels

concurrency Feature: umbrella label for concurrency language features distributed Feature → concurrency: distributed actor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ktoso @bnbarham @swift-ci