IRGen: correct field counting for distributed actors #64439
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correct the counting between `forEachField` and `getNumFields` to correctly enumerate the synthesized fields. We would previously fail to count the non-root default actor resulting in a mismatch on the stored field counts. Fortunately, we were able to catch this by means of an assertion in the compiler which triggered on Windows. Special thanks to @etcwilde for the help in tracking this down! rdar://106822386
Member
Author
etcwilde
approved these changes
Mar 16, 2023
Member
etcwilde
left a comment
etcwilde
left a comment
There was a problem hiding this comment.
Yeah, this makes more sense than repeating the same condition. Thanks for having a Windows box to pull numbers from.
Member
Author
|
@swift-ci please test |
ktoso
approved these changes
Mar 16, 2023
ktoso
approved these changes
Mar 16, 2023
Member
Author
|
@swift-ci please test macOS platform |
ktoso
added
concurrency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct the counting between
forEachFieldandgetNumFieldsto correctly enumerate the synthesized fields. We would previously fail to count the non-root default actor resulting in a mismatch on the stored field counts. Fortunately, we were able to catch this by means of an assertion in the compiler which triggered on Windows.Special thanks to @etcwilde for the help in tracking this down!
rdar://106822386