-
Notifications
You must be signed in to change notification settings - Fork 10.6k
[Executors][Distributed] custom executors for distributed actor #64237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Executors][Distributed] custom executors for distributed actor #64237
Conversation
c6ca300 to
325d1f7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- All of the synthesis code is pretty much 1:1 same as in an Actor, I'll refactor so we can share that code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leaving this duplicated for now since we might want to change it a little bit actually for distributed -- pending discussion in evolution.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(turns out having it separate was a good idea)
|
@swift-ci please smoke test |
|
I'm very confused how this can be failing on some CI platforms but also work locally on M1 just fine 🤔 There's nothing platform specific in these changes... Trying to figure it out. |
|
Wait a moment... |
|
@swift-ci please smoke test |
|
@swift-ci please smoke test |
325d1f7 to
7f8ffb2
Compare
|
@swift-ci please smoke test |
|
Missed to implement calling the |
a9031f7 to
f46db85
Compare
|
@swift-ci please smoke test |
|
I have discussed the implementation approach with @rjmccall and we agreed on adding the |
28694f6 to
13d2e50
Compare
5aef826 to
349df21
Compare
|
Fixed pending FIXME's and comments. @swift-ci please smoke test and merge // heh, should have merged the green build and did a follow-up PR :-/ |
|
@swift-ci please smoke test |
Distributed actors must also be able to have custom executors.
I'll cleanup the code duplication for the synthesis a little bit, as it is copied from the Actor synthesis right now.
Resolves rdar://84054793