Skip to content

Conversation

@ktoso
Copy link
Contributor

@ktoso ktoso commented Mar 9, 2023

Distributed actors must also be able to have custom executors.

I'll cleanup the code duplication for the synthesis a little bit, as it is copied from the Actor synthesis right now.

Resolves rdar://84054793

@ktoso ktoso requested a review from slavapestov as a code owner March 9, 2023 14:07
@ktoso ktoso force-pushed the wip-custom-executor-distributed-2 branch 2 times, most recently from c6ca300 to 325d1f7 Compare March 9, 2023 14:10
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • All of the synthesis code is pretty much 1:1 same as in an Actor, I'll refactor so we can share that code.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving this duplicated for now since we might want to change it a little bit actually for distributed -- pending discussion in evolution.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(turns out having it separate was a good idea)

@ktoso
Copy link
Contributor Author

ktoso commented Mar 9, 2023

@swift-ci please smoke test

@ktoso ktoso requested review from DougGregor, kavon and rjmccall March 9, 2023 14:11
@ktoso
Copy link
Contributor Author

ktoso commented Mar 10, 2023

I'm very confused how this can be failing on some CI platforms but also work locally on M1 just fine 🤔 There's nothing platform specific in these changes... Trying to figure it out.

@ktoso
Copy link
Contributor Author

ktoso commented Mar 10, 2023

Wait a moment...

Traceback (most recent call last):
  File "/home/build-user/swift/utils/PathSanitizingFileCheck", line 100, in <module>
    exit(main())
  File "/home/build-user/swift/utils/PathSanitizingFileCheck", line 74, in main
    stdin = io.open(sys.stdin.fileno(), 'r', encoding='utf-8', errors='ignore').read()
MemoryError

@ktoso
Copy link
Contributor Author

ktoso commented Mar 10, 2023

@swift-ci please smoke test

@ktoso ktoso added concurrency Feature: umbrella label for concurrency language features distributed Feature → concurrency: distributed actor labels Mar 10, 2023
@ktoso
Copy link
Contributor Author

ktoso commented Mar 13, 2023

@swift-ci please smoke test

@ktoso ktoso force-pushed the wip-custom-executor-distributed-2 branch from 325d1f7 to 7f8ffb2 Compare March 13, 2023 15:20
@ktoso ktoso requested review from hborla and xedin as code owners March 14, 2023 10:49
@ktoso
Copy link
Contributor Author

ktoso commented Mar 14, 2023

@swift-ci please smoke test

@ktoso
Copy link
Contributor Author

ktoso commented Mar 14, 2023

Missed to implement calling the initialize() in non default case; that's simple, will do in the morning

@ktoso ktoso force-pushed the wip-custom-executor-distributed-2 branch from a9031f7 to f46db85 Compare March 15, 2023 02:23
@ktoso
Copy link
Contributor Author

ktoso commented Mar 15, 2023

@swift-ci please smoke test

@ktoso
Copy link
Contributor Author

ktoso commented Mar 15, 2023

I have discussed the implementation approach with @rjmccall and we agreed on adding the NonDefaultDistributedActor piece of data. We may be able to streamline it afterwards; but it effectively adds the same amount of data "chunk" as the DefaultActor bit does to distributed non-default actors.

@ktoso ktoso force-pushed the wip-custom-executor-distributed-2 branch from 28694f6 to 13d2e50 Compare March 15, 2023 10:16
@ktoso ktoso force-pushed the wip-custom-executor-distributed-2 branch from 5aef826 to 349df21 Compare March 15, 2023 10:37
@ktoso
Copy link
Contributor Author

ktoso commented Mar 15, 2023

Fixed pending FIXME's and comments.

@swift-ci please smoke test and merge // heh, should have merged the green build and did a follow-up PR :-/

@ktoso
Copy link
Contributor Author

ktoso commented Mar 15, 2023

@swift-ci please smoke test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

concurrency Feature: umbrella label for concurrency language features distributed Feature → concurrency: distributed actor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants