[Distributed] Bring back Derived id synthesis, as some cases still use it #64452
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktoso
force-pushed
the
wip-distributed-id-synthesis-back
branch
from
70b2d7b to
4ef926e
Compare
Contributor
Author
ktoso
changed the title
Contributor
|
We should test the release build of source compat as well, as that's where the build is failing |
Contributor
|
@swift-ci please test source compatibility |
justice-adams-apple
approved these changes
Mar 17, 2023
Contributor
Author
|
Got it, and it passed -- great! |
Contributor
Author
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Bring back code which was assumed to be dead, but isn't in cross-module cases.
Description:
During #64237 I spotted that we had
// TODO(distributed): make use of this after all, but FORCE it?above thederiveDistributedActor_idand a quick check uncovered that this code isn't hit in our tests and I removed it. The source compatibility suite uncovered that this caused a regression in the distributed cluster build.This removal a day or two ago was incorrect and must be undone.
Turns out, this IS hit but during builds across modules only (!), and we should not remove it.
Risk: Low, this brings back code which was always here and was removed yesterday by a wrong assumption that it was not needed
Testing: