[CodeCompletion] Remove CodeComletionString::getName()
#38446
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`CodeCompletioString::getName()` was used only as the sorting keys in `CodeCompletionContext::sortCompletionResults()` which is effectively deprecated. There's no reason to check them in `swift-ide-test`. Instead, check `printCodeCompletionResultFilterName()` that is actually used for filtering.
|
@swift-ci Please smoke test |
benlangmuir
approved these changes
Jul 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CodeCompletioString::getName()was used only as the sorting keys inCodeCompletionContext::sortCompletionResults()which is effectively deprecated, and it was not good even for sorting because it contained parameter type names. There's no reason to check them inswift-ide-test. Instead, checkprintCodeCompletionResultFilterName()that is actually used for filtering.