Skip to content

[CodeCompletion] Fix a test case after CodeComletionString::getName() obsoletion #38476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 20, 2021

Conversation

rintaro
Copy link
Member

@rintaro rintaro commented Jul 19, 2021

Since 7c24d19 (#38446), sorted result from SourceKit for foo(a: Int) and foo(a: String) is non-deterministic. Update the test case.

rdar://80729544

@rintaro
Copy link
Member Author

rintaro commented Jul 19, 2021

@swift-ci Please test

@rintaro rintaro requested a review from benlangmuir July 19, 2021 17:24
@rintaro rintaro changed the title [CodeCompletion] Fix a test case after 'key.name' change [CodeCompletion] Fix a test case after getName() obsoletion Jul 19, 2021
@rintaro rintaro changed the title [CodeCompletion] Fix a test case after getName() obsoletion [CodeCompletion] Fix a test case after CodeComletionString::getName() obsoletion Jul 19, 2021
@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - f58faeba3a74feb6409956a23ad4e80e65d2fc0a

@rintaro rintaro force-pushed the sourcekit-completion-rdar80729544 branch 2 times, most recently from eb6f850 to beef5ad Compare July 19, 2021 19:59
@rintaro
Copy link
Member Author

rintaro commented Jul 19, 2021

@swift-ci Please test

… obsoletion

Since 7c24d19, sorted result from SourceKit for 'foo(a: Int)' and
'foo(a: String)' is non-deterministic. Update the test case.

rdar://80729544
@rintaro rintaro force-pushed the sourcekit-completion-rdar80729544 branch from beef5ad to 90b3f6e Compare July 19, 2021 21:11
@rintaro
Copy link
Member Author

rintaro commented Jul 19, 2021

@swift-ci Please test

@rintaro rintaro merged commit 63668b0 into swiftlang:main Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants