[CodeCompletion] Annotate override completions #38453
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
1 similar comment
|
@swift-ci Please smoke test |
rintaro
force-pushed
the
ide-completion-overrideannotation-rdarrdar62617558
branch
2 times, most recently
from
94df989 to
e8dc2f5
Compare
rintaro
force-pushed
the
ide-completion-overrideannotation-rdarrdar62617558
branch
from
e8dc2f5 to
6c5b3f2
Compare
rintaro
force-pushed
the
ide-completion-overrideannotation-rdarrdar62617558
branch
from
6c5b3f2 to
fd8156b
Compare
rintaro
force-pushed
the
ide-completion-overrideannotation-rdarrdar62617558
branch
2 times, most recently
from
318ef74 to
c7f1958
Compare
|
@swift-ci Please smoke test |
|
@benlangmuir This is still WIP (need to add test cases, cosmetic changes) but could you take a look and give me some initial feedback? 🙏 |
benlangmuir
reviewed
Aug 9, 2021
rintaro
force-pushed
the
ide-completion-overrideannotation-rdarrdar62617558
branch
from
c7f1958 to
2499c98
Compare
benlangmuir
reviewed
Aug 13, 2021
rintaro
force-pushed
the
ide-completion-overrideannotation-rdarrdar62617558
branch
from
8b914e7 to
0ca9440
Compare
rintaro
force-pushed
the
ide-completion-overrideannotation-rdarrdar62617558
branch
from
0ca9440 to
1ce4f12
Compare
* "description" for override completion is now annotatable * "description" doesn't include attributes and decl introducer, but it includes generic paramters, effects specifiers, result type clause, and generic where clauses * "name" now only include the name and the parameter names * "sourcetext" should be the same rdar://63835352
rintaro
force-pushed
the
ide-completion-overrideannotation-rdarrdar62617558
branch
from
1ce4f12 to
7e7b2c3
Compare
|
@swift-ci Please smoke test |
|
@swift-ci Please test Linux |
rintaro
changed the title
benlangmuir
approved these changes
Sep 2, 2021
rintaro
deleted the
ide-completion-overrideannotation-rdarrdar62617558
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement
CodeCompletionStringPrinterto print override completion item toCodeCompletionResultBuilderwith appropriateChunkKind. Added various groupChunkKindfor differentiatingdescription,name, andsourcetext.rdar://63835352