[IRGen] Check as early as possible for Clang decls we've seen before. #31272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we were only doing this after the fast-path code that handles decls without any executable code. This meant, however, that we were potentially processing these decls multiple times. This is definitely inefficient; it may even be a correctness issue, depending on what amount of checking `HandleTopLevelDecl` does to see if it has processed a particular decl before (which I'm not sure about either way).
gribozavr
approved these changes
Apr 24, 2020
Contributor
|
@swift-ci Please test |
Contributor
|
@swift-ci Please test Windows |
aschwaighofer
pushed a commit
to aschwaighofer/swift
that referenced
this pull request
Sep 10, 2020
…ang-decl [IRGen] Check as early as possible for Clang decls we've seen before.
aschwaighofer
pushed a commit
to aschwaighofer/swift
that referenced
this pull request
Sep 10, 2020
Explanation: LLVM currently asserts on local extern variables in C headers passed to Swift when the definition exists outside that header. Scope: This never worked. Risk: Low. Testing: Regression test added. Reviewed-by: John McCall Original PR: swiftlang#33306 This fix also required the cherry-pick of: swiftlang#31035 and swiftlang#31272 rdar://67951491
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we were only doing this after the fast-path code that handles decls without any executable code. This meant, however, that we were potentially processing these decls multiple times. This is definitely inefficient; it may even be a correctness issue, depending on what amount of checking
HandleTopLevelDecldoes to see if it has processed a particular decl before (which I'm not sure about either way).