Skip to content

[IRGen] Check as early as possible for Clang decls we've seen before. #31272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 24, 2020
Merged

[IRGen] Check as early as possible for Clang decls we've seen before. #31272

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cd7f205
[IRGen] Check as early as possible for Clang decls we've seen before.
martinboehme Apr 24, 2020
0e75f37
Merge branch 'master' into optimize-emit-clang-decl
martinboehme Apr 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions lib/IRGen/GenClangDecl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,10 @@ clang::Decl *getDeclWithExecutableCode(clang::Decl *decl) {
} // end anonymous namespace

void IRGenModule::emitClangDecl(const clang::Decl *decl) {
// Ignore this decl if we've seen it before.
if (!GlobalClangDecls.insert(decl->getCanonicalDecl()).second)
return;

// Fast path for the case where `decl` doesn't contain executable code, so it
// can't reference any other declarations that we would need to emit.
if (getDeclWithExecutableCode(const_cast<clang::Decl *>(decl)) == nullptr) {
Expand All @@ -67,8 +71,6 @@ void IRGenModule::emitClangDecl(const clang::Decl *decl) {
return;
}

if (!GlobalClangDecls.insert(decl->getCanonicalDecl()).second)
return;
SmallVector<const clang::Decl *, 8> stack;
stack.push_back(decl);

Expand Down