[5.3] IRGen: Fix asserting local extern declarations. #33881
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci Please test |
Contributor
Author
|
@swift-ci please nominate |
Contributor
|
Build failed |
tkremenek
approved these changes
Sep 10, 2020
Contributor
|
Build failed |
Member
Bug fix: Emit code for C++ inline function called from another inline function
…ang-decl [IRGen] Check as early as possible for Clang decls we've seen before.
Explanation: LLVM currently asserts on local extern variables in C headers passed to Swift when the definition exists outside that header. Scope: This never worked. Risk: Low. Testing: Regression test added. Reviewed-by: John McCall Original PR: swiftlang#33306 This fix also required the cherry-pick of: swiftlang#31035 and swiftlang#31272 rdar://67951491
Contributor
Author
aschwaighofer
force-pushed
the
irgen_fix_asserting_local_extern_5.3
branch
from
138e3db to
4a4796a
Compare
Contributor
Author
|
@swift-ci Please test |
Contributor
Author
|
@swift-ci Please test windows |
Contributor
|
Build failed |
Contributor
|
Build failed |
AnthonyLatsis
added
swift 5.3
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation:
LLVM currently asserts on local extern variables in C headers passed to
Swift when the definition exists outside that header.
Scope: This never worked.
Risk: Low.
Testing: Regression test added.
Reviewed-by: John McCall
Original PR: #33306
rdar://67951491