Fix compiling test runners for Android by using the full overlay #8018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
finagolfin
requested review from
MaxDesiatov,
bnbarham,
bripeticca,
dschaefer2,
francescomikulis,
jakepetroules,
owenv,
plemarquand,
shawnhyam and
xedin
as code owners
This was referenced Oct 2, 2024
jakepetroules
approved these changes
Oct 2, 2024
|
@swift-ci please test |
dschaefer2
approved these changes
Oct 3, 2024
|
Thanks for the quick review. 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Compiling test runners with
import Bionicworked till July, then the compiler started requiring the largerimport Androidoverlay.Modifications:
import Androidinstead in the test runnerResult:
Compiling the tests for Android works again.
This is part of a larger patch I needed to natively run SwiftPM 6 on Android, but I want to get this into the 6.0 patch releases quickly first because it also breaks cross-compilation of packages' tests to Android.
@bnbarham, can we get this into 6.0.2 next?