[6.0.2] Fix compiling test runners for Android by using the full overlay #8020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakepetroules
approved these changes
Oct 2, 2024
bnbarham
approved these changes
Oct 3, 2024
|
@swift-ci please test |
|
Passed CI, ready for merge. |
Thanks for staying on top of them :) |
|
Thanks for the quick review. 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: Compiling test runners with
import Bionicworked till July, then the compiler started requiring the largerimport Androidoverlay.Scope: Only affects Android
Issue: None
Original PR: #8018
Risk: None
Testing: I built and ran the SwiftPM tests natively on Android with this patch.
Reviewer: @bnbarham
Since this issue broke cross-compiling all packages' tests for Android and presents no risk for other platforms, I'd like to get it in quickly for the next patch release.