[android] don't build test summary harness code for android target #8070
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when building tests for an Android target, SPM creates a test summary harness file as well. This file relies on test outpath that exists on the host machine, but not on the android device on which the test is actually running. Therefore, lets disable test observation for Android.
hyp
requested review from
MaxDesiatov,
bnbarham,
bripeticca,
dschaefer2,
francescomikulis,
jakepetroules,
owenv,
plemarquand,
shawnhyam and
xedin
as code owners
|
@swift-ci please test |
|
What problem are you having exactly? I agree this isn't a necessary feature and the generated file should not be compiled by default on all platforms, but that would require a different fix. If your problem is the one in #8018, I already fixed that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when building tests for an Android target, SPM creates a test summary harness file as well. This file relies on test outpath that exists on the host machine, but not on the android device on which the test is actually running. Therefore, lets disable test observation for Android.
Motivation:
Before this change the test runner code generated by SPM contains SwiftPMXCTestObserver class that refers to the test output path on the host machine, which is incorrect, and doesn't work on an Android device.
Modifications:
Android target no longer supports test summary.
Result:
After this change my tests work as expected on Android device without SwiftPMXCTestObserver issues.