Skip to content

Add a new install page, update the download page, and move release yml files into one file. #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 8, 2023

Conversation

shahmishal
Copy link
Member

@shahmishal shahmishal commented May 23, 2023

  • New install page:
    127 0 0 1_4000_install_ (1)

  • Removed all of the release dir in _data/builds/swift-*-release, and replaced it with one yml file _data/builds/swift_releases.yml

  • Release info is defined in one place _data/builds/swift_releases.yml

  • Updated the download page

TODO: Update the code sign info on download page

@gwynne
Copy link
Contributor

gwynne commented May 23, 2023

Wow, this is great! Are you planning a corresponding PR in swift-docker to update the use of the latest-build.yml files similarly?

@shahmishal
Copy link
Member Author

Wow, this is great! Are you planning a corresponding PR in swift-docker to update the use of the latest-build.yml files similarly?

We are still going to use the latest-build.yml for now

@tomerd
Copy link
Contributor

tomerd commented Jun 20, 2023

@shahmishal per feedback from the core team review, could you update "Apple Platforms" to "macOS" so we can get this merged? We are looking to open a PR against main and this is one missing piece

@shahmishal
Copy link
Member Author

shahmishal commented Jul 15, 2023

@shahmishal per feedback from the core team review, could you update "Apple Platforms" to "macOS" so we can get this merged? We are looking to open a PR against main and this is one missing piece

Currently the download page says "Apple Platforms". Also, the Swift compiler/toolchain provided for "Apple Platforms" contains support for iOS, macOS, tvOS, and watchOS.
https://www.swift.org/download/#using-downloads

Screenshot 2023-07-14 at 5 05 18 PM

@shahmishal
Copy link
Member Author

After thinking more about "where" to install the toolchain compared what it's used for. Going to update the title for "Apple Platforms" to "macOS"

@tomerd
Copy link
Contributor

tomerd commented Aug 1, 2023

@shahmishal is this ready to be merged?

Copy link
Member

@alexandersandberg alexandersandberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some things left to improve here, e.g. renaming "Apple Platforms" to "macOS" as suggested above, and maybe making some styling changes based on discussions in the SWWG meetings.

With that said, I think it would be good to merge this PR as is as it's blocking us from opening the final content improvements PR against the main branch, and then make any final adjustments in that later PR instead.

@shahmishal
Copy link
Member Author

I will clean it up today and get it merged.

@shahmishal
Copy link
Member Author

shahmishal commented Aug 8, 2023

Simplified the page only to include one recommended instruction per platform; additional options are available on different pages to lower confusion.

Screenshot 2023-08-07 at 5 59 29 PM

@shahmishal
Copy link
Member Author

Going to merge this we can handle additional feedback with new PR.

@shahmishal shahmishal merged commit c557d10 into content-improvements Aug 8, 2023
@shahmishal shahmishal deleted the install-page-content-improvements branch August 8, 2023 01:06
kaishin added a commit that referenced this pull request Sep 7, 2023
* Update landing page content (#127)
* First pass at the new Getting Started page (#174)
* Adding Getting Started tutorial for SwiftUI / iOS 16. (#185)
* Add data file with items for "Go Further" section (#184)
* Add cli and library getting started guides (#192)
* Getting started tweaks (#208)
* Rename Markdown files to have an `.md` extension. (#209)
* Fix typo (#214)
* Update getting started page layout (#204)
* Add documentation information to Getting Started (#226)
* Add Vapor Getting Started guide (#229)
* Update content-improvments branch per feedback (#244)
* Tweak SwiftUI tutorial (#240)
* Add TSPL Go Further section and resource thumbnails (#227)
* Improve 'Why Swift?' section on landing page (#252)
* Replace Go Further item for advanced String Under The Hood blog post with item for Structures and Classes chapter in TSPL (#254)
* Update landing page layout (#267)
* Link to developer.apple.com from apple use case (#291)
* Smaller landing page changes on content improvements branch (#294)
* Update Go Further section (#300)
* Update icons and placeholder image (#301)
* Improve description of use cases and getting started guides (#304)
* POC: Feature random code snippet on landing page (#303)
* New “Swift is…” and About page copy (#336)
* Move link to A Swift Tour to the Use Cases section (#329)
* Add consistent download section to start and end of each guide (#351)
* Add a new install page, update the download page, and move release yml files into one file. (#310)
* Update navigation for install page (#355)
* Update cli and library getting started guides (#357)
* Content improvement guide updates (#373)
* Add value and reference types article (#377)
* Add some showcase snippets (#371)
* Resolve issue with Red Hat download links (#379)
* Add Info about Scoop for Windows install page (#382)

---------

Co-authored-by: Alexander Sandberg <[email protected]>
Co-authored-by: Paul Hudson <[email protected]>
Co-authored-by: James Dempsey <[email protected]>
Co-authored-by: tomer doron <[email protected]>
Co-authored-by: Dave Verwer <[email protected]>
Co-authored-by: Tim Condon <[email protected]>
Co-authored-by: Max Desiatov <[email protected]>
Co-authored-by: Mishal Shah <[email protected]>
Co-authored-by: AG <[email protected]>
Co-authored-by: Ted Kremenek <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants