Skip to content

Add TSPL Go Further section and resource thumbnails #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 28, 2023

Conversation

kaishin
Copy link
Member

@kaishin kaishin commented Jan 31, 2023

Motivation:

These changes were discussed during the last workgroup meeting.

Modifications:

  • Added the featured TSPL section, alongside a new flag to make any resource span 2 columns.
  • Added thumbnails and a placeholder image for sections.
  • Changed the hierarchy of border colors to make the content stand out more vs. the chrome.

Result:

Live preview.

Copy link
Member

@alexandersandberg alexandersandberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! I actually like the thumbnails, but it kinda makes me want to add thumbnails to the "Using Swift" tutorials as well as the Go Further section is stealing the attention from them a bit at the moment.

@kaishin
Copy link
Member Author

kaishin commented Jan 31, 2023

Nice job! I actually like the thumbnails, but it kinda makes me want to add thumbnails to the "Using Swift" tutorials as well as the Go Further section is stealing the attention from them a bit at the moment.

That's a good point. I noticed the same as well. Let's explore adding thumbnails for the guides.

Comment on lines 1 to 5
- title: "The Swift Programming Language Book"
description: "The authoritative reference for Swift,
offering a guided tour, a comprehensive guide, and a formal reference of the language."
content_type: book
content_url: https://docs.swift.org/swift-book
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dempseyatgithub This data is placeholder so feel free to comment here and I'll update it. There is probably no need to have a separate PR.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this placeholder @kaishin. Is the template set up to process markdown in the title/description? The title of the book in the description should be in italics.

title: A Swift Tour

description: "The Swift Programming Language , the authoritative reference for Swift, begins with a tour of the language. The tour gives you an introduction to the fundamental features, concepts, and syntax of Swift. The remainder of the book explains each topic in greater detail."

content_url: https://docs.swift.org/swift-book/GuidedTour/GuidedTour.html

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Updated.

Is the template set up to process markdown in the title/description?

It wasn't but I pushed a change that takes care of that.

- title: "Swift Generics"
description: "In Swift, generics are a fundamental way to write abstract code. This video walks through the basics of Swift Generics and introducing generics into your code."
content_type: video
content_url: https://developer.apple.com/videos/play/wwdc2021/10132/
thumbnail_url: #TBD
content_url: https://developer.apple.com/videos/play/wwdc2022/110352/
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dempseyatgithub I updated the URL here in what I assume was a typo, but I am not sure if this is the right video. Please let me know.

@@ -1,24 +1,42 @@

.go-further-list{
.go-further-list {
$grid-breakpoint: 1000px;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using Sass variable here since CSS-native variables don't seem to be supported in media queries.

@kaishin kaishin force-pushed the content-improvements branch from 7f92987 to 761cd8f Compare February 28, 2023 18:31
@kaishin kaishin merged commit cb3e51c into swiftlang:content-improvements Feb 28, 2023
kaishin added a commit that referenced this pull request Sep 7, 2023
* Update landing page content (#127)
* First pass at the new Getting Started page (#174)
* Adding Getting Started tutorial for SwiftUI / iOS 16. (#185)
* Add data file with items for "Go Further" section (#184)
* Add cli and library getting started guides (#192)
* Getting started tweaks (#208)
* Rename Markdown files to have an `.md` extension. (#209)
* Fix typo (#214)
* Update getting started page layout (#204)
* Add documentation information to Getting Started (#226)
* Add Vapor Getting Started guide (#229)
* Update content-improvments branch per feedback (#244)
* Tweak SwiftUI tutorial (#240)
* Add TSPL Go Further section and resource thumbnails (#227)
* Improve 'Why Swift?' section on landing page (#252)
* Replace Go Further item for advanced String Under The Hood blog post with item for Structures and Classes chapter in TSPL (#254)
* Update landing page layout (#267)
* Link to developer.apple.com from apple use case (#291)
* Smaller landing page changes on content improvements branch (#294)
* Update Go Further section (#300)
* Update icons and placeholder image (#301)
* Improve description of use cases and getting started guides (#304)
* POC: Feature random code snippet on landing page (#303)
* New “Swift is…” and About page copy (#336)
* Move link to A Swift Tour to the Use Cases section (#329)
* Add consistent download section to start and end of each guide (#351)
* Add a new install page, update the download page, and move release yml files into one file. (#310)
* Update navigation for install page (#355)
* Update cli and library getting started guides (#357)
* Content improvement guide updates (#373)
* Add value and reference types article (#377)
* Add some showcase snippets (#371)
* Resolve issue with Red Hat download links (#379)
* Add Info about Scoop for Windows install page (#382)

---------

Co-authored-by: Alexander Sandberg <[email protected]>
Co-authored-by: Paul Hudson <[email protected]>
Co-authored-by: James Dempsey <[email protected]>
Co-authored-by: tomer doron <[email protected]>
Co-authored-by: Dave Verwer <[email protected]>
Co-authored-by: Tim Condon <[email protected]>
Co-authored-by: Max Desiatov <[email protected]>
Co-authored-by: Mishal Shah <[email protected]>
Co-authored-by: AG <[email protected]>
Co-authored-by: Ted Kremenek <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants