Revert 'Add missing dependencies (#888)' #891
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The llbuild executable is not a dependency of these two libraries.
|
/cc @neonichu |
neonichu
approved these changes
Sep 16, 2023
|
This will need to be tested on the CI with swiftlang/swift-package-manager#6909 or that has to be merged first. |
|
@jakepetroules, the SwiftPM pull was merged, so this can be tested alone on the CI and merged. |
|
@bnbarham, would you run the CI on this? |
|
@swift-ci please test |
|
Hmm, smoke tests were not triggered for some reason, unsure why. |
|
@swift-ci please smoke test |
|
Ping, ready for merge. |
owenv
approved these changes
Sep 26, 2023
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The llbuild executable is not a dependency of these two libraries.
Note that swiftlang/swift-package-manager#6909 will have to be merged first, else reverting this will break the SwiftPM build.