Add missing dependency declarations to package manifest #950
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes llbuild build with `swift build --explicit-target-dependency-import-check error`
|
@swift-ci Please test |
dmbryson
approved these changes
Nov 6, 2024
|
@swift-ci Please test Windows |
|
@swift-ci Please test Linux |
|
@swift-ci Please smoke test |
|
@swift-ci Please test Windows |
|
@swift-ci Please test |
|
SwiftPM is incorrectly flagging this as a missing dependency since it's unable to parse clang module maps to determine those module names with 100% accuracy. #891 and linked PRs have some context where this change broke builds last time it was made |
owenv
requested changes
Nov 12, 2024
|
Is there an issue tracking this incorrectly flagged issue on the SwiftPM side? |
auto-merge was automatically disabled
November 13, 2024 23:01
Pull request was closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes llbuild build with
swift build --explicit-target-dependency-import-check error.