[5.10] Revert 'Add missing dependencies (#888)' #892
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The llbuild executable is not a dependency of these two libraries.
|
Ping @jakepetroules, would you run the CI on this? The corresponding SwiftPM pull has already been merged to 5.10. |
|
Ping @al45tair, please run the CI on this. |
|
@swift-ci Please test |
|
@owenv, ready for review. |
|
Ping @neonichu, can we get this in? |
|
From my perspective, yes, but I don't want to unilaterally make merge decisions on llbuild. @owenv @jakepetroules does one of you have any opinions about this? |
|
Lgtm, sorry I missed this. |
owenv
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherrypick of #891
Explanation: The llbuild executable is not a dependency of these two libraries.
Scope: Only affects SwiftPM build of this repo
Issue: None
Risk: low, as less code is built after this
Testing: Passed all CI on trunk
Reviewer: @neonichu