Rename EmittedOutput to WorkflowOutput, move to workflow-core. #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This simplifies the API of `WorkflowAction.applyTo`, removes the need for `OutputHolder` in the core tests and `MaybeOutput` in `workflow-runtime`. `EmittedOutput` is left as a deprecated typealias to ease migration. I was initially reluctant to do something like this because I didn't want Workflow to provide yet another generic `Optional` type. I forgot that the testing library was already doing that though, and I think that using a nullable "holder" type is a gross enough API that it won't likely be used outside of the intended uses.
zach-klippenstein
force-pushed
the
zachklipp/unify-outputs
branch
from
a37de62 to
f441c32
Compare
2 tasks
rjrjr
approved these changes
Jun 28, 2020
| fun setOutput(output: O) { | ||
| this.output = output | ||
| isOutputSet = true | ||
| this.output = WorkflowOutput(output) |
zach-klippenstein
added a commit
that referenced
this pull request
Jun 29, 2020
After #49 made outputs nullable, and introduced new `RenderTestResult` methods to handle nullable outputs (`verifyActionState`, `verifyActionOutput`, and `verifyNoActionOutput`), #64 came along and introduced a dedicated type for nullable outputs, `WorkflowOutput`. This type means that we can revert the `RenderTestResult` changes made in #49 and return to the simpler API with only `verifyAction` and `verifyActionResult` methods. This change does exactly that.
zach-klippenstein
added a commit
that referenced
this pull request
Jun 29, 2020
After #49 made outputs nullable, and introduced new `RenderTestResult` methods to handle nullable outputs (`verifyActionState`, `verifyActionOutput`, and `verifyNoActionOutput`), #64 came along and introduced a dedicated type for nullable outputs, `WorkflowOutput`. This type means that we can revert the `RenderTestResult` changes made in #49 and return to the simpler API with only `verifyAction` and `verifyActionResult` methods. This change does exactly that.
zach-klippenstein
added a commit
that referenced
this pull request
Feb 4, 2021
Upgrade Gradle to 6.6.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies the API of
WorkflowAction.applyTo, removes the need forOutputHolderin the core tests andMaybeOutputinworkflow-runtime.EmittedOutputis left as a deprecated typealias to ease migration.I was initially reluctant to do something like this because I didn't want
Workflow to provide yet another generic
Optionaltype. I forgot that thetesting library was already doing that though, and I think that using a
nullable "holder" type is a gross enough API that it won't likely be used
outside of the intended uses.