Skip to content

Emit output before next render pass. #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 29, 2020
Merged

Emit output before next render pass. #68

merged 2 commits into from
Jun 29, 2020

Conversation

@zach-klippenstein
Copy link
Collaborator

@zach-klippenstein zach-klippenstein commented Jun 28, 2020 •
edited
Loading

Two commits:

  1. Add a passing test for existing behavior.
  2. Change behavior and test.

Fixes #54.

Checklist

  • Unit Tests
  • I have made corresponding changes to the documentation

@zach-klippenstein zach-klippenstein added this to the v1.0.0 milestone Jun 28, 2020
rjrjr
rjrjr approved these changes Jun 28, 2020
View reviewed changes
Copy link
Collaborator

@rjrjr rjrjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to merge w/o review of the test, unless you prefer another look.

@zach-klippenstein
Copy link
Collaborator Author

zach-klippenstein commented Jun 28, 2020

Yep, this PR is a draft for a reason 😅

@rjrjr
Copy link
Collaborator

rjrjr commented Jun 28, 2020

Yep, this PR is a draft for a reason 😅

D'oh! Not used to looking for that yet.

@zach-klippenstein zach-klippenstein force-pushed the zachklipp/reorder-runtime-output branch from b198b58 to b084b16 Compare June 28, 2020 20:41
@zach-klippenstein zach-klippenstein requested a review from rjrjr June 28, 2020 20:41
@zach-klippenstein zach-klippenstein marked this pull request as ready for review June 28, 2020 20:41
@zach-klippenstein zach-klippenstein requested a review from a team as a code owner June 28, 2020 20:41
Base automatically changed from zachklipp/unify-outputs to main June 29, 2020 00:36
@zach-klippenstein zach-klippenstein merged commit c49ef58 into main Jun 29, 2020
@zach-klippenstein zach-klippenstein deleted the zachklipp/reorder-runtime-output branch June 29, 2020 01:16
@zach-klippenstein zach-klippenstein mentioned this pull request Jul 28, 2020
Closed
zach-klippenstein added a commit that referenced this pull request Jul 28, 2020
@zach-klippenstein
Revert "Emit output before next render pass."
4363566 
This reverts commit b084b16 from #68 and closes #147.
The change this reverts was related to issue #54.
@zach-klippenstein zach-klippenstein mentioned this pull request Jul 28, 2020
Merged
@steve-the-edwards steve-the-edwards mentioned this pull request Feb 19, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rjrjr rjrjr rjrjr approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v1.0.0-beta.1

Development

Successfully merging this pull request may close these issues.

Root runWorkflowLoop has inconsistent output behavior compared to its WorkflowNode children

3 participants

@zach-klippenstein @rjrjr