Cleanup the RenderTestResult interface after introducing WorkflowOutput. #78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
cc @bencochran |
After #49 made outputs nullable, and introduced new `RenderTestResult` methods to handle nullable outputs (`verifyActionState`, `verifyActionOutput`, and `verifyNoActionOutput`), #64 came along and introduced a dedicated type for nullable outputs, `WorkflowOutput`. This type means that we can revert the `RenderTestResult` changes made in #49 and return to the simpler API with only `verifyAction` and `verifyActionResult` methods. This change does exactly that.
zach-klippenstein
force-pushed
the
zachklipp/cleanup-rendertestresult
branch
from
d59444a to
efe8710
Compare
rjrjr
approved these changes
Jun 29, 2020
zach-klippenstein
added a commit
that referenced
this pull request
Feb 4, 2021
Fix the samples not being full-size.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #49 made outputs nullable, and introduced new
RenderTestResultmethods to handle nullable outputs (
verifyActionState,verifyActionOutput,and
verifyNoActionOutput), #64 came along and introduced a dedicatedtype for nullable outputs,
WorkflowOutput. This type means that we canrevert the
RenderTestResultchanges made in #49 and return to the simplerAPI with only
verifyActionandverifyActionResultmethods. This changedoes exactly that.