Skip to content

Update fork master branch #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4,660 commits into from
Jan 31, 2020
Merged

Update fork master branch #3

merged 4,660 commits into from
Jan 31, 2020

Conversation

skia-flutter-autoroll
Copy link
Owner

No description provided.

skia-flutter-autoroll and others added 30 commits January 8, 2020 17:12
@skia-flutter-autoroll
Roll fuchsia/sdk/core/linux-amd64 from oNKzr... to _gFH2... (#15311)
21e511c 
Roll fuchsia/sdk/core/linux-amd64 from oNKzr... to _gFH2...

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC  on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
@skia-flutter-autoroll
Roll src/third_party/skia f811fc3..04e7781 (7 commits) (#15312)
bb99d80 
https://skia.googlesource.com/skia.git/+log/f811fc331a14..04e77813f8f4

git log f811fc3..04e7781 --date=short --first-parent --format='%ad %ae %s'
2020-01-08 [email protected] Revert "Prevent de-duplication of Housekeeper-PerCommit-BuildTaskDrivers"
2020-01-08 [email protected] [canvaskit] Add webp support
2020-01-08 [email protected] Add debug gpu abandon bots and fix yuv crash.
2020-01-08 [email protected] Reland "GrGLMakeNativeInterface_{iOS,mac,win}: clean up"
2020-01-08 [email protected] add Brian's fiddle as gm/bicubic
2020-01-08 [email protected] Revert "Revert "Extend SkCanvas matrix stack to be 4x4, but with (basically) the same public API.""
2020-01-08 [email protected] Revert "Avoid loop-dependent behavior in GrMemoryPoolBench"

Created with:
  gclient setdep -r src/third_party/skia@04e77813f8f4

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: [email protected]
@mdebbar
Reland "[web] Calculate align offset for each paragraph line (LineMet…
91a37d8 
…rics.left)" (#14537) (#15151)
@jason-simmons
[SkParagraph] Cache the font collection created for use by the Skia t…
bd322a6 
…ext shaper library (#15317)
@fluttergithubbot
add warning message for clipboard api (#15304)
9d8a985
@ferhatb
Enable BackdropFilter for most browsers (#15321)
a669095
@ferhatb
Fix devicepixel ratio reset problem when replaying clip stack (#15327)
74f48cd 
* Fix devicepixel ratio reset problem when replaying clip stack
* Simplify setTransform
@jmagman
Revert "Add a deprecation javadoc note to the old FlutterActivity (#1…
5759a43 
…5156)" (#15331)

This reverts commit 293cd97.
@cbracken
Add missing super.onNewIntent() call (#15328)
5c9e134 
From the onNewIntent docs:

    If you are handling new intents and may be making changes to the
    fragment state, you want to be sure to call through to the
    super-class here first. Otherwise, if your state is saved but the
    activity is not stopped, you could get an onNewIntent() call which
    happens before onResume() and trying to perform fragment operations
    at that point will throw IllegalStateException because the fragment
    manager thinks the state is still saved.
@brandondiamond @cbracken
Add support for on/off switch labels when built on iOS 13. (#12467)
d12f2a6
@skia-flutter-autoroll
Roll src/third_party/skia 04e7781..92ca3ba (15 commits) (#15330)
e6f2dcc 
https://skia.googlesource.com/skia.git/+log/04e77813f8f4..92ca3baba6a5

git log 04e7781..92ca3ba --date=short --first-parent --format='%ad %ae %s'
2020-01-08 [email protected] JIT today's new _imm ops
2020-01-08 [email protected] Hoist calculations up to regenerate
2020-01-08 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2020-01-08 [email protected] skip no-op masks
2020-01-08 [email protected] Move the remainder of GrRenderTargetContext factories.
2020-01-08 [email protected] refactor bit ops
2020-01-08 [email protected] add add/sub/min/max w/ constant ops
2020-01-08 [email protected] Reland "Avoid loop-dependent behavior in GrMemoryPoolBench"
2020-01-08 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2020-01-08 [email protected] clamp to [0,1] before blending with normalized
2020-01-08 [email protected] Expose the Input variable and Child name collections in SkRuntimeEffect
2020-01-08 [email protected] Streamline skvm bilerp.
2020-01-08 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2020-01-08 [email protected] Reland "Move makeDeferredRenderTargetContext calls to factory on RTC."
2020-01-08 [email protected] Add method to delay drawable acquisition from MTKView

Created with:
  gclient setdep -r src/third_party/skia@92ca3baba6a5

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: [email protected]
@chunhtai
Add shell api to set default for windows data (#14002)
7a27e75
@matthew-carroll @xster
Make BackgroundMode public. (#45747) (#14673)
4513205
@cbracken
Revert "Add support for on/off switch labels when built on iOS 13. (#…
23df3e6 
…12467)" (#15370)

Broke a fake implementation of Accessibility features in the framework.
While this change is unlikely to break any users in the wild, this is a
breaking change by the standards set out in our documentation and
should follow the breaking change announcement process. Details can be
found at https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes.

The error in question:

    Missing concrete implementation of 'getter AccessibilityFeatures.onOffSwitchLabels' • packages/flutter_test/test/window_test.dart:252:7 • non_abstract_class_inherits_abstract_member

This reverts commit d12f2a6.
@skia-flutter-autoroll @brianosman
Roll src/third_party/skia 92ca3ba..a92320d (18 commits) (#15375)
090f56e 
https://skia.googlesource.com/skia.git/+log/92ca3baba6a5..a92320d4e6a5

git log 92ca3ba..a92320d --date=short --first-parent --format='%ad %ae %s'
2020-01-09 [email protected] Remove GrPaint::addColorTextureProcessor
2020-01-09 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2020-01-09 [email protected] Fix ByteCodeGenerator's handling of specialized programs
2020-01-09 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2020-01-09 [email protected] Allow implicit conversion from GrSamplerState::Filter to GrSamplerState
2020-01-09 [email protected] Add CachingHint to makeRasterImage, default to kDisallow
2020-01-09 [email protected] add back src-in-gamut tracking
2020-01-09 [email protected] Add first, last and subspan to SkEnumerate
2020-01-09 [email protected] Update go.skia.org/infra in go.mod/go.sum
2020-01-09 [email protected] Remove legacy canvas-matrix impl
2020-01-09 [email protected] Improve handling of anisotropic scaling for stroked rects
2020-01-09 [email protected] add vroundps, impl Op::floor on x86
2020-01-09 [email protected] Optimize concat44 on canvas
2020-01-09 [email protected] add x-macro over SkVM::Ops
2020-01-09 [email protected] [canvaskit] Create an SkImage from a frame of an SkAnimatedImage
2020-01-09 [email protected] Roll ../src 61f03e9a10c0..5d178c93fd5b (411 commits)
2020-01-09 [email protected] Roll third_party/externals/swiftshader 45a4d0f36bd6..77c89ff847b6 (13 commits)
2020-01-09 [email protected] Roll third_party/externals/angle2 db49bc7..c431d59 (7 commits)

Created with:
  gclient setdep -r src/third_party/skia@a92320d4e6a5

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: [email protected]
@GaryQian
Revert "Roll src/third_party/skia 04e7781..92ca3ba (15 commits) (#15330…
7821c8b 
…)" (#15376)

This reverts commit e6f2dcc.
@skia-flutter-autoroll
Roll src/third_party/dart c0ca187..395daaa (84 commits) (#15374)
3a1a3ba 
https://dart.googlesource.com/sdk.git/+log/c0ca187f2699..395daaa3ecfc

git log c0ca187..395daaa --date=short --first-parent --format='%ad %ae %s'
2020-01-09 [email protected] Revert "Remove HInstruction.isControlFlow()"
2020-01-09 [email protected] Upgrade dartdoc to 0.30.0.
2020-01-09 [email protected] Cleaning up NNBD tests and migrations.
2020-01-09 [email protected] Reland of https://dart-review.googlesource.com/c/sdk/+/130134
2020-01-09 [email protected] Sort declarations in trial_migration.dart
2020-01-09 [email protected] EditPlanner: add the ability to comment out code rather than removing it.
2020-01-09 [email protected] Migrator: initial support for extensions; #40023
2020-01-09 [email protected] [cfe] Fix type inference for ?? operator in Null Safety
2020-01-09 [email protected] [infra] Add cfe NNBD builder to the test matrix
2020-01-09 [email protected] [vm/nnbd] Second set of changes for migrating VM patch files for NNBD
2020-01-09 [email protected] Migrator preview: Prevent initial inline request of root; causing 404s
2020-01-09 [email protected] Do not complain about a lone unused private constructor
2020-01-09 [email protected] [infra] Remove script to generate custom try builds on cl-*-try builders
2020-01-09 [email protected] Remove redundant detail from doc comment
2020-01-09 [email protected] [VM] Ignore dart scheme scripts in isolate reload
2020-01-09 [email protected] Create a factory interface for creating EditPlans: EditPlanner.
2020-01-09 [email protected] Change NodeChange.apply to accept a FixAggregator rather than a callback.
2020-01-09 [email protected] Migration: simplify "extract" edit plans by always deferring change computation.
2020-01-09 [email protected] Migration: Teach FixBuilder not to append `?` to `void` type.
2020-01-09 [email protected] Remove HInstruction.isControlFlow()
2020-01-09 [email protected] [dart2js] Handle nullability correctly in UnionTypeMask.locateSingleMember().
2020-01-09 [email protected] [VM/Library] Opt-in all the patch files of core libraries for NNBD
2020-01-09 [email protected] [vm/compiler] Remove PushArgument instructions from IL up to AllocateRegisters
2020-01-09 [email protected] [vm/compiler] Remove PushArguments from AllocateObjectInstr
2020-01-09 [email protected] [vm, gc] Add missing check to begin concurrent marking during large page allocation.
2020-01-09 [email protected] [nnbd_migration] fix flow analysis for function declarations
2020-01-08 [email protected] Fix typo from migrating stream_controller
2020-01-08 [email protected] Extract FunctionExpressionInvocationResolver.
2020-01-08 [email protected] [ dartfuzz ] Temporarily prevent Float32x4.fromInt32x4Bits from being emitted in generated programs.
2020-01-08 [email protected] Prepare to publish analyzer 0.39.4
2020-01-08 [email protected] analysis_server: Make private fields final where possible
2020-01-08 [email protected] Enforce and fix lint prefer_single_quotes
2020-01-08 [email protected] Extract TypePropertyResolver and use in ElementResolver.
2020-01-08 [email protected] Refactor arg list to use conditional elements
2020-01-08 [email protected] Enable null aware lints
2020-01-08 [email protected] fix for avoid_redundant_argument_values
2020-01-08 [email protected] [dartdevc] Ensure `null is Object*` evaluates to true
2020-01-08 [email protected] Add valueRange field to LSP Flutter Outline attributes
2020-01-08 [email protected] [dartdevc] fix nnbd static errors on sdk
2020-01-08 [email protected] [VM/nnbd] Simplify NNBDMode enum class.
2020-01-08 [email protected] linter 0.1.108
2020-01-08 [email protected] Gracefully handle a race condition in code completion (issue 40008)
2020-01-08 [email protected] [VM/runtime] - Remove DART_NO_SNAPSHOT
2020-01-08 [email protected] [observatory] Visualize differences between two heap snapshots.
2020-01-08 [email protected] Inline getType() in TypedLiteralResolver.
2020-01-08 [email protected] Fix a problem where '?.call()' could propagate a non-legacy type.
2020-01-08 [email protected] Remove now unused 'isNullAware' from ElementResolver.
2020-01-08 [email protected] Inline getType() in TypeNameResolver.
2020-01-08 [email protected] [dartdevc] Update extractTypeArguments to handle nullability wrappers
2020-01-08 [email protected] Replace assertElementTypeString with assertType.
2020-01-08 [email protected] Merge some resolution assertions.
2020-01-08 [email protected] Flow analysis: adjust nomenclature to match spec draft.
2020-01-08 [email protected] Sort methods in flow_anlalysis.dart
2020-01-08 [email protected] Remove unnecessary casts to TypeImpl.
2020-01-08 [email protected] Remove deprecated "author" section from _fe_analyzer_shared pubspec.yaml.
2020-01-08 [email protected] [vm/aot/tfa] Type check parameters before joining variable values
2020-01-08 [email protected] Stop using package:expect in _fe_analyzer_shared.
2020-01-08 [email protected] [dart:_internal] Update signature of extractTypeArguments()
2020-01-08 [email protected] [infra] Handle missing boolean fields in get_builder_status
2020-01-08 [email protected] [vm] Populate VM isolate group source data and instruction pointers.
2020-01-08 [email protected] [analyzer,cfe,dart2js] Add skipMap to id-testing
2020-01-08 [email protected] [analyzer,cfe,dart2js] Improve offset of generated library/class/member annotations
2020-01-08 [email protected] [cfe] Make .{thisF,f}unctionType nullability-aware
2020-01-08 [email protected] Revert "Reland "Reland "[infra] Add failing test to test CI systems and approvals workflow"""
2020-01-08 [email protected] [cfe] Report error on required named parameters having default values
2020-01-08 [email protected] [dart2js] Remove ConstantExpression/Constructor/Evaluation
2020-01-08 [email protected] [dart2js] Use CFE constant evaluator for non-required constants
2020-01-08 [email protected] [dart2js] Remove code dependent on non-cfe-constants
2020-01-08 [email protected] Deprecate DartType.name
2020-01-08 [email protected] InterfaceTypeImpl has one constructor.
2020-01-08 [email protected] Resolve with Never and Never? receivers.
2020-01-08 [email protected] [vm, service] Speed up generation and transmission of heap snapshots.
2020-01-08 [email protected] [nnbd_migration] Fix Enum.toString(), the last exception in flutter.
2020-01-08 [email protected] Analyzer: add some deprecation messages.
2020-01-07 [email protected] Fix deferredPrefix.loadLibrary() resolution to check for extra arguments.
2020-01-07 [email protected] Report unused constructors
2020-01-07 [email protected] migrator: Fix HTML-rendered text in navigation and tooltips
2020-01-07 [email protected] Prepare to publish analyzer 0.39.3
2020-01-07 [email protected] Always return a type from getReadType(), possibly dynamic.
2020-01-07 [email protected] [dart2js] Add TYPE_REF<T>().
2020-01-07 [email protected] [dart2js] Represent nullability as its own bit on UnionTypeMasks.
2020-01-07 [email protected] Fix TypeParameterType.== when reloaded elements and recursive bounds.
2020-01-07 [email protected] [dartdevc] Emitting nullability wrappers for generic classes and type parameters.
2020-01-07 [email protected] [vm] Enable multiple entry-points on IA32.

Created with:
  gclient setdep -r src/third_party/dart@395daaa3ecfc

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: [email protected]
@mdebbar @fluttergithubbot
[web] Tests for browser history implementation (#15324)
6162c41
@skia-flutter-autoroll
Roll fuchsia/sdk/core/linux-amd64 from _gFH2... to 75iyW... (#15373)
5272d12 
Roll fuchsia/sdk/core/linux-amd64 from _gFH2... to 75iyW...

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC  on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
@fluttergithubbot
modify test_runner.dart for windows to fix test build errors (#15326)
94c5b9f
@skia-flutter-autoroll
Roll src/third_party/skia 04e7781..67d0f3f (41 commits) (#15377)
f4c7fcd 
https://skia.googlesource.com/skia.git/+log/04e77813f8f4..67d0f3fd725c

git log 04e7781..67d0f3f --date=short --first-parent --format='%ad %ae %s'
2020-01-09 [email protected] Revert "Remove GrPaint::addColorTextureProcessor"
2020-01-09 [email protected] Move GrVkFormatColorTypePairIsValid assert back into GrVkGpu::check_image_info
2020-01-09 [email protected] Add retries to Android compile bot for when GS returns 502s
2020-01-09 [email protected] Speed up get_contour_count in GrTessellator.cpp
2020-01-09 [email protected] Make SubRun accessible for GrAtlasTextOp
2020-01-09 [email protected] Hide MakeFromMTKView behind an availability flag
2020-01-09 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2020-01-09 [email protected] Combine result calculation from both legs of if statement
2020-01-09 [email protected] Remove GrPaint::addColorTextureProcessor
2020-01-09 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2020-01-09 [email protected] Fix ByteCodeGenerator's handling of specialized programs
2020-01-09 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2020-01-09 [email protected] Allow implicit conversion from GrSamplerState::Filter to GrSamplerState
2020-01-09 [email protected] Add CachingHint to makeRasterImage, default to kDisallow
2020-01-09 [email protected] add back src-in-gamut tracking
2020-01-09 [email protected] Add first, last and subspan to SkEnumerate
2020-01-09 [email protected] Update go.skia.org/infra in go.mod/go.sum
2020-01-09 [email protected] Remove legacy canvas-matrix impl
2020-01-09 [email protected] Improve handling of anisotropic scaling for stroked rects
2020-01-09 [email protected] add vroundps, impl Op::floor on x86
2020-01-09 [email protected] Optimize concat44 on canvas
2020-01-09 [email protected] add x-macro over SkVM::Ops
2020-01-09 [email protected] [canvaskit] Create an SkImage from a frame of an SkAnimatedImage
2020-01-09 [email protected] Roll ../src 61f03e9a10c0..5d178c93fd5b (411 commits)
2020-01-09 [email protected] Roll third_party/externals/swiftshader 45a4d0f36bd6..77c89ff847b6 (13 commits)
2020-01-09 [email protected] Roll third_party/externals/angle2 db49bc7..c431d59 (7 commits)
2020-01-08 [email protected] JIT today's new _imm ops
2020-01-08 [email protected] Hoist calculations up to regenerate
2020-01-08 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2020-01-08 [email protected] skip no-op masks
2020-01-08 [email protected] Move the remainder of GrRenderTargetContext factories.
2020-01-08 [email protected] refactor bit ops
2020-01-08 [email protected] add add/sub/min/max w/ constant ops
2020-01-08 [email protected] Reland "Avoid loop-dependent behavior in GrMemoryPoolBench"
2020-01-08 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2020-01-08 [email protected] clamp to [0,1] before blending with normalized
2020-01-08 [email protected] Expose the Input variable and Child name collections in SkRuntimeEffect
2020-01-08 [email protected] Streamline skvm bilerp.
2020-01-08 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2020-01-08 [email protected] Reland "Move makeDeferredRenderTargetContext calls to factory on RTC."
2020-01-08 [email protected] Add method to delay drawable acquisition from MTKView

Created with:
  gclient setdep -r src/third_party/skia@67d0f3fd725c

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: [email protected]
@miguelfrde @gaaclarke
[fuchsia] Add diagnostics directory to the remote dirs and ensure ent…
b98e299 
…ry exists (#15258)

This reverts commit 4312d37.

Once https://fuchsia-review.googlesource.com/c/topaz/+/351729 lands, the
diagnostics directory will be present, this would be safe to do and the
roller won't be blocked again.
@zhongwuzw @fluttergithubbot
Fixes leak of url in FlutterObservatoryPublisher (#14822)
7ef88f8
@sjindel-google
Re-land "Use ELF for Dart AOT snapshots on Fuchsia. #13896" (#15360)
343d9f2 
The bug in the original CL was that we were not running replace_as_executable in OpenVmo if the namespace was not provided.

This was a divergence in behavior for MappedResource::LoadFromNamespace compared to the current implementation.
@skia-flutter-autoroll @brianosman
Roll src/third_party/skia 67d0f3f..3723fb7 (25 commits) (#15466)
3d37d39 
https://skia.googlesource.com/skia.git/+log/67d0f3fd725c..3723fb7e85bb

git log 67d0f3f..3723fb7 --date=short --first-parent --format='%ad %ae %s'
2020-01-10 [email protected] Revert "forward concat44 in nway canvas"
2020-01-10 [email protected] Fix mac TSAN build
2020-01-10 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2020-01-10 [email protected] Simplify text op vertex generation loop
2020-01-10 [email protected] Enable transfer from texture to buffer on ANGLE.
2020-01-10 [email protected] Revert "Reland "Add vis of android device clip restriction, fix regular clip vis on gpu""
2020-01-10 [email protected] Reland "Add vis of android device clip restriction, fix regular clip vis on gpu"
2020-01-10 [email protected] Revert "Add vis of android device clip restriction, fix regular clip vis on gpu"
2020-01-10 [email protected] Revert "Fix san error by initializing new bool in debugcanvas"
2020-01-10 [email protected] forward concat44 in nway canvas
2020-01-10 [email protected] [canvaskit] Roll to 0.11.0
2020-01-10 [email protected] Fix san error by initializing new bool in debugcanvas
2020-01-10 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2020-01-10 [email protected] height_override without a multiplier
2020-01-10 [email protected] tools/git-sync-deps works with either python
2020-01-10 [email protected] SkRuntimeEffect: Fix 'in' variables in CPU backend
2020-01-10 [email protected] Add vis of android device clip restriction, fix regular clip vis on gpu
2020-01-10 [email protected] Ellipsis attached to cluster, not word
2020-01-10 [email protected] Revert "new virtuals for canvas ctm"
2020-01-10 [email protected] new virtuals for canvas ctm
2020-01-10 [email protected] Roll ../src 5d178c93fd5b..e8ce929aea0d (425 commits)
2020-01-10 [email protected] Roll third_party/externals/angle2 c431d59..12ce8f6 (8 commits)
2020-01-10 [email protected] Roll third_party/externals/swiftshader 77c89ff847b6..110236f3ce70 (5 commits)
2020-01-09 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2020-01-09 [email protected] remove cruft bools from canvas

Created with:
  gclient setdep -r src/third_party/skia@3723fb7e85bb

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: [email protected]
@skia-flutter-autoroll
Roll src/third_party/dart 395daaa..b3457c8 (66 commits) (#15485)
2bd4aff 
https://dart.googlesource.com/sdk.git/+log/395daaa3ecfc..b3457c8cc2c1

git log 395daaa..b3457c8 --date=short --first-parent --format='%ad %ae %s'
2020-01-11 [email protected] [dart2js] Fork the RTI subtyping algorithm into legacy and NNBD variants.
2020-01-11 [email protected] [VM//nnbd] Update code generation of 'is instance of' for NNBD.
2020-01-11 [email protected] (dart2js) initialize the receiver type to its static type during inference
2020-01-11 [email protected] (dart2js) remove unnecessary uses of receiverMask
2020-01-11 [email protected] (dart2js) rename typeOfSend, delete unused typeOfGetter
2020-01-10 [email protected] [vm, service] Fix broken references to dual-mapped Instructions in heap snapshots.
2020-01-10 [email protected] quickfix for hash_and_equals
2020-01-10 [email protected] The invoked type cannot be InterfaceType at this point.
2020-01-10 [email protected] Use implementation from InvocationInferenceHelper in MethodInvocationResolver.
2020-01-10 [email protected] [ dartfuzz ] Disable operator / for  Float64x2 and Float32x4
2020-01-10 [email protected] Use analyzer's Packages for GnWorkspace.
2020-01-10 [email protected] Move FunctionExpressionInvocation inference to InvocationInferenceHelper.
2020-01-10 [email protected] Split EditPlan into a base and derived class.
2020-01-10 [email protected] Show subdirectories in test migration progress report.
2020-01-10 [email protected] Sets the loading path for tzdata
2020-01-10 [email protected] Provide packages map to PackageBuildWorkspace.
2020-01-10 [email protected] Added note about memory management of passed in strings to Dart_SetVMFlags.
2020-01-10 [email protected] Updated docstring for Dart_IsVMFlagSet.
2020-01-10 [email protected] [vm, gc] Sweep non-executable large pages concurrently.
2020-01-10 [email protected] Make AtomicEdit concrete and remove subclasses
2020-01-10 [email protected] Migration: annotate API tests that assume dead code is commented out.
2020-01-10 [email protected] [nnbd_migration] Make list constructor nullable if specified length
2020-01-10 [email protected] [dart2js] Remove redundant (incorrect) assert from evalTypeVariable.
2020-01-10 [email protected] remove unused local
2020-01-10 [email protected] Migration: move finalize method into EditPlanner.
2020-01-10 [email protected] remove --bazel-mappings support since it is no longer used
2020-01-10 [email protected] [runtime/vm] ARM64: Use shared stubs for BoxInt64Instr.
2020-01-10 [email protected] [vm/compiler] Fix Mint allocation stub runtime entry and test.
2020-01-10 [email protected] [vm/compiler] ARM64: Improve compare and branch with zero.
2020-01-10 [email protected] fix override change edit for super operators
2020-01-10 [email protected] Remove unused private ForStatementImpl constructor.
2020-01-10 [email protected] [dartdevc,nnbd] fix static async errors
2020-01-10 [email protected] Separate inference with and without type arguments in FunctionExpressionInvocationResolver.
2020-01-10 [email protected] [dartdevc,nnbd] restore bound on JS helper
2020-01-10 [email protected] [dart:async] Cleanup workaround in NNBD fork
2020-01-10 [email protected] [http] cleanups in sdk/sdk_nnbd
2020-01-10 [email protected] stop proposing `new`
2020-01-10 [email protected] [cfe] Report errors on missing required named parameters at call sites
2020-01-10 [email protected] [vm/compiler] Clean up ELF creation code.
2020-01-10 [email protected] [analyzer,cfe,dart2js] An indices to annotations preserve original order in id_generation
2020-01-10 [email protected] [analyzer,cfe,dart2js] Use id_generation to show annotation diff
2020-01-10 [email protected] Adds Dart embedder API for creating 'vm-service' isolate when Dart VM is running in AOT mode.
2020-01-10 [email protected] [parser] Fix 'late' used as 'var'
2020-01-10 [email protected] [co19] Roll co19 to 6d84d8db719f2076e0c2bbc41db9297e803ab445
2020-01-10 [email protected] [parser] bang before type arguments
2020-01-10 [email protected] [cfe] Synthesize null initializer for required named parameters
2020-01-10 [email protected] Link from CONTRIBUTING to the code of conduct.
2020-01-10 [email protected] [dart2js] Fix over-eager NullCheck removal
2020-01-10 [email protected] Ensure native methods default to have all side-effects
2020-01-10 [email protected] Migrator: edge between extension 'on' type and invocation targets; #40023
2020-01-10 [email protected] [dart2js] Implement new subtype algorithm structure for DartTypes.
2020-01-10 [email protected] [dart2js] New RTI: Use new algorithm structure for runtime subtype checks.
2020-01-10 [email protected] Cleanup- remove the Dart Editor directories from the .gitignore file
2020-01-10 [email protected] [vm/gardening] Fix service/isolate_lifecycle_test.
2020-01-10 [email protected] [dartdevc] regression test for dart:* nnbd static errors on bots
2020-01-09 [email protected] [dart2js] nnbd: Implement NullCheck
2020-01-09 [email protected] Issue 37122. Fix for downwards inference for FunctionExpressionInvocation.
2020-01-09 [email protected] Issue 40033. Fix for 'bool' context type for '!' prefix expression.
2020-01-09 [email protected] Migrate lib_2/async to NNBD.
2020-01-09 [email protected] Issue 37122. Fix inference for FunctionExpressionInvocation.
2020-01-09 [email protected] Remove isKernel argment tracking
2020-01-09 [email protected] Extract PrefixExpressionResolver.
2020-01-09 [email protected] First steps in cleaning up FunctionExpressionInvocationResolver.
2020-01-09 [email protected] [infra] Fix cfe NNBD builder
2020-01-09 [email protected] Migration: begin integrating FixBuilder.
2020-01-09 [email protected] [ dartfuzz ] Properly filter Float32x4.fromInt32x4Bits from being emitted in programs generated by DartFuzz

Created with:
  gclient setdep -r src/third_party/dart@b3457c8cc2c1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: [email protected]
Support Clipboard.getData and Clipboard.setData for Flutter for web (#…
88935ca 
…15455)

* copy/paste solution for chrome. copy solution for firefox. using clipboardAPI.

* addressing PR comments

* update licences file
@skia-flutter-autoroll
Roll src/third_party/skia 3723fb7..0a1923e (6 commits) (#15500)
d45f1c1 
https://skia.googlesource.com/skia.git/+log/3723fb7e85bb..0a1923e50752

git log 3723fb7..0a1923e --date=short --first-parent --format='%ad %ae %s'
2020-01-11 [email protected] Disable QCOM_tiled_rendering while we wait for test devices
2020-01-11 [email protected] Override didTranslate, and add virtual for didScale
2020-01-11 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2020-01-10 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2020-01-10 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2020-01-10 [email protected] Revert "Revert "forward concat44 in nway canvas""

Created with:
  gclient setdep -r src/third_party/skia@0a1923e50752

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: [email protected]
@skia-flutter-autoroll
Roll src/third_party/dart b3457c8..32ce9c7 (7 commits) (#15504)
cf454e4 
https://dart.googlesource.com/sdk.git/+log/b3457c8cc2c1..32ce9c7872e2

git log b3457c8..32ce9c7 --date=short --first-parent --format='%ad %ae %s'
2020-01-11 [email protected] Enable prefer_collection_literals in three packages
2020-01-11 [email protected] Hook up the fix for use_function_type_syntax_for_parameters
2020-01-11 [email protected] Add a fix for prefer_iterable_whereType
2020-01-11 [email protected] Stop passing ContextBuilder to Workspace(s).
2020-01-11 [email protected] Use ElementTypeProvider in MethodInvocationResolver.
2020-01-11 [email protected] Extract BinaryExpressionResolver.
2020-01-11 [email protected] Issue 40062. Restore check for extededType subtype.

Created with:
  gclient setdep -r src/third_party/dart@32ce9c7872e2

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: [email protected]
@skia-flutter-autoroll
Roll fuchsia/sdk/core/linux-amd64 from 75iyW... to Xh8_9... (#15506)
73d2fb3 
Roll fuchsia/sdk/core/linux-amd64 from 75iyW... to Xh8_9...

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC  on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
cbracken and others added 22 commits January 29, 2020 17:59
@cbracken
Correct the Fuchsia licenses golden file (#16215)
b98eadc 
Looks like this was triggered by the recent tonic deletion.

Related commits:
* Move tonic into //flutter/third_party. #15895
* Remove tonic/platform. #16062

This is preventing the Dart roller from rolling.
@chinmaygarde
Remove buggy test to check if tasks can be posted on all native threa…
5c79a2d 
…ds recursively from the emebdder. (#16214)

This was never thread safe to shutdown of the concurrent message loop.
@skia-flutter-autoroll
Roll fuchsia/sdk/core/mac-amd64 from c3sk5... to MK0YU... (#16221)
91c8a70 
Roll fuchsia/sdk/core/mac-amd64 from c3sk5... to MK0YU...

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC  on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
@chinmaygarde
Make output of run_tests.py easier to understand. (#16229)
fc1936f 
* The outputs of all commands are not printed and not just commands that fail.
* The stdout and stderr are now printed in order.
* Clear dividers mark logs from specific subprocesses or errors.
* The test whose run failed should now be exactly on top of the error message and code.
@skia-flutter-autoroll
Roll src/third_party/skia 24ed75d..25bcd6a (5 commits) (#16234)
c971b46 
https://skia.googlesource.com/skia.git/+log/24ed75db12ba..25bcd6a6215e

git log 24ed75d..25bcd6a --date=short --first-parent --format='%ad %ae %s'
2020-01-30 [email protected] Roll ../src 243744c215b7..fbfe7df1b1d4 (481 commits)
2020-01-30 [email protected] Roll third_party/externals/swiftshader 6c3dc3581eaf..430def835f9f (7 commits)
2020-01-30 [email protected] Roll third_party/externals/angle2 2bc9cc1..ee07cb3 (18 commits)
2020-01-30 [email protected] Add a stencil/tessellation hybrid mode for path rendering
2020-01-30 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).

Created with:
  gclient setdep -r src/third_party/skia@25bcd6a6215e

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: [email protected]
@skia-flutter-autoroll
Roll src/third_party/skia 25bcd6a..8f44c35 (2 commits) (#16243)
f6526c0 
https://skia.googlesource.com/skia.git/+log/25bcd6a6215e..8f44c3504ca6

git log 25bcd6a..8f44c35 --date=short --first-parent --format='%ad %ae %s'
2020-01-30 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2020-01-30 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).

Created with:
  gclient setdep -r src/third_party/skia@8f44c3504ca6

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: [email protected]
@skia-flutter-autoroll
Roll fuchsia/sdk/core/mac-amd64 from MK0YU... to yissX... (#16250)
2613f92 
Roll fuchsia/sdk/core/mac-amd64 from MK0YU... to yissX...

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC  on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
@skia-flutter-autoroll
Roll src/third_party/skia 8f44c35..d1be5d6 (4 commits) (#16251)
74d07b5 
https://skia.googlesource.com/skia.git/+log/8f44c3504ca6..d1be5d64f8a7

git log 8f44c35..d1be5d6 --date=short --first-parent --format='%ad %ae %s'
2020-01-30 [email protected] Fix skshaper in component builds
2020-01-30 [email protected] finish up 2pt conicals
2020-01-30 [email protected] [fuchsia] Replace system-temp with isolated-temp.
2020-01-30 [email protected] [infra] Update go.sum

Created with:
  gclient setdep -r src/third_party/skia@d1be5d64f8a7

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: [email protected]
@skia-flutter-autoroll
Roll fuchsia/sdk/core/linux-amd64 from -mGIA... to 93K0d... (#16257)
48eadbb
@mdebbar
[web] Correct getPositionForOffset for multi-line paragraphs (#16206)
4ac82f6
@skia-flutter-autoroll
Roll src/third_party/skia d1be5d6..36c0521 (13 commits) (#16260)
d9722a8 
https://skia.googlesource.com/skia.git/+log/d1be5d64f8a7..36c0521d57de

git log d1be5d6..36c0521 --date=short --first-parent --format='%ad %ae %s'
2020-01-30 [email protected] Update Go Deps
2020-01-30 [email protected] Change fidl tables from cpp to c.
2020-01-30 [email protected] Add compressed backend textures to Metal (take 2)
2020-01-30 [email protected] Fix placeholders in cache
2020-01-30 [email protected] Dead code
2020-01-30 [email protected] Update Skia milestone to 82
2020-01-30 [email protected] decs/examples: Support more fiddle types: offscreen, srgb
2020-01-30 [email protected] Revert "Fix skshaper in component builds"
2020-01-30 [email protected] Revert "Use separate SKSHAPER_DLL define to activate shared library logic"
2020-01-30 [email protected] [skottie] Cleanup: convert remaining effects to new adapter pattern
2020-01-30 [email protected] Use separate SKSHAPER_DLL define to activate shared library logic
2020-01-30 [email protected] Turn off failure comments from G3 bot
2020-01-30 [email protected] Avoid using kClamp domain in GrMatrixConvolutionEffect::MakeGaussian.

Created with:
  gclient setdep -r src/third_party/skia@36c0521d57de

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: [email protected]
@skia-flutter-autoroll
Roll src/third_party/dart fc3af73..162d6c5 (209 commits) (#16261)
e520920 
https://dart.googlesource.com/sdk.git/+log/fc3af737c759..162d6c5634a0

git log fc3af73..162d6c5 --date=short --first-parent --format='%ad %ae %s'
2020-01-30 [email protected] Revert "[vm] Add support for real unboxed floating point fields in AOT"
2020-01-30 [email protected] [vm, gc] Base the growth policy on usage instead of capacity.
2020-01-30 [email protected] require type for dynamic var decl splits
2020-01-30 [email protected] `call()` suggestions for FunctionTypes
2020-01-30 [email protected] NNBD preview: properly render deleted regions
2020-01-30 [email protected] [dart2js] Fork backend subtyping into legacy and null-safe variants.
2020-01-30 [email protected] Use 'enum' and 'mixin' with undefined getters, methods, operators, setters
2020-01-30 [email protected] remove unneeded `<Widget>` assist/fix annotations
2020-01-30 [email protected] [vm/nnbd] Disable usage of specialized type testing stubs for NonNullable/NNBD types
2020-01-30 [email protected] [vm/nnbd] Draft support for TypeRefs in CheckInstantiatedNullability
2020-01-30 [email protected] [nnbd] Migrate dart:io to NNBD.
2020-01-30 [email protected] Implement FantasyRepo.
2020-01-30 [email protected] Add return types to more tests in analysis_server
2020-01-30 [email protected] [cfe] Handle parameter type inference for mixed inheritance
2020-01-30 [email protected] [vm] Add support for real unboxed floating point fields in AOT
2020-01-30 [email protected] [cfe] Support nnbd platform without experiment enabled
2020-01-30 [email protected] [cfe] Demote inferred declaration types
2020-01-30 [email protected] [vm] Add VM and isolate instructions start to DumpStackTrace.
2020-01-30 [email protected] NNBD Preview: Fix region detail links to _not_ be POST links
2020-01-30 [email protected] Migration: Fix toFinalType for top bounds.
2020-01-30 [email protected] Use Never and Object? in NNBD bottom / top.
2020-01-30 [email protected] [VM/tests] Second step of porting dart:cli tests for NNBD
2020-01-30 [email protected] Revert "Implementation of evaluation to JS in frontend server"
2020-01-30 [email protected] Reuse checkGetter() in checkExtension().
2020-01-30 [email protected] [vm, service] Add a test to exercise all timeline recorders.
2020-01-30 [email protected] Implementation of evaluation to JS in frontend server
2020-01-30 [email protected] Migration: Add a type parameter to NodeChange.
2020-01-30 [email protected] [VM/tests] - First step to migrate dart:cli tests for NNBD.
2020-01-30 [email protected] NNBD preview: Fix test for generic function types; typedefs still not fixed
2020-01-29 [email protected] [vm/nnbd] Fix nullability and bounds of type parameters
2020-01-29 [email protected] Handle invalid overrides in template and src dart files
2020-01-29 [email protected] Move changes to src .dart files to nnbd_src
2020-01-29 [email protected] Fork dom src files to nnbd version
2020-01-29 [email protected] Add $#NAME syntax to emitter to allow subtemplates
2020-01-29 [email protected] [dartdevc] Apply more lints from pedantic v1.9.0 and cleanup violations
2020-01-29 [email protected] Clean up GetterSetterTypesVerifier.
2020-01-29 [email protected] [dart2js] Use HInvokeExternal for native calls
2020-01-29 [email protected] Revert "[i18n] Replaces fuchsia.deprecatedtimezone"
2020-01-29 [email protected] Implement NullShortableExpressionImpl in MethodInvocationImpl.
2020-01-29 [email protected] Add return types to more methods in analysis_server
2020-01-29 [email protected] [nnbd_migration] Handle downcast from FutureOr<T> to T.
2020-01-29 [email protected] [nnbd_migration] Handle LUB(Never, C<T>).
2020-01-29 [email protected] Move the parallelization restriction into SubprocessLauncher.
2020-01-29 [email protected] Migration: add explicit types to variable declarations when needed.
2020-01-29 [email protected] Migration: Add offsets to more inferred type nodes.
2020-01-29 [email protected] Migration: Rework FixAggregator to reduce order dependencies.
2020-01-29 [email protected] Migration: simplify edit plans for changing `?.` into `.`.
2020-01-29 [email protected] Migration: Make sure that /*!*/ hints and already-migrated nullabilities can't be overridden.
2020-01-29 [email protected] Migration: remove the "propagation step" part of the instrumentation interface.
2020-01-29 [email protected] [nnbd_migration] Fix usages of migrated typedefs
2020-01-29 [email protected] Issue 39976. Treat UnknownInferredType as top.
2020-01-29 [email protected] Issue 40333. Verify types of static getters / setters.
2020-01-29 [email protected] Completion metrics cleanup for FieldFormalParameters.
2020-01-29 [email protected] In completion_metrics.dart, skip files that have analysis errors
2020-01-29 [email protected] [test] Remove redundant gen_snapshot passing in crossword builder
2020-01-29 [email protected] [vm/ffi] Split FFI tests in NNBD and legacy
2020-01-29 [email protected] [CFE] Fix expression compilation with extensions
2020-01-29 [email protected] [infra] Fix test runner to correctly parse android adb output and fix test to always expect compile-time error
2020-01-29 [email protected] [vm] Avoid inlining dynamic calls for simd operations
2020-01-29 [email protected] [vm/concurrency] Add locking for any access to [FixedCache].
2020-01-29 [email protected] [vm/async] Ensure --lazy-async-stacks also works inside custom zones with error handlers
2020-01-29 [email protected] Don't include library directives in the completion metrics computations.
2020-01-29 [email protected] [dartdevc] Apply always_declare_return_types lint and cleanup violations
2020-01-29 [email protected] Update dartdevc_nnbd_sdk_error_golden.txt after analyzer error code changes.
2020-01-29 [email protected] Convert to legacy members of Object and constructor elements.
2020-01-29 [email protected] [vm/isolates] Disallow sending of function types.
2020-01-29 [email protected] Update AnalysisDriverResolutionTest for compatibility with unforked SDK.
2020-01-29 [email protected] Issue 40333. Extract GetterSetterTypesVerifier, report GETTER_NOT_SUBTYPE_SETTER_TYPES for NNBD.
2020-01-29 [email protected] [dart2js] SSA: Avoid emitting generate-at-use twice
2020-01-29 [email protected] Changing the dart:html generator scripts to generate null-safe/nnbd code
2020-01-29 [email protected] Revert "[vm] Initialize large typed arrays only once."
2020-01-28 [email protected] [http] fix hanging when parser failed to parser body of response/request
2020-01-28 [email protected] [vmservice] allow fallback on port bind failure
2020-01-28 [email protected] Add the first Kernel check for invalid JS interop
2020-01-28 [email protected] [infra] Reduce the number of results in the pubsub messages
2020-01-28 [email protected] [vm] Initialize large typed arrays only once.
2020-01-28 [email protected] Begin adding return types in analysis_server
2020-01-28 [email protected] Support for searching references to imports when opt-in from opt-out.
2020-01-28 [email protected] Convert loadLibrary() to legacy when opt-in from opt-out.
2020-01-28 [email protected] Do not opt-in to NNBD when building application snapshots for kernel service and other tools like dartjs, dart analyzer etc. We should enable this only when all the tools are ready to opt-in.
2020-01-28 [email protected] completion_metrics.dart change, don't expect completions when the completed token would be a dynamic type.
2020-01-28 [email protected] [vm/aot/tfa] Infer non-nullability of receiver after calls
2020-01-28 [email protected] Move tests for MISMATCHED_GETTER_AND_SETTER_TYPES.
2020-01-28 [email protected] Add ports of the tables in steamroll_ecosystem.sh.
2020-01-28 [email protected] Add a new counter in completion_metrics.dart to count and report the number of each token that was a miss.
2020-01-28 [email protected] bump to linter 0.1.110
2020-01-28 [email protected] completion_metrics.dart improvement with named arguments in method invocations.
2020-01-28 [email protected] Assert that allowInterop is used with constructors
2020-01-28 [email protected] [vm] Set non_nullable_flag() to true
2020-01-28 [email protected] Enable avoid_return_types_on_setters in analysis_server
2020-01-28 [email protected] [test_runner] QEMU named configurations
2020-01-28 [email protected] [test_runner] Support for arm32 VM in AOT mode on x64 via QEMU
2020-01-28 [email protected] [test] format test_matrix.json
2020-01-28 [email protected] [vm] Add checks to parameters of math functions before inlining
2020-01-28 [email protected] [CFE] Don't add newly-converted DillLibraryBuilders to list of needed dill libraries
2020-01-28 [email protected] Migration: consider edges introduced by contravariant assignment to be uncheckable.
2020-01-28 [email protected] Migartion: consider edges introduced by parameter overrides to be uncheckable.
2020-01-28 [email protected] Migration: allow a node to become nullable after being marked non-nullable.
2020-01-28 [email protected] Separate graph propagation state and results out to their own class.
2020-01-28 [email protected] Migration: change NullabilityGraph._debugDump output to graphviz format.
2020-01-28 [email protected] Migration: improve toString representation of some inferred type nodes.
2020-01-28 [email protected] Migration: fix warning in edge_builder.dart.
2020-01-28 [email protected] Sort methods in edge_builder_test.dart and migration_visitor_test_base.dart.
2020-01-28 [email protected] [cfe] Special case inference of Object.== parameter in legacy mode
2020-01-28 [email protected] [cfe] Update assert to handle extension reexport
2020-01-28 [email protected] Analyzer: Don't do recursive flattening of FutureOr in await.
2020-01-28 [email protected] [co19] Roll co19 to 5a3388d1f79cc3c61f9cdc1b3eaaa405bd62c882
2020-01-28 [email protected] [CFE] Reproduction and workaround for crash when computing variance
2020-01-28 [email protected] [CFE] [Incremental compiler] Convert all SourceLibraryBuilders to DillLibraryBuilders
2020-01-28 [email protected] [test_runner] Support for arm32 VM in JIT mode on x64 via QEMU
2020-01-28 [email protected] Introduce and use a new class to compute the mean reciprocal rank after a run of the code completion metrics execution.
2020-01-28 [email protected] [vm, docs] Describe which VM service features are available in which VM modes.
2020-01-27 [email protected] [vm, gc] Use the compactor for the GC of last resort.
2020-01-27 [email protected] [nnbd_migration] union resolved typedef nodes with inferred ones
2020-01-27 [email protected] Initial test_all.dart, the dart bots test all the files ending in "_test.dart", this file allows developers to easily run all the tests themselves.
2020-01-27 [email protected] Move MultiFutureTracker and SubprocessLauncher into utilities.
2020-01-27 [email protected] [vm/aot/tfa] Infer more information from conditions in TFA
2020-01-27 [email protected] Boilerplate and basic flow for `buildFantasyLand`.
2020-01-27 [email protected] [VM/libraries] Fix final set of warnings in dart:core and dart:typed_data
2020-01-27 [email protected] Move dartdev command tests under a new command directory and add an initial format_test.dart
2020-01-27 [email protected] Reapply "[vm, gc] Sweep non-executable large pages concurrently."
2020-01-27 [email protected] Cleanup and refactoring in completion_metrics.dart
2020-01-27 [email protected] Fix more windows tests in migration tool
2020-01-27 [email protected] [vm] Add nullability variations for snapshot singletons
2020-01-27 [email protected] Issue 40221. NNBD_TOP_MERGE super-interfaces when checking for implementing the same generic class more than once.
2020-01-27 [email protected] Fix Windows analyzer tests.
2020-01-27 [email protected] [vm] Update offsets
2020-01-27 [email protected] Fixes failure of x86_64 builds for android
2020-01-27 [email protected] Flow analysis: fix shared tests to consider potential nullability instead of nullability.
2020-01-27 [email protected] [cfe] Handle promotion of nullable type variables
2020-01-27 [email protected] [infra] Add support for builders to pkg/smith
2020-01-27 [email protected] Change tests of lint-based quick fixes to not require the lint marker in the result
2020-01-27 [email protected] Update NORM and type parameters handling to new understanding.
2020-01-26 [email protected] Enable always_declare_return_types in analyzer_plugin
2020-01-26 [email protected] Add newly reviewed docs and change section header everywhere
2020-01-26 [email protected] Convert dartfix to use underscores rather than hyphens for fix names
2020-01-25 [email protected] Enable always_declare_return_types in analyzer_cli
2020-01-25 [email protected] Refactor dartfix to make the handling of lint fixes uniform
2020-01-25 [email protected] Split NormalizeHelper.
2020-01-25 [email protected] Extract NORM implementation into NormalizeHelper.
2020-01-25 [email protected] Update generators to not produce type annotations for variable declarations
2020-01-25 [email protected] Enable prefer_if_null_operators and prefer_spread_collections in analysis_server
2020-01-25 [email protected] [dart2js] Cleanup of a few dynamic calls
2020-01-25 [email protected] [dart2js] Redirecting a selector should clear cached element
2020-01-25 [email protected] [VM/libraries] Port some of the changes made in the sdk version of typed_data_patch.dart over to the sdk_nnbd version too.
2020-01-24 [email protected] Cleanup some analyzer hints
2020-01-24 [email protected] - simplify convertFileOrArgumentToUri to just use resolveInputUri - Allow non-file uris as a multi-root root
2020-01-24 [email protected] [dart2js] Add regression test for #40296.
2020-01-24 [email protected] Use test Matcher for checking Element(s).
2020-01-24 [email protected] [benchmarks] Add typed data copy benchmark
2020-01-24 [email protected] [vm] Generate different offsets for dart_precompiled_runtime
2020-01-24 [email protected] Revert "[vmservice] allow fallback on port bind failure"
2020-01-24 [email protected] Issue 39917. Test that Never is resolved as Never* in legacy.
2020-01-24 [email protected] Issue 40287. Don't report MISSING_DEFAULT_VALUE_FOR_PARAMETER for external and native methods.
2020-01-24 [email protected] [dart2js] Redirect all subclasses of JavaScriptObject.
2020-01-24 [email protected] Move old AnalysisDriverResolutionTest to DriverResolutionTest.
2020-01-24 [email protected] [nnbd_migration] CompletenessTracker to ensure EdgeBuilder visits all types.
2020-01-24 [email protected] [nnbd_migration] visit type names in type arguments
2020-01-24 [email protected] [nnbd_migration] Don't visit spread elements twice
2020-01-24 [email protected] [nnbd_migration] fix typo in instrumentation test
2020-01-24 [email protected] [nnbd_migration] visit type names in factory constructors
2020-01-24 [email protected] [nnbd_migration] visit type names in method type parameter bounds
2020-01-24 [email protected] [nnbd_migration] visit types in typed field formal parameters
2020-01-24 [email protected] [nnbd_migration] visit type names in class aliases
2020-01-24 [email protected] [nnbd_migration] visit type names in mixin type parameter bounds
2020-01-24 [email protected] [nnbd_migration] visit type names in extension extended type
2020-01-24 [email protected] [nnbd_migration] visit type names in for-in loops (&test regular for)
2020-01-24 [email protected] [nnbd_migration] visit type names in explicit invocation arguments
2020-01-24 [email protected] [nnbd_migration] visit type names in instance creation parameters
2020-01-24 [email protected] [nnbd_migration] visit type names in list, set, map literals
2020-01-24 [email protected] [nnbd_migration] visit type names in method type parameter bounds
2020-01-24 [email protected] [nnbd_migration] Visit types names in local variables
2020-01-24 [email protected] [nnbd_migration] visit type names in type parameter bounds
2020-01-24 [email protected] [nnbd_migration] visit type names in extends/implements
2020-01-24 [email protected] [nnbd_migration] visit type names in as casts
2020-01-24 [email protected] [nnbd_migration] visit TypeNames for function return types
2020-01-24 [email protected] [vm] Scrub and qualify names without allocating on the Dart heap.
2020-01-24 [email protected] Cleanup status file entries for service/dartkp crashes
2020-01-24 [email protected] [vmservice] allow fallback on port bind failure
2020-01-24 [email protected] Issue 40287. Don't report MISSING_DEFAULT_VALUE_FOR_PARAMETER for abstract methods.
2020-01-24 [email protected] [test] Move and migrate `dart:profiler` tests.
2020-01-24 [email protected] [dart2js] Fix incorrect SideEffects for native members
2020-01-24 [email protected] Don't run pkg/dartdev/test/command_test on dart2js
2020-01-24 [email protected] Use source-maps in test runner to expand JavaScript stack traces.
2020-01-24 [email protected] Migration: replace `?.` with `.` where appropriate.
2020-01-24 [email protected] Abstract resolution calls to `.isNullAware`.
2020-01-24 [email protected] Reland "[vm] resolve symbolic link to find kernel_service snapshot"
2020-01-24 [email protected] [VM/libraries] Fix final set of warnings from dart:async patch files.
2020-01-24 [email protected] fix diagnostic messages for named constructors
2020-01-24 [email protected] add mixed subtype test
2020-01-24 [email protected] Remove support for default fixes from dartfix
2020-01-24 [email protected] [io/file_watcher] Unregister watched pathId when handle is closed.
2020-01-24 [email protected] Updating iterable.current comments and behavior to be consistent.
2020-01-24 [email protected] NNBD preview: Fix recent display issues; fixes #40307
2020-01-24 [email protected] Require pre-initialized importToSummary and summaryToModule maps in the ProgramCompiler constructor, and remove the corresponding arguments from emitModule.
2020-01-24 [email protected] Update iterator.dart to fully spec moveNext()
2020-01-24 [email protected] Add Requirements to run this test only in the mode where it makes sense
2020-01-24 [email protected] Stop using List() constructor in NNBD code.
2020-01-24 [email protected] [vm/ffi] Split up compiler/ffi.cc into separate files
2020-01-24 [email protected] Sort declarations in api_test.dart
2020-01-24 [email protected] Fix an incorrect type annotation (issue 40299)
2020-01-24 [email protected] Correct date of v2.7.1 release (32nd -> 23rd Jan)
2020-01-24 [email protected] [cfe] Report errors on supertypes marked with "?"
2020-01-24 [email protected] [cfe] Compute correct type for read of late lowered variables
2020-01-24 [email protected] [cfe] Handle late variables in for loops
2020-01-24 [email protected] [cfe] Using isSameType in override checking of bounds
2020-01-24 [email protected] [SDK] Fixes service/break_on_default_constructor_test for --lazy-async-stacks.
2020-01-24 [email protected] [vm] Cleanups in the native_stack_traces package.
2020-01-24 [email protected] [CFE] Messages test doesn't allow status updates for spelling tests

Created with:
  gclient setdep -r src/third_party/dart@162d6c5634a0

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: [email protected]
@matthew-carroll
Notify PlatformViewsController within FlutterEngine when a hot restar…
eecb5e5 
…t occurs. (#48518) (#16230)
Pass through invoker.resources in fuchsia_test_archive (#16265)
22e31ae
@iskakaushik
[fuchsia] SceneHostBindings are no longer thread locals (#16262)
9361ee5 
Prior to this change SceneHostBindinds was a ThreadLocal but the
intention was for it to be IsolateLocal. Given that dart
could collect this map on a non-UI thread this caused
use-after-free issues.

This change fixes it by making it keyed on isolate and koid
this is not the ideal solution, this would exist on
dart isolate group data struct. Given that Fuchsia is moving
to use the embedder API, the decision to use this temporary
work around was made.

fixes flutter/flutter#49738
@iskakaushik
[fuchsia] Fix the import for dart_api.h (#16269)
74930e4
@stuartmorgan-g
Fix Windows file checks of unicode paths (#16105)
4655295
@jason-simmons
Revert "[web] Correct getPositionForOffset for multi-line paragraphs (#…
1370c9d 
…16206)" (#16268)

This reverts commit 4ac82f6.

This caused a regression in a framework test (material/text_field_splash_test.dart)
@skia-flutter-autoroll
Roll src/third_party/skia 36c0521..6305b2f (8 commits) (#16272)
4641a09 
https://skia.googlesource.com/skia.git/+log/36c0521d57de..6305b2f8342a

git log 36c0521..6305b2f --date=short --first-parent --format='%ad %ae %s'
2020-01-30 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2020-01-30 [email protected] [sksg] Clean up public headers
2020-01-30 [email protected] Expose the ICC profile from SkAndroidCodec
2020-01-30 [email protected] pdf rasterization
2020-01-30 [email protected] Update GrSurfaceProxy::Copy to return a view.
2020-01-30 [email protected] update release notes page to include M81
2020-01-30 [email protected] new section and formatting
2020-01-30 [email protected] Reland "Fix skshaper in component builds"

Created with:
  gclient setdep -r src/third_party/skia@6305b2f8342a

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: [email protected]
Revert "Migrate flutter_runner from flutter_runner::{Thread,Loop} to …
f5de1ac 
…fml::{Thread,MessageLoop} (#15118)" (#16277)

This reverts commit 41e8ed0.
@yjbanov
Use bundled Roboto in all tests (#16218)
804dca6 
* Use bundled Roboto in all tests
@chinmaygarde
Remove superfluous INFO logs from //flutter/runtime. (#16280)
d6b75b7 
These add no value to engine developers anymore and are not visible to external
users because of the low log severity.
@skia-flutter-autoroll skia-flutter-autoroll merged commit 346ee7f into skia-flutter-autoroll:master Jan 31, 2020
skia-flutter-autoroll added a commit that referenced this pull request Jul 16, 2020
@skia-flutter-autoroll
Roll Dart SDK from 6607655 to a3d3777 (18 revisions)
5e2d7f9 
https://dart.googlesource.com/sdk.git/+log/660765538200..a3d3777094ce

2020-07-16 [email protected] Migration: add a hook invoked after changes are applied.
2020-07-16 [email protected] [web] remove mirrors patch for web compilers.
2020-07-15 [email protected] [dart2js] Refractored ConstantValueTypeMasks
2020-07-15 [email protected] Modify parser to handle abstract fields.
2020-07-15 [email protected] bulk fixes impl
2020-07-15 [email protected] [dart2js] Port ~20 tests to nnbd #3.
2020-07-15 [email protected] [ package:dds ] Add missing package:shelf_static dependency in pubspec.yaml
2020-07-15 [email protected] Revert "Move `BytesBuilder` class and implementation to `dart:typed_data`."
2020-07-15 [email protected] [ package:dds ] Add server-sent event (SSE) support to DDS
2020-07-15 [email protected] Improve diagnostic message when short circuiting (issue 42599)
2020-07-15 [email protected] [ Service ] Fix line numbers in step_through_mixin_from_sdk_test
2020-07-15 [email protected] [ package:dds ] Fix issue where StateError could be thrown if DDS shuts down with in-flight requests
2020-07-15 [email protected] [vm/nnbd] Do not check if NNBD experimental flag is enabled for non-null assertions
2020-07-15 [email protected] Issue 42699. Stop reporting EXPORT_DUPLICATED_LIBRARY_NAMED and IMPORT_DUPLICATED_LIBRARY_NAMED.
2020-07-15 [email protected] [vm] Fix --use-bare-instructions=false on simarm_x64.
2020-07-15 [email protected] [vm] Add tests and packages to the Fuchsia package
2020-07-15 [email protected] Make CiderCacheEntry public.
2020-07-15 [email protected] [infra] Update Chrome used in testing to version 84

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
skia-flutter-autoroll added a commit that referenced this pull request Jul 16, 2020
@skia-flutter-autoroll
Roll Dart SDK from 1e78bd0 to ab958be (7 revisions)
cae5276 
https://dart.googlesource.com/sdk.git/+log/1e78bd069ee7..ab958bee577b

2020-07-16 [email protected] [cfe,flutter] Make widget transformer location parameters optional
2020-07-16 [email protected] Migration: add a hook invoked after changes are applied.
2020-07-16 [email protected] [web] remove mirrors patch for web compilers.
2020-07-15 [email protected] [dart2js] Refractored ConstantValueTypeMasks
2020-07-15 [email protected] Modify parser to handle abstract fields.
2020-07-15 [email protected] bulk fixes impl
2020-07-15 [email protected] [dart2js] Port ~20 tests to nnbd #3.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
skia-flutter-autoroll added a commit that referenced this pull request Jul 24, 2020
@skia-flutter-autoroll
Roll Skia from 3341934 to a75dc33 (6 revisions)
d9c53fe 
https://skia.googlesource.com/skia.git/+log/33419346946d..a75dc33a677f

2020-07-24 [email protected] Metal: Hold refs for input buffers from bindBuffer calls.
2020-07-24 [email protected] Reland #3 "ICU API: only in SkParagraph, simplified."
2020-07-24 [email protected] Remove GrTexturePriv
2020-07-24 [email protected] reduce mutex use and switch to spinlock
2020-07-24 [email protected] Make GrRingBuffer more generic so it can be used over all backends
2020-07-24 [email protected] implement working CorrectnessActivity to generate lottie keyframe PNGs

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
skia-flutter-autoroll pushed a commit that referenced this pull request Sep 2, 2020
@deakjahn
Image.toByteData and Picture.toImage implementations (#3) (flutter#20750
d67bda7 
)

* `Image.toByteData()` was not implemented in either DomCanvas or CanvasKit. This PR covers **both.**
* `Picture.toImage()` was not implemented in either DomCanvas or CanvasKit. This PR covers **CanvasKit**
skia-flutter-autoroll pushed a commit that referenced this pull request Apr 28, 2022
@chinmaygarde @dnfield
Back out changes to the Impeller dispatcher stub that depend on WIP i…
14bf827 
…nterface changes. (#3)
skia-flutter-autoroll pushed a commit that referenced this pull request Jul 7, 2023
@aam
Revert "Manual roll Dart SDK from 2d98d9e27dae to 0b07debd5862 (21 re…
5ae09b8 
…visions) (flutter#43457)" (flutter#43466)

This reverts commit a109e0b as it breaks flutter framework tests during subsequent roll.

From flutter/flutter#130138:

_TypeError: (#0      _ProgramInfoBuilder.createInfoNodeFor (package:vm_snapshot_analysis/v8_profile.dart:450:53))
```
#0      _ProgramInfoBuilder.createInfoNodeFor (package:vm_snapshot_analysis/v8_profile.dart:450:53)
#1      _ProgramInfoBuilder.getInfoNodeFor (package:vm_snapshot_analysis/v8_profile.dart:374:14)
#2      _ProgramInfoBuilder.createInfoNodeFor (package:vm_snapshot_analysis/v8_profile.dart:444:23)
#3      _ProgramInfoBuilder.getInfoNodeFor (package:vm_snapshot_analysis/v8_profile.dart:374:14)
#4      _ProgramInfoBuilder.createInfoNodeFor (package:vm_snapshot_analysis/v8_profile.dart:419:54)
#5      _ProgramInfoBuilder.getInfoNodeFor (package:vm_snapshot_analysis/v8_profile.dart:374:14)
#6      ListIterable.forEach (dart:_internal/iterable.dart:39:13)
#7      _ProgramInfoBuilder.build (package:vm_snapshot_analysis/v8_profile.dart:338:16)
#8      toProgramInfo (package:vm_snapshot_analysis/v8_profile.dart:282:8)
#9      _treemapFromSnapshot (package:vm_snapshot_analysis/treemap.dart:158:27)
#10     treemapFromJson (package:vm_snapshot_analysis/treemap.dart:85:5)
flutter#11     SizeAnalyzer.analyzeZipSizeAndAotSnapshot (package:flutter_tools/src/base/analyze_size.dart:123:59)
flutter#12     AndroidGradleBuilder._performCodeSizeAnalysis (package:flutter_tools/src/android/gradle.dart:623:60)
flutter#13     AndroidGradleBuilder.buildGradleApp (package:flutter_tools/src/android/gradle.dart:604:15)
<asynchronous suspension>
flutter#14     AndroidGradleBuilder.buildApk (package:flutter_tools/src/android/gradle.dart:242:5)
<asynchronous suspension>
flutter#15     BuildApkCommand.runCommand (package:flutter_tools/src/commands/build_apk.dart:116:5)
<asynchronous suspension>
flutter#16     FlutterCommand.run.<anonymous closure> (package:flutter_tools/src/runner/flutter_command.dart:1297:27)
<asynchronous suspension>
flutter#17     AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:150:19)
<asynchronous suspension>
flutter#18     CommandRunner.runCommand (package:args/command_runner.dart:212:13)
<asynchronous suspension>
```
skia-flutter-autoroll pushed a commit that referenced this pull request Apr 6, 2024
@dkwingsmt
Fix a memory error in a multithreaded test (flutter#51951)
b0d7ac5 
The culprit test asks different threads to access some stack variables, but the stack might return earlier than the threads' completion. This PR fixes it by adding latches.

This test, despite being possibly fine for now, consistently triggers the following asan error when I make some unrelated trivial changes.

The thrown error:
<details>
<pre>
[==========] Running 1 test from 1 test suite.
[----------] Global test environment set-up.
[----------] 1 test from EmbedderTest
[ RUN      ] EmbedderTest.EmbedderThreadHostUseCustomThreadConfig
=================================================================
==14398==ERROR: AddressSanitizer: stack-use-after-scope on address 0x00031833b530 at pc 0x00013248d543 bp 0x000318740390 sp 0x00031873fb58
WRITE of size 4 at 0x00031833b530 thread T2
    #0 0x13248d542 in pthread_getschedparam+0x3d2 (libclang_rt.asan_osx_dynamic.dylib:x86_64+0x2c542)
    #1 0x100577671 in flutter::testing::EmbedderTest_EmbedderThreadHostUseCustomThreadConfig_Test::TestBody()::$_0::operator()() const+0x1a1 (embedder_unittests:x86_64+0x10030b671)
    #2 0x1005774a2 in decltype(std::declval<flutter::testing::EmbedderTest_EmbedderThreadHostUseCustomThreadConfig_Test::TestBody()::$_0&>()()) std::_fl::__invoke[abi:v15000]<flutter::testing::EmbedderTest_EmbedderThreadHostUseCustomThreadConfig_Test::TestBody()::$_0&>(flutter::testing::EmbedderTest_EmbedderThreadHostUseCustomThreadConfig_Test::TestBody()::$_0&)+0x22 (embedder_unittests:x86_64+0x10030b4a2)
    #3 0x100577402 in void std::_fl::__invoke_void_return_wrapper<void, true>::__call<flutter::testing::EmbedderTest_EmbedderThreadHostUseCustomThreadConfig_Test::TestBody()::$_0&>(flutter::testing::EmbedderTest_EmbedderThreadHostUseCustomThreadConfig_Test::TestBody()::$_0&)+0x22 (embedder_unittests:x86_64+0x10030b402)
    #4 0x1005773ba in std::_fl::__function::__alloc_func<flutter::testing::EmbedderTest_EmbedderThreadHostUseCustomThreadConfig_Test::TestBody()::$_0, std::_fl::allocator<flutter::testing::EmbedderTest_EmbedderThreadHostUseCustomThreadConfig_Test::TestBody()::$_0>, void ()>::operator()[abi:v15000]()+0x2a (embedder_unittests:x86_64+0x10030b3ba)
    #5 0x1005734f6 in std::_fl::__function::__func<flutter::testing::EmbedderTest_EmbedderThreadHostUseCustomThreadConfig_Test::TestBody()::$_0, std::_fl::allocator<flutter::testing::EmbedderTest_EmbedderThreadHostUseCustomThreadConfig_Test::TestBody()::$_0>, void ()>::operator()()+0x26 (embedder_unittests:x86_64+0x1003074f6)
    #6 0x10066a525 in std::_fl::__function::__value_func<void ()>::operator()[abi:v15000]() const+0x105 (embedder_unittests:x86_64+0x1003fe525)
    #7 0x10066a3f2 in std::_fl::function<void ()>::operator()() const+0x22 (embedder_unittests:x86_64+0x1003fe3f2)
    #8 0x100c229dc in fml::MessageLoopImpl::FlushTasks(fml::FlushType)+0x37c (embedder_unittests:x86_64+0x1009b69dc)
    #9 0x100c22577 in fml::MessageLoopImpl::RunExpiredTasksNow()+0x27 (embedder_unittests:x86_64+0x1009b6577)
    #10 0x100c8aa2f in fml::MessageLoopDarwin::OnTimerFire(__CFRunLoopTimer*, fml::MessageLoopDarwin*)+0x2f (embedder_unittests:x86_64+0x100a1ea2f)
    flutter#11 0x7ff817b54508 in __CFRUNLOOP_IS_CALLING_OUT_TO_A_TIMER_CALLBACK_FUNCTION__+0x13 (CoreFoundation:x86_64+0x97508)
    flutter#12 0x7ff817b540b8 in __CFRunLoopDoTimer+0x310 (CoreFoundation:x86_64+0x970b8)
    flutter#13 0x7ff817b53ce9 in __CFRunLoopDoTimers+0x11c (CoreFoundation:x86_64+0x96ce9)
    flutter#14 0x7ff817b380ac in __CFRunLoopRun+0x83b (CoreFoundation:x86_64+0x7b0ac)
    flutter#15 0x7ff817b372a8 in CFRunLoopRunSpecific+0x22c (CoreFoundation:x86_64+0x7a2a8)
    flutter#16 0x100c8b155 in fml::MessageLoopDarwin::Run()+0x305 (embedder_unittests:x86_64+0x100a1f155)
    flutter#17 0x100c223d0 in fml::MessageLoopImpl::DoRun()+0x150 (embedder_unittests:x86_64+0x1009b63d0)
    flutter#18 0x100c1f1fa in fml::MessageLoop::Run()+0x2a (embedder_unittests:x86_64+0x1009b31fa)
    flutter#19 0x100c7baa4 in fml::Thread::Thread(std::_fl::function<void (fml::Thread::ThreadConfig const&)> const&, fml::Thread::ThreadConfig const&)::$_0::operator()() const+0x194 (embedder_unittests:x86_64+0x100a0faa4)
    flutter#20 0x100c7b8e2 in decltype(std::declval<fml::Thread::Thread(std::_fl::function<void (fml::Thread::ThreadConfig const&)> const&, fml::Thread::ThreadConfig const&)::$_0&>()()) std::_fl::__invoke[abi:v15000]<fml::Thread::Thread(std::_fl::function<void (fml::Thread::ThreadConfig const&)> const&, fml::Thread::ThreadConfig const&)::$_0&>(fml::Thread::Thread(std::_fl::function<void (fml::Thread::ThreadConfig const&)> const&, fml::Thread::ThreadConfig const&)::$_0&)+0x22 (embedder_unittests:x86_64+0x100a0f8e2)
    #21 0x100c7b842 in void std::_fl::__invoke_void_return_wrapper<void, true>::__call<fml::Thread::Thread(std::_fl::function<void (fml::Thread::ThreadConfig const&)> const&, fml::Thread::ThreadConfig const&)::$_0&>(fml::Thread::Thread(std::_fl::function<void (fml::Thread::ThreadConfig const&)> const&, fml::Thread::ThreadConfig const&)::$_0&)+0x22 (embedder_unittests:x86_64+0x100a0f842)
    #22 0x100c7b7fa in std::_fl::__function::__alloc_func<fml::Thread::Thread(std::_fl::function<void (fml::Thread::ThreadConfig const&)> const&, fml::Thread::ThreadConfig const&)::$_0, std::_fl::allocator<fml::Thread::Thread(std::_fl::function<void (fml::Thread::ThreadConfig const&)> const&, fml::Thread::ThreadConfig const&)::$_0>, void ()>::operator()[abi:v15000]()+0x2a (embedder_unittests:x86_64+0x100a0f7fa)
    #23 0x100c77ad6 in std::_fl::__function::__func<fml::Thread::Thread(std::_fl::function<void (fml::Thread::ThreadConfig const&)> const&, fml::Thread::ThreadConfig const&)::$_0, std::_fl::allocator<fml::Thread::Thread(std::_fl::function<void (fml::Thread::ThreadConfig const&)> const&, fml::Thread::ThreadConfig const&)::$_0>, void ()>::operator()()+0x26 (embedder_unittests:x86_64+0x100a0bad6)
    #24 0x10066a525 in std::_fl::__function::__value_func<void ()>::operator()[abi:v15000]() const+0x105 (embedder_unittests:x86_64+0x1003fe525)
    #25 0x10066a3f2 in std::_fl::function<void ()>::operator()() const+0x22 (embedder_unittests:x86_64+0x1003fe3f2)
    #26 0x100c75388 in fml::ThreadHandle::ThreadHandle(std::_fl::function<void ()>&&)::$_0::operator()(void*) const+0xe8 (embedder_unittests:x86_64+0x100a09388)
    #27 0x100c75227 in fml::ThreadHandle::ThreadHandle(std::_fl::function<void ()>&&)::$_0::__invoke(void*)+0xc7 (embedder_unittests:x86_64+0x100a09227)
    #28 0x1324b3e76 in asan_thread_start(void*)+0x46 (libclang_rt.asan_osx_dynamic.dylib:x86_64+0x52e76)
    #29 0x7ff817a5c18a in _pthread_start+0x62 (libsystem_pthread.dylib:x86_64+0x618a)
    #30 0x7ff817a57ae2 in thread_start+0xe (libsystem_pthread.dylib:x86_64+0x1ae2)

Address 0x00031833b530 is located in stack of thread T0 at offset 144 in frame
    #0 0x1002d051f in flutter::testing::EmbedderTest_EmbedderThreadHostUseCustomThreadConfig_Test::TestBody()+0xf (embedder_unittests:x86_64+0x10006451f)

  This frame has 12 object(s):
    [32, 40) 'thread_host' (line 3445)
    [64, 112) 'ref.tmp' (line 3446)
    [144, 148) 'ui_policy' (line 3449) <== Memory access at offset 144 is inside this variable
    [160, 168) 'ui_param' (line 3450)
    [192, 200) 'ref.tmp2' (line 3452)
    [224, 272) 'ref.tmp5' (line 3452)
    [304, 320) 'agg.tmp'
    [336, 340) 'io_policy' (line 3458)
    [352, 360) 'io_param' (line 3459)
    [384, 392) 'ref.tmp6' (line 3460)
    [416, 464) 'ref.tmp10' (line 3460)
    [496, 512) 'agg.tmp11'
HINT: this may be a false positive if your program uses some custom stack unwind mechanism, swapcontext or vfork
      (longjmp and C++ exceptions *are* supported)
SUMMARY: AddressSanitizer: stack-use-after-scope (libclang_rt.asan_osx_dynamic.dylib:x86_64+0x2c542) in pthread_getschedparam+0x3d2
Shadow bytes around the buggy address:
  0x00031833b280: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
  0x00031833b300: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
  0x00031833b380: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
  0x00031833b400: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
  0x00031833b480: 00 00 00 00 f1 f1 f1 f1 00 f2 f2 f2 f8 f8 f8 f8
=>0x00031833b500: f8 f8 f2 f2 f2 f2[f8]f2 f8 f2 f2 f2 f8 f2 f2 f2
  0x00031833b580: f8 f8 f8 f8 f8 f8 f2 f2 f2 f2 00 00 f2 f2 f8 f2
  0x00031833b600: f8 f2 f2 f2 f8 f2 f2 f2 f8 f8 f8 f8 f8 f8 f2 f2
  0x00031833b680: f2 f2 00 00 f3 f3 f3 f3 00 00 00 00 00 00 00 00
  0x00031833b700: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
  0x00031833b780: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
Shadow byte legend (one shadow byte represents 8 application bytes):
  Addressable:           00
  Partially addressable: 01 02 03 04 05 06 07 
  Heap left redzone:       fa
  Freed heap region:       fd
  Stack left redzone:      f1
  Stack mid redzone:       f2
  Stack right redzone:     f3
  Stack after return:      f5
  Stack use after scope:   f8
  Global redzone:          f9
  Global init order:       f6
  Poisoned by user:        f7
  Container overflow:      fc
  Array cookie:            ac
  Intra object redzone:    bb
  ASan internal:           fe
  Left alloca redzone:     ca
  Right alloca redzone:    cb
Thread T2 created by T0 here:
    #0 0x1324ae92d in pthread_create+0x5d (libclang_rt.asan_osx_dynamic.dylib:x86_64+0x4d92d)
    #1 0x100c73901 in fml::ThreadHandle::ThreadHandle(std::_fl::function<void ()>&&)+0x401 (embedder_unittests:x86_64+0x100a07901)
    #2 0x100c73cca in fml::ThreadHandle::ThreadHandle(std::_fl::function<void ()>&&)+0x2a (embedder_unittests:x86_64+0x100a07cca)
    #3 0x100c748c9 in std::_fl::__unique_if<fml::ThreadHandle>::__unique_single std::_fl::make_unique[abi:v15000]<fml::ThreadHandle, fml::Thread::Thread(std::_fl::function<void (fml::Thread::ThreadConfig const&)> const&, fml::Thread::ThreadConfig const&)::$_0>(fml::Thread::Thread(std::_fl::function<void (fml::Thread::ThreadConfig const&)> const&, fml::Thread::ThreadConfig const&)::$_0&&)+0x149 (embedder_unittests:x86_64+0x100a088c9)
    #4 0x100c74335 in fml::Thread::Thread(std::_fl::function<void (fml::Thread::ThreadConfig const&)> const&, fml::Thread::ThreadConfig const&)+0x255 (embedder_unittests:x86_64+0x100a08335)
    #5 0x100c746b2 in fml::Thread::Thread(std::_fl::function<void (fml::Thread::ThreadConfig const&)> const&, fml::Thread::ThreadConfig const&)+0x32 (embedder_unittests:x86_64+0x100a086b2)
    #6 0x106ee0b1a in std::_fl::__unique_if<fml::Thread>::__unique_single std::_fl::make_unique[abi:v15000]<fml::Thread, std::_fl::function<void (fml::Thread::ThreadConfig const&)> const&, fml::Thread::ThreadConfig&>(std::_fl::function<void (fml::Thread::ThreadConfig const&)> const&, fml::Thread::ThreadConfig&)+0x4a (embedder_unittests:x86_64+0x106c74b1a)
    #7 0x106ee08e8 in flutter::ThreadHost::CreateThread(flutter::ThreadHost::Type, std::_fl::optional<fml::Thread::ThreadConfig>, flutter::ThreadHost::ThreadHostConfig const&) const+0x1b8 (embedder_unittests:x86_64+0x106c748e8)
    #8 0x106ee1466 in flutter::ThreadHost::ThreadHost(flutter::ThreadHost::ThreadHostConfig const&)+0x2f6 (embedder_unittests:x86_64+0x106c75466)
    #9 0x106ee19ca in flutter::ThreadHost::ThreadHost(flutter::ThreadHost::ThreadHostConfig const&)+0x2a (embedder_unittests:x86_64+0x106c759ca)
    #10 0x100b6f730 in flutter::EmbedderThreadHost::CreateEngineManagedThreadHost(std::_fl::function<void (fml::Thread::ThreadConfig const&)> const&)+0x3a0 (embedder_unittests:x86_64+0x100903730)
    flutter#11 0x100b6e51c in flutter::EmbedderThreadHost::CreateEmbedderOrEngineManagedThreadHost(FlutterCustomTaskRunners const*, std::_fl::function<void (fml::Thread::ThreadConfig const&)> const&)+0xcc (embedder_unittests:x86_64+0x10090251c)
    flutter#12 0x1002d0748 in flutter::testing::EmbedderTest_EmbedderThreadHostUseCustomThreadConfig_Test::TestBody()+0x238 (embedder_unittests:x86_64+0x100064748)
    flutter#13 0x1089ce93b in void testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*)+0x21b (embedder_unittests:x86_64+0x10876293b)
    flutter#14 0x108955bdf in void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*)+0x2cf (embedder_unittests:x86_64+0x1086e9bdf)
    flutter#15 0x108955755 in testing::Test::Run()+0x3a5 (embedder_unittests:x86_64+0x1086e9755)
    flutter#16 0x108957b23 in testing::TestInfo::Run()+0x593 (embedder_unittests:x86_64+0x1086ebb23)
    flutter#17 0x10895a8f2 in testing::TestSuite::Run()+0x6e2 (embedder_unittests:x86_64+0x1086ee8f2)
    flutter#18 0x108977d7a in testing::internal::UnitTestImpl::RunAllTests()+0xb9a (embedder_unittests:x86_64+0x10870bd7a)
    flutter#19 0x1089ee88b in bool testing::internal::HandleSehExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*)+0x21b (embedder_unittests:x86_64+0x10878288b)
    flutter#20 0x1089770ac in bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*)+0x2cc (embedder_unittests:x86_64+0x10870b0ac)
    #21 0x108976c3b in testing::UnitTest::Run()+0x28b (embedder_unittests:x86_64+0x10870ac3b)
    #22 0x1083e45e2 in RUN_ALL_TESTS()+0x22 (embedder_unittests:x86_64+0x1081785e2)
    #23 0x1083e43c8 in main+0x6e8 (embedder_unittests:x86_64+0x1081783c8)
    #24 0x213ff0365  (<unknown module>)

==14398==ABORTING
[1]    14398 abort      ../out/host_debug_unopt/embedder_unittests 
</pre>
</details>

The changes I made (isolated from a larger change, therefore it doesn't seem reasonable by itself):
```diff
 // shell/common/platform_view.cc, L33

 void PlatformView::DispatchPointerDataPacket(
     std::unique_ptr<PointerDataPacket> packet) {
-  delegate_.OnPlatformViewDispatchPointerDataPacket(
-      pointer_data_packet_converter_.Convert(std::move(packet)));
+  delegate_.OnPlatformViewDispatchPointerDataPacket(std::move(packet));
 }
```

Base engine rev: de2a73c

Environment: Macbook with M1 Max Chip, OS 14.4.1

Compiling with:
```
./engine/src/flutter/tools/gn --goma --unoptimized --asan --xcode-symlinks
./depot_tools/ninja -j200 -C ./engine/src/out/host_debug_unopt
./out/host_debug_unopt/embedder_unittests
```

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.