This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Add support for on/off switch labels when built on iOS 13. #12467
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandondiamond
commented
Sep 26, 2019
| "$fuchsia_sdk_root/pkg:vfs_cpp", | ||
| "$fuchsia_sdk_root/pkg:zx", |
There was a problem hiding this comment.
This was altered by the formatting script. Not sure if I should revert or leave alone.
There was a problem hiding this comment.
No. Leave it be. This is good. We format all our GN files. I believe this one was imported from //topaz as-is recently.
chinmaygarde
approved these changes
Sep 26, 2019
| "$fuchsia_sdk_root/pkg:vfs_cpp", | ||
| "$fuchsia_sdk_root/pkg:zx", |
There was a problem hiding this comment.
No. Leave it be. This is good. We format all our GN files. I believe this one was imported from //topaz as-is recently.
|
Migration to the latest SDK is pending in https://github.com/flutter/infra/pull/62 |
@chinmaygarde is this PR blocked on https://github.com/flutter/infra/pull/62 ? I know https://github.com/flutter/infra/pull/62 is blocked on the device lab updates, but it's not clear to me that this PR needs to wait for those changes, as it wouldn't break anything pre iOS13 right? |
|
flutter/infra#62 has landed, but the devices are still iOS 12. It's not necessary to wait for them to be upgraded, but we do need the engine builder recipes migrated to Xcode 11 with the iOS 13 SDK. I believe @chinmaygarde made one attempt at that but that ended up being reverted. Once that's re-landed, this should be landable. |
|
🎉 that's great news! thanks for everything.
…On Wed, Jan 8, 2020 at 7:19 PM LongCatIsLooong ***@***.***> wrote:
@brandondiamond <https://github.com/brandondiamond> flutter/infra#62
<https://github.com/flutter/infra/pull/62> is relanded.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#12467?email_source=notifications&email_token=AAH5FMCUHDPDC3NTOOT4EKLQ4ZURNA5CNFSM4I26UGXKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIOO3MI#issuecomment-572321201>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAH5FMEKWLC6FK62EDQ3673Q4ZURNANCNFSM4I26UGXA>
.
|
|
Merged. Fingers crossed! |
This was referenced Jan 9, 2020
cbracken
added a commit
that referenced
this pull request
Jan 9, 2020
…12467)" (#15370) Broke a fake implementation of Accessibility features in the framework. While this change is unlikely to break any users in the wild, this is a breaking change by the standards set out in our documentation and should follow the breaking change announcement process. Details can be found at https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes. The error in question: Missing concrete implementation of 'getter AccessibilityFeatures.onOffSwitchLabels' • packages/flutter_test/test/window_test.dart:252:7 • non_abstract_class_inherits_abstract_member This reverts commit d12f2a6.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 10, 2020
This was referenced Jan 10, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 10, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 10, 2020
This was referenced Jan 10, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 10, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 10, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 10, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 10, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 10, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 11, 2020
NoamDev
pushed a commit
to NoamDev/engine
that referenced
this pull request
Feb 27, 2020
NoamDev
pushed a commit
to NoamDev/engine
that referenced
this pull request
Feb 27, 2020
…lutter#12467)" (flutter#15370) Broke a fake implementation of Accessibility features in the framework. While this change is unlikely to break any users in the wild, this is a breaking change by the standards set out in our documentation and should follow the breaking change announcement process. Details can be found at https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes. The error in question: Missing concrete implementation of 'getter AccessibilityFeatures.onOffSwitchLabels' • packages/flutter_test/test/window_test.dart:252:7 • non_abstract_class_inherits_abstract_member This reverts commit d12f2a6.
NoamDev
added a commit
to NoamDev/engine
that referenced
this pull request
Feb 27, 2020
…S 13. (flutter#12467)" (flutter#15370)" This reverts commit ba5b381.
NoamDev
added a commit
to NoamDev/engine
that referenced
this pull request
Feb 27, 2020
…lutter#12467)" This reverts commit 5aca558.
filmil
pushed a commit
to filmil/engine
that referenced
this pull request
Mar 13, 2020
filmil
pushed a commit
to filmil/engine
that referenced
this pull request
Mar 13, 2020
…lutter#12467)" (flutter#15370) Broke a fake implementation of Accessibility features in the framework. While this change is unlikely to break any users in the wild, this is a breaking change by the standards set out in our documentation and should follow the breaking change announcement process. Details can be found at https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes. The error in question: Missing concrete implementation of 'getter AccessibilityFeatures.onOffSwitchLabels' • packages/flutter_test/test/window_test.dart:252:7 • non_abstract_class_inherits_abstract_member This reverts commit d12f2a6.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #12404 but verifies platform is iOS 13. Shouldn't merge until build bots have been updated to support iOS 13.