Use iOS 13 dark content status bar style #13119

jayjun · 2019-10-14T11:19:05Z

On iOS 13 when Dark Mode is enabled, UIStatusBarStyleDefault uses light text for the status bar instead of dark text.

Since Flutter can only choose between UIStatusBarStyleDefault and UIStatusBarStyleLightContent (light text), the status bar is always white when in Dark Mode.

With this pull request, UIStatusBarStyleDarkContent is specified when dark text is needed.

chinmaygarde · 2019-10-14T19:01:12Z

We are still in the process of migrating bots to Xcode 11.0 and iOS SDK 13.0. So this won't actually pass the commit bots. The infra update is being tracked in https://github.com/flutter/infra/pull/62 with had to be reverted due to unrelated issues.

cbracken

cbracken · 2019-10-21T18:09:30Z

The bots are now updated to Xcode 11.

chinmaygarde · 2019-10-21T18:25:45Z

@cbracken Are you sure? https://github.com/flutter/infra/commit/f53b002167c06751ef7a603d14f5a8d9e44a178c hasn't relanded but I am not sure if there is some other way to specify the update.

cbracken · 2019-10-21T18:34:19Z

My mistake -- my understanding is that the devicelab has been updated but I think your bot upgrade PR was reverted?

isacjunior · 2019-10-31T17:26:56Z

Any prevision or news about to merge this pull request?

cbracken · 2019-11-04T18:52:34Z

We're going to take another pass at the bots to ensure our infra is updated to Xcode 11 with the iOS 13 SDK then I think we're good to merge.

jpapay · 2019-11-19T10:43:12Z

Hey, any prevision or news about merging this pull request ?

aaronpon · 2019-11-27T15:43:49Z

Please merge

KSubedi · 2019-12-04T19:46:33Z

What is the holdup for this merge?

droplet-js · 2019-12-09T06:16:09Z

Any prevision or news about to merge this pull request?

theneshofficial · 2019-12-09T06:17:31Z

Please merge this request.

marcoms · 2019-12-17T10:42:09Z

Hi Flutter team, this issue is quite an important one for a lot of people on account of the fact we now have invisible status bars on iOS. Is there any holdup for merging this PR?

jaddoescad · 2019-12-19T04:43:38Z

Please Merge

chavesgu · 2019-12-24T02:43:47Z

Please merge

izabekz · 2019-12-24T05:52:12Z

@chinmaygarde is there any predictions on when this will be merged?

sooxt98 · 2019-12-26T18:54:29Z

MERGE 🔥🔥🔥

jaddoescad · 2019-12-30T14:56:43Z

Please merge 😭

theneshofficial · 2019-12-31T02:10:22Z

Please merge this PR @brianosman

zakiso · 2020-01-02T17:23:14Z

Please merge

Adem68 · 2020-01-04T16:14:17Z

Please merge -__-

angelorobo · 2020-01-07T05:57:41Z

Please merge!!!

bruce-brookshire · 2020-01-08T22:22:14Z

Please merge 😭

cbracken · 2020-01-08T22:54:12Z

We expect to get this merged within the next few days. It's pending infra upgrades to XCode 11 and iOS 13 SDK. Good news is those infra updates have started landing yesterday/today. Once we've verified that the upgrades look good and all engine tests are passing, we'll get this landed.

Please use GitHub reactions to thumbs-up/vote on issues rather than adding additional comments; we're also keen to get this landed. Thanks again for the contribution and apologies for the delay in getting our infra upgraded.

LongCatIsLooong · 2020-01-09T00:26:10Z

@cbracken looks like everything is green

cbracken · 2020-01-09T02:29:08Z

Just landed #12467 which also depends on iOS 13. Assuming infra looks green, I'll land this one next.

samuelematias · 2020-01-15T18:45:59Z

Prediction of this merge T.T ?

cbracken · 2020-01-15T19:07:48Z

Prediction of this merge T.T ?

10 seconds ago :-) Thanks for the reminder!

flutter/engine@3488051...be20fb6 git log 3488051..be20fb6 --first-parent --oneline 2020-01-15 [email protected] [web] Exec command copy (flutter/engine#15675) 2020-01-15 [email protected] Disable fml_unittests till flakes are addressed. (flutter/engine#15676) 2020-01-15 [email protected] Roll src/third_party/dart fe666ce592cb..862d5012ae9c (48 commits) (flutter/engine#15672) 2020-01-15 [email protected] Fix hardware keyboard enter so it triggers an action. (flutter/engine#15568) 2020-01-15 [email protected] Use iOS 13 dark content status bar style (flutter/engine#13119) 2020-01-15 [email protected] Roll fuchsia/sdk/core/linux-amd64 from oxHfW... to UlOSN... (flutter/engine#15670) 2020-01-15 [email protected] Roll src/third_party/skia e45c5cd03eeb..7655168e6865 (29 commits) (flutter/engine#15671) 2020-01-15 [email protected] Fix embedder mutation order (flutter/engine#15566) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

This reverts commit fdba8f6.

NaosFr · 2020-03-06T13:58:40Z

Hello, do you have a date for the patch to be operational on our projects ?

Thank you 😇

googlebot added the cla: yes label Oct 14, 2019

jayjun force-pushed the dark branch from 04b1860 to 8be7e61 Compare October 14, 2019 11:20

jayjun changed the title ~~Support iOS 13 dark content status bar style~~ Use iOS 13 dark content status bar style Oct 14, 2019

jayjun mentioned this pull request Oct 14, 2019

Flutter not automatically changing the status bar icons to black on devices running iOS 13.0 in Dark Mode it only does so when Dark Mode on iOS 13 is turned off flutter/flutter#41067

Closed

Use iOS 13 dark content status bar style

60e8852

jayjun force-pushed the dark branch from 8be7e61 to 60e8852 Compare October 14, 2019 11:46

cbracken approved these changes Oct 21, 2019

View reviewed changes

darrenaustin mentioned this pull request Oct 21, 2019

Unable to set notification bar icon color/brightness when in ios dark mode flutter/flutter#41188

Closed

beeradmoore mentioned this pull request Oct 30, 2019

[Bug] UIStatusBarStyle does not appear to change when device is in dark mode xamarin/Xamarin.Forms#8294

Closed

aaronpon approved these changes Nov 27, 2019

View reviewed changes

jpapay approved these changes Nov 27, 2019

View reviewed changes

guidezpl mentioned this pull request Dec 4, 2019

Status bar color can get out of sync with the theme material-components/material-components-flutter-gallery#444

Closed

marcoms approved these changes Dec 8, 2019

View reviewed changes

cbracken merged commit 8101136 into flutter:master Jan 15, 2020

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 16, 2020

8101136 Use iOS 13 dark content status bar style (flutter/engine#13119)

a412f48

engine-flutter-autoroll mentioned this pull request Jan 16, 2020

Roll engine 348805107fe1..4dc03029f702 (6 commits) flutter/flutter#48926

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 16, 2020

8101136 Use iOS 13 dark content status bar style (flutter/engine#13119)

dd0b5d8

engine-flutter-autoroll mentioned this pull request Jan 16, 2020

Roll engine 348805107fe1..4dc03029f702 (6 commits) flutter/flutter#48931

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 16, 2020

8101136 Use iOS 13 dark content status bar style (flutter/engine#13119)

337fe8e

engine-flutter-autoroll mentioned this pull request Jan 16, 2020

Roll engine 348805107fe1..4dc03029f702 (6 commits) flutter/flutter#48935

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 16, 2020

8101136 Use iOS 13 dark content status bar style (flutter/engine#13119)

ddb3ea0

engine-flutter-autoroll mentioned this pull request Jan 16, 2020

Roll engine 348805107fe1..be20fb661a69 (8 commits) flutter/flutter#48936

Merged

jayjun deleted the dark branch January 21, 2020 12:29

NoamDev pushed a commit to NoamDev/engine that referenced this pull request Feb 27, 2020

Use iOS 13 dark content status bar style (flutter#13119)

fdba8f6

NoamDev added a commit to NoamDev/engine that referenced this pull request Feb 27, 2020

Revert "Use iOS 13 dark content status bar style (flutter#13119)"

aeb9ee3

This reverts commit fdba8f6.

filmil pushed a commit to filmil/engine that referenced this pull request Mar 13, 2020

Use iOS 13 dark content status bar style (flutter#13119)

eee96fc

Use iOS 13 dark content status bar style #13119

Use iOS 13 dark content status bar style #13119

Uh oh!

Conversation

jayjun commented Oct 14, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chinmaygarde commented Oct 14, 2019

Uh oh!

cbracken left a comment

Choose a reason for hiding this comment

Uh oh!

cbracken commented Oct 21, 2019

Uh oh!

chinmaygarde commented Oct 21, 2019

Uh oh!

cbracken commented Oct 21, 2019

Uh oh!

isacjunior commented Oct 31, 2019

Uh oh!

cbracken commented Nov 4, 2019

Uh oh!

jpapay commented Nov 19, 2019

Uh oh!

aaronpon commented Nov 27, 2019

Uh oh!

KSubedi commented Dec 4, 2019

Uh oh!

droplet-js commented Dec 9, 2019

Uh oh!

theneshofficial commented Dec 9, 2019

Uh oh!

marcoms commented Dec 17, 2019

Uh oh!

jaddoescad commented Dec 19, 2019

Uh oh!

chavesgu commented Dec 24, 2019

Uh oh!

izabekz commented Dec 24, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sooxt98 commented Dec 26, 2019

Uh oh!

jaddoescad commented Dec 30, 2019

Uh oh!

theneshofficial commented Dec 31, 2019

Uh oh!

zakiso commented Jan 2, 2020

Uh oh!

Adem68 commented Jan 4, 2020

Uh oh!

angelorobo commented Jan 7, 2020

Uh oh!

bruce-brookshire commented Jan 8, 2020

Uh oh!

cbracken commented Jan 8, 2020

Uh oh!

LongCatIsLooong commented Jan 9, 2020

Uh oh!

cbracken commented Jan 9, 2020

Uh oh!

samuelematias commented Jan 15, 2020

Uh oh!

cbracken commented Jan 15, 2020

Uh oh!

NaosFr commented Mar 6, 2020

Uh oh!

Uh oh!

jayjun commented Oct 14, 2019 •

edited

Loading

izabekz commented Dec 24, 2019 •

edited

Loading